Re: [PATCH v5 09/12] block/blk-mq-debugfs: Improve lock context annotations

[Christoph Hellwig <hch@lst.de>]

On Thu, May 28, 2026 at 12:45:46PM -0700, Bart Van Assche wrote:
> Make the existing lock context annotations compatible with Clang. Add
> the lock context annotations that are missing.
> 
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  block/blk-mq-debugfs.c | 12 ++++++------
>  block/blk.h            |  4 ++++
>  2 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index 047ec887456b..5c168e82273e 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -20,7 +20,7 @@ static int queue_poll_stat_show(void *data, struct seq_file *m)
>  }
>  
>  static void *queue_requeue_list_start(struct seq_file *m, loff_t *pos)
> -	__acquires(&q->requeue_lock)
> +	__acquires(&((struct request_queue *)m->private)->requeue_lock)

I try to member where we got stuck on this, but isn't there a way
to at least have a macro for this dereference that can have a comment?

Also I guess most seq_file users will have a mess like this, but I
don't really know a good way around it.