From: Christoph Hellwig <hch@lst.de>
To: Greg Ungerer <gerg@kernel.org>
Cc: Angelo Dureghello <adureghello@baylibre.com>,
Arnd Bergmann <arnd@kernel.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-can@vger.kernel.org,
linux-spi@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC 4/4] m68k: coldfire: fix non-standard readX()/writeX() functions
Date: Mon, 1 Jun 2026 16:43:32 +0200 [thread overview]
Message-ID: <20260601144332.GC4918@lst.de> (raw)
In-Reply-To: <2b532d56-dce4-4f6d-84e0-2fd87d5494f8@kernel.org>
On Sun, May 31, 2026 at 11:42:26PM +1000, Greg Ungerer wrote:
> I don't think that is right. The way the underlying data cache is setup for
> MMU ColdFire (via the ACR/CACR registers) means that individual pages cannot
> be marked as non-cached. So coherent memory allocations are not possible -
> at least the way things are today.
>
> It would be possible to set aside a chunk of RAM at kernel startup time
> to use as a pool for coherent allocations (since it could be marked as
> non-cached via the ACR/CACR registers), but there is no code to support doing
> that today.
With CONFIG_DMA_GLOBAL_POOL there is some generic code dealing with
most of this. But if this driver worked on coldfire in the past,
it must have been fine with non-coherent memory and could use the
non-coherent allocator.
next prev parent reply other threads:[~2026-06-01 14:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 14:26 [RFC 1/4] net: fec: do not use readl()/writel() for ColdFire Greg Ungerer
2026-05-06 14:26 ` [RFC 2/4] net: smc91x: do not use readw()/writew() on ColdFire platforms Greg Ungerer
2026-05-06 14:26 ` [RFC 3/4] mmc: sdhci-esdhc-mcf: do not use readl()/writel() on ColdFire Greg Ungerer
2026-05-11 15:11 ` Ulf Hansson
2026-05-17 19:00 ` Angelo Dureghello
2026-05-18 7:17 ` Greg Ungerer
2026-05-06 14:26 ` [RFC 4/4] m68k: coldfire: fix non-standard readX()/writeX() functions Greg Ungerer
2026-05-06 16:14 ` Frank Li
2026-05-06 19:12 ` Arnd Bergmann
2026-05-07 12:43 ` Greg Ungerer
2026-05-07 12:59 ` Arnd Bergmann
2026-05-17 19:43 ` Angelo Dureghello
2026-05-17 20:08 ` Arnd Bergmann
2026-05-17 22:04 ` Angelo Dureghello
2026-05-17 22:41 ` Angelo Dureghello
2026-05-24 21:17 ` Angelo Dureghello
2026-05-24 21:34 ` Angelo Dureghello
2026-05-25 13:39 ` Angelo Dureghello
2026-05-31 13:42 ` Greg Ungerer
2026-06-01 14:43 ` Christoph Hellwig [this message]
2026-05-07 13:30 ` Marc Kleine-Budde
2026-05-07 14:33 ` Greg Ungerer
2026-05-08 2:46 ` [RFC 1/4] net: fec: do not use readl()/writel() for ColdFire Wei Fang
2026-05-08 8:40 ` David Laight
2026-05-08 13:14 ` Greg Ungerer
2026-05-08 13:11 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601144332.GC4918@lst.de \
--to=hch@lst.de \
--cc=adureghello@baylibre.com \
--cc=arnd@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gerg@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.