From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8433D7D67 for ; Mon, 1 Jun 2026 15:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780326183; cv=none; b=Nsbo/r7YVPg/wj2B745sV/9KvWoHhT71tatsS0ywnfKbDB7Vh/IddqCIGxO2t8pmApoOaI5qPDXKDQN0vsKvP4srY6AjrJ1acefbZFIAnDzHOu6XIjQcI86ilHK/V8s9xyhplv6+ivD5EMAmBFR/mI9C/KtMSz6hjVNszNiaHVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780326183; c=relaxed/simple; bh=g9f3SCn5GupVBW5PSH4Y+9JK10KrZbmSx9F2MoVrv/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fPwNIIEA4TZe8BP8HG6D4iFkfPxu40pHkP0P3JUozwWWnWeVtCu5mX9nbQZMG6B6bFIgNn0U2l5ZV1Dpolm+GEia7Qoz83kZJ8hMUO/5hJRWEFHhnNbiaBA5w8XVjUtwqFRqvtvyj5uAK8FE2i3Gn4I7DgXHjFsqjU/dm0BvbDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KRsc1e/E; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KRsc1e/E" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bebde89cfd3so226175266b.2 for ; Mon, 01 Jun 2026 08:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780326181; x=1780930981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pjSavsD8sHilBIq7cbqQIMGeXkIW87CdRUauefk+9e0=; b=KRsc1e/EDHk0y+MZm7AzqCsvQscznGvaoyefwu/zRLi6lbRkUtpbdzV8Hoe/4LYH/Y WlWUW+f847iWjl3GA0MUZC8YxGT1lWnDTzqLIUvUwdvZ3ZyGvO0tLEhDhIfqdd0m0BP5 i6LKpwBBGfS7vhmdb8wE74nQeaYlNlO119H2zdwgWAOgleMjVnxuxH3cgJCjYxXldNjk NJ2wgCTc2qEgzYCbnlm2xsGKYY9bzXv1BWCFD8CrwaJcO4hyErvSd1kTnmbyHTDqx5kc foUiMF4HNR1oEumG6tZO8AvfJV0IGBgjZxSA+4SmecNfnfy3yMKdG4D0DPLs1EcVGI6U RHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780326181; x=1780930981; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pjSavsD8sHilBIq7cbqQIMGeXkIW87CdRUauefk+9e0=; b=oqiuRuyuUVPiethLyItdXH4hf6sQV5dwjpdSIPGzRvdE2vP824fJWnQLXxspYpzJyk c5xnAYYe4On80XAOM+jksCVB2kq4ZXpxxtte3mLx3LArPIn4Dbzk7X8PNCWen3a4HLf7 RIeGLFulie/LPL1v9yURrrAK2O5NGlDWfhUdekbL53wKbF2WlY5g/L1dfJ4Wa3ndoA9+ Ewl5vyB8x6DfWFH/Snn82vMATl6IqLP3koEzg07TgctZfyq2ZCqOi4sFfrqPP3ZhMQzd 2w5+ROaB9ywhNK6tAr7zYvHFTAhqqGhUBpl0jReomF3foZ8J9TS7usvalwfMadrTKuiO LUsg== X-Forwarded-Encrypted: i=1; AFNElJ9mwX9bbrq1G+/WWAwflpA1kqQRv5MC8bAUyiabgkjXGq5mzfRT40+HET4iFA0hoibknpZQUVTpG0pllXY=@vger.kernel.org X-Gm-Message-State: AOJu0YyOqbioyyW/I2fQjexO2ayymmteqYNl05EB0F0rhh0B7WiiyuNB Wd3F7HKpWKRVQu2XrdWiaONpcmIpEXHHtEz8qm4F1BQ2011b2CQ65B83 X-Gm-Gg: Acq92OFdbDmoOQ+E+L5YjeUOI+LIbJxWkCpIwlAS5fVCjq5L1eSFKox+CnzhR4u5ZS5 1MYFRLuTFIfxNkXtt+lLyaoRR+04E1pTAueQA/RvZetM0Umykaw3Z4lPTMgFCaLNyxRsSz7KwgL UasnEUYTJJ/LyT9J6ft4Mg6ynk/MU18i6DcRpAucuojx9N0cBe2+FxPjPAMkyhVs+UynkqrO2WR EG55lACE+wj0I3lRfinfsgMkLALgJmlLQQs9x0NGxh72tH1t0vlvA08scep6ETZNeJxEnSN5rrA aAXLNdcg+HBBkdNtee2srPteI30veL/NJUcsWFUWm1KZMDOR8ePj+vWcRe85RW/MJ4mqpojoZQK N8qQe+XIj9jcYELf/86J0Xe1BPxryW6tksLoHqlBYRH6z4wtN8X8t0lb5fK960yCnhzmcpe3ktN YwOmxCSyVCzWs4oHDXsbyaRGmVBHMaAuseWw== X-Received: by 2002:a17:907:9624:b0:bee:f0d5:1c71 with SMTP id a640c23a62f3a-beef0d51fa7mr3432866b.42.1780326180287; Mon, 01 Jun 2026 08:03:00 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bec1642a049sm189607466b.61.2026.06.01.08.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:02:59 -0700 (PDT) From: Nikolay Kulikov To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nikolay Kulikov Subject: [PATCH 0/2] staging: rtl8723bs: remove unreachable code in Date: Mon, 1 Jun 2026 18:01:22 +0300 Message-ID: <20260601150253.69930-1-nikolayof23@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series removes an unreachable switch-case branch in the update_beacon() function. This branch doesn't check the value of the 'oui' pointer, which could lead to a NULL dereference. Found with cppcheck: core/rtw_ap.c:1404:27: error: Null pointer dereference: oui [ctunullpointer] if (!memcmp(RTW_WPA_OUI, oui, 4)) ^ core/rtw_ap.c:235:19: note: Calling function update_beacon, 3rd argument is null update_beacon(padapter, WLAN_EID_TIM, NULL, true); ^ core/rtw_ap.c:1472:3: note: Calling function update_bcn_vendor_spec_ie, 2nd argument is null update_bcn_vendor_spec_ie(padapter, oui); ^ core/rtw_ap.c:1404:27: note: Dereferencing argument oui that is null if (!memcmp(RTW_WPA_OUI, oui, 4)) ^ Nikolay Kulikov (2): staging: rtl8723bs: remove unused case from update_beacon() staging: rtl8723bs: remove unused 'oui' parameter from update_beacon() drivers/staging/rtl8723bs/core/rtw_ap.c | 116 +++------------------ drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_recv.c | 4 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +- drivers/staging/rtl8723bs/include/rtw_ap.h | 2 +- 5 files changed, 24 insertions(+), 108 deletions(-) base-commit: 7cb1c5b32a2bfde961fff8d5204526b609bcb30a -- 2.54.0