From: Jakub Kicinski <kuba@kernel.org>
To: Fidan Aliyeva <fidan.aliyeva.ext@ericsson.com>
Cc: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <marek.behun@nic.cz>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Thomas Eckerman <thomas.eckerman.ext@ericsson.com>
Subject: Re: [PATCH net-next v3 2/3] mv88e6xxx: Refactor 6352's serdes functions
Date: Mon, 1 Jun 2026 19:13:51 -0700 [thread overview]
Message-ID: <20260601191351.31e2b09e@kernel.org> (raw)
In-Reply-To: <20260528210310.1365858-3-fidan.aliyeva.ext@ericsson.com>
On Thu, 28 May 2026 23:03:09 +0200 Fidan Aliyeva wrote:
> 1. Replace serdes check by mv88e6352_g2_scratch_port_has_serdes in
> mv88e6352_pcs_init function by mv88e6xxx_serdes_get_lane function making it
> more generic.
> 2. Replace serdes checks in mv88e6352_serdes_get_* functions with
> mv88e6xxx_serdes_get_lane making them more generic.
> 3. Add lane argument to mv88e6352_serdes_read so it can be reused later for
> 6321.
For the future -- if you're making a list in the commit message your
should rethink whether the commit should be split into multiple
individual changes..
next prev parent reply other threads:[~2026-06-02 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 21:03 [PATCH net-next v3 0/3] mv88e6xxx: SERDES on mv88e6321 Fidan Aliyeva
2026-05-28 21:03 ` [PATCH net-next v3 1/3] mv88e6xxx: Add mv88e6352_serdes_get_lane Fidan Aliyeva
2026-05-28 21:26 ` Andrew Lunn
2026-05-28 21:03 ` [PATCH net-next v3 2/3] mv88e6xxx: Refactor 6352's serdes functions Fidan Aliyeva
2026-05-28 21:27 ` Andrew Lunn
2026-06-02 2:13 ` Jakub Kicinski [this message]
2026-05-28 21:03 ` [PATCH net-next v3 3/3] mv88e6xxx: Add SERDES Support for mv88e6321 Fidan Aliyeva
2026-05-28 21:30 ` Andrew Lunn
2026-06-02 2:20 ` [PATCH net-next v3 0/3] mv88e6xxx: SERDES on mv88e6321 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601191351.31e2b09e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidan.aliyeva.ext@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=thomas.eckerman.ext@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.