From: Nathan Chancellor <nathan@kernel.org>
To: Joel Kamminga <contact@jkam.dev>
Cc: a.hindborg@kernel.org, aliceryhl@google.com,
bjorn3_gh@protonmail.com, boqun@kernel.org, dakr@kernel.org,
gary@garyguo.net, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, lossin@kernel.org, nsc@kernel.org,
ojeda@kernel.org, rust-for-linux@vger.kernel.org,
tmgross@umich.edu
Subject: Re: [PATCH v3] kbuild: rust: make `*.long-type-*.txt` a target for cleanup
Date: Mon, 1 Jun 2026 12:23:05 -0700 [thread overview]
Message-ID: <20260601192305.GA965997@ax162> (raw)
In-Reply-To: <20260601165042.8450-1-contact@jkam.dev>
On Mon, Jun 01, 2026 at 10:50:42AM -0600, Joel Kamminga wrote:
> On 2026-05-30 12:49, Joel Kamminga wrote:
> > This cleans up files generated by rustc compiler in the case of an
> > error containing an excessively long type name that doesn't fit in
> > a single line. Such types appear relatively frequently so the risk
> > of generating these files certainly exists. These files are purely
> > compiler artifacts and are not created intentionally by the build
> > system. They should be added to the `clean` target to stop from
> > cluttering up the source tree.
> >
> > Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1236
> > Signed-off-by: Joel Kamminga <contact@jkam.dev>
> > ---
>
> CHANGELOG:
>
> Changes since v2 (https://lore.kernel.org/linux-kbuild/20260529205529.75586-1-contact@jkam.dev/):
> - Change commit title to be more imperative and more heavily scoped
> 'kbuild: clean `*.long-type-*.txt` files' -> 'kbuild: rust: make
> `*.long-type-*.txt` a target for cleanup'
Not that I think it is worth resending over but I personally find the
"clean '...' files" title easier to understand than the "make '...' a
target for cleanup".
If Miguel wants to take this via the Rust tree:
Acked-by: Nathan Chancellor <nathan@kernel.org>
Otherwise, I can take it for Kbuild. I don't have a preference and I
doubt there will be a conflict in this area in the next couple of weeks.
> Changes since v1 (https://lore.kernel.org/linux-kbuild/20260529203426.65189-1-contact@jkam.dev/):
> - Replace `Reported-by` tag with a `Suggested-by` and `Link` tag to reference back to the
> related GitHub issue
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-06-01 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 18:49 [PATCH v3] kbuild: rust: make `*.long-type-*.txt` a target for cleanup Joel Kamminga
2026-05-31 6:45 ` Miguel Ojeda
2026-06-01 4:23 ` Joel Kamminga
2026-06-01 5:08 ` Miguel Ojeda
2026-06-01 16:50 ` Joel Kamminga
2026-06-01 19:23 ` Nathan Chancellor [this message]
2026-06-02 7:36 ` Miguel Ojeda
2026-06-02 8:15 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601192305.GA965997@ax162 \
--to=nathan@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=contact@jkam.dev \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.