From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A85621ABAA for ; Mon, 1 Jun 2026 19:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780342306; cv=none; b=TVXxn/UEWc4KGXzOru9E/JNtkUu3osq1jdsgjwx9+fqv7dcmd32ABN1NSpTjEGCVCMRuQ7g/Dzv93f40SWJVpHeISJAoIFWuo7PffDBlmIyWbpIZJkjHU8YazfHopPZAvODIQsT6QaxUku9RURcd33KkIWbkeK2lY9zb8d+8D8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780342306; c=relaxed/simple; bh=FCqbE8LW4pxv0SAy9ptA/GIiuzZpYc63SAEHoFHtt7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brHLU22zYeTT19PKnK7Mx1ZR3W+fDrquEWQqmnfc0/ih02bey+70HwozJ/naSavkybbPlsSte6bHTUVy9eCNo5Jcnb2yWtTIwWMRQe0I7oRim+qmy8uMSrO/eb59VT/bPRYxgMzoLoYBgGlCdvQtNk38zFncVhWYkfjw4ZLlHBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sYdCN2+a; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=/ARNLrQf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sYdCN2+a; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=/ARNLrQf; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sYdCN2+a"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/ARNLrQf"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sYdCN2+a"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="/ARNLrQf" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEB816873A; Mon, 1 Jun 2026 19:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780342266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZPAySz4+h9ifiALG50eehNxAyJDKLuKXB4OFixFifg=; b=sYdCN2+aflZtK73vnt2EOy34mQ0zH0JbV2B6W7iYhyYOvJffJaJqHY2hsu4zp+OmsRAbPd KkDY0uuvSg+vlZ+eGKHgyes0rIiNFi5bhBGj64lJBw/J7rizo4UdHvFDZwnDgj7TMrPJTX rQDea/9OlHbUqje2ss4J3vsGTNHwP00= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780342266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZPAySz4+h9ifiALG50eehNxAyJDKLuKXB4OFixFifg=; b=/ARNLrQfxmMQjzBsS01tQ1oPCoQ2QcBf8kCSkNLIsNE8orOurGOq+w4Y+TRQl1FhrNJPLB kcmG2Poak7kJtbBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780342266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZPAySz4+h9ifiALG50eehNxAyJDKLuKXB4OFixFifg=; b=sYdCN2+aflZtK73vnt2EOy34mQ0zH0JbV2B6W7iYhyYOvJffJaJqHY2hsu4zp+OmsRAbPd KkDY0uuvSg+vlZ+eGKHgyes0rIiNFi5bhBGj64lJBw/J7rizo4UdHvFDZwnDgj7TMrPJTX rQDea/9OlHbUqje2ss4J3vsGTNHwP00= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780342266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZPAySz4+h9ifiALG50eehNxAyJDKLuKXB4OFixFifg=; b=/ARNLrQfxmMQjzBsS01tQ1oPCoQ2QcBf8kCSkNLIsNE8orOurGOq+w4Y+TRQl1FhrNJPLB kcmG2Poak7kJtbBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 81202779A7; Mon, 1 Jun 2026 19:31:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eG/OHPrdHWobLwAAD6G6ig (envelope-from ); Mon, 01 Jun 2026 19:31:06 +0000 From: Fernando Fernandez Mancera To: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org, phil@nwl.cc, fw@strlen.de, pablo@netfilter.org, Fernando Fernandez Mancera Subject: [PATCH 6/9 nf-next] netfilter: tproxy: use DEBUG_NET_WARN_ON_ONCE for protocol fallbacks Date: Mon, 1 Jun 2026 21:30:46 +0200 Message-ID: <20260601193049.8131-7-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260601193049.8131-1-fmancera@suse.de> References: <20260601193049.8131-1-fmancera@suse.de> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: Replace WARN_ON calls with DEBUG_NET_WARN_ON_ONCE in the default switch blocks of nf_tproxy_get_sock_v4 and v6. Unsupported transport protocols are already safely handled by returning a NULL socket pointer. This prevents unnecessary system panics when panic_on_warn=1 is enabled in production systems. Signed-off-by: Fernando Fernandez Mancera --- net/ipv4/netfilter/nf_tproxy_ipv4.c | 2 +- net/ipv6/netfilter/nf_tproxy_ipv6.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/netfilter/nf_tproxy_ipv4.c b/net/ipv4/netfilter/nf_tproxy_ipv4.c index 041c3f37f237..5eab7a2dc8ef 100644 --- a/net/ipv4/netfilter/nf_tproxy_ipv4.c +++ b/net/ipv4/netfilter/nf_tproxy_ipv4.c @@ -137,7 +137,7 @@ nf_tproxy_get_sock_v4(struct net *net, struct sk_buff *skb, } break; default: - WARN_ON(1); + DEBUG_NET_WARN_ON_ONCE(1); sk = NULL; } diff --git a/net/ipv6/netfilter/nf_tproxy_ipv6.c b/net/ipv6/netfilter/nf_tproxy_ipv6.c index b2f59ed9d7cc..12ec36a6be2e 100644 --- a/net/ipv6/netfilter/nf_tproxy_ipv6.c +++ b/net/ipv6/netfilter/nf_tproxy_ipv6.c @@ -136,7 +136,7 @@ nf_tproxy_get_sock_v6(struct net *net, struct sk_buff *skb, int thoff, } break; default: - WARN_ON(1); + DEBUG_NET_WARN_ON_ONCE(1); sk = NULL; } -- 2.54.0