Re: [PATCH bpf-next v1 12/14] selftests/bpf: Verify arena type tags in resolve_btfids test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the required BPF kernel comment style, with text starting on the same line as the opening '/*'.
--

commit 628aab60f23e099095fe093c7589706d10a3df81
Author: Ihor Solodrai <ihor.solodrai@linux.dev>

selftests/bpf: Verify arena type tags in resolve_btfids test

This commit extends test_resolve_btfids() to verify that resolve_btfids
correctly emits the address_space(1) type attribute for kfuncs flagged
with arena attributes.

> diff --git a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c
> index eeda4e3b6a7f6..6449b551fde1b 100644
> --- a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c
> +++ b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c
[ ... ]
> @@ -253,6 +282,36 @@ void test_resolve_btfids(void)
>  						     kfunc_symbols[i].id),
>  				    kfunc_symbols[i].name);
>  
> +	/* Check resolve_btfids wrapped exactly the arena-flagged return/args with
> +	 * the address_space(1) type attribute, and left other pointers/returns
> +	 * untouched.
> +	 */

[Severity: Low]
This isn't a bug, but does this multi-line comment violate the modern BPF
subsystem comment style? The guidelines require the opening '/*' to be on its
own line, with the text starting on the next line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601221805.821394-1-ihor.solodrai@linux.dev?part=12