Re: [PATCH 5/5] xfs: mark struct xfs_imap as __packed

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jun 01, 2026 at 02:43:51PM +0200, Christoph Hellwig wrote:
> This returns 2 bytes of padding at the to struct xfs_inode into which
> this structure is embedded.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/xfs/libxfs/xfs_inode_buf.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.h b/fs/xfs/libxfs/xfs_inode_buf.h
> index 57192adc7744..f3624532b023 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.h
> +++ b/fs/xfs/libxfs/xfs_inode_buf.h
> @@ -16,7 +16,7 @@ struct xfs_dinode;
>  struct xfs_imap {
>  	xfs_agblock_t	im_agbno;	/* starting agbno of inode cluster */
>  	unsigned short	im_boffset;	/* offset in inode cluster in bytes */
> -};
> +} __packed;

Nice and compact now!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  
>  int	xfs_read_icluster(struct xfs_perag *pag, struct xfs_trans *tp,
>  		xfs_agblock_t agbno, struct xfs_buf **bpp);
> -- 
> 2.53.0
> 
>