From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
Nirjhar Roy <nirjhar.roy.lists@gmail.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: cleanup xfs_growfs_compute_deltas
Date: Tue, 2 Jun 2026 07:37:04 +0200 [thread overview]
Message-ID: <20260602053704.GB32429@lst.de> (raw)
In-Reply-To: <20260602044203.GN6078@frogsfrogsfrogs>
On Mon, Jun 01, 2026 at 09:42:03PM -0700, Darrick J. Wong wrote:
> AFAICT the logic is the same before and after, so
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>
> Though I half wonder if that XFS_MAX_AGNUMBER+1 comparison is really
> correct. MAX_AGNUMBER is defined to be ((xfs_agnumber_t)-2) so we're
> checking if an unsigned 32-bit number is greater than 0xFFFFFFFF?
> Which is also NULLAGNUMBER?
Not this this is the count and the number. This also is the only
use of MAX_AGNUMBER in the kernel and xfsprogs has a copy of it
defined in XFS_MAX_AGNUMBER. I'll see if there is a cleaner way
to express this, and the fact that agnumber is now a 32-bit value
might also mess things up a bit.
next prev parent reply other threads:[~2026-06-02 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 11:07 fix dblocks adjustment in growfs Christoph Hellwig
2026-06-01 11:07 ` [PATCH 1/2] xfs: pass back updated nb from xfs_growfs_compute_deltas Christoph Hellwig
2026-06-02 4:36 ` Darrick J. Wong
2026-06-02 5:34 ` Christoph Hellwig
2026-06-01 11:07 ` [PATCH 2/2] xfs: cleanup xfs_growfs_compute_deltas Christoph Hellwig
2026-06-02 4:42 ` Darrick J. Wong
2026-06-02 5:37 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-08 5:01 fix dblocks adjustment in growfs v2 Christoph Hellwig
2026-06-08 5:01 ` [PATCH 2/2] xfs: cleanup xfs_growfs_compute_deltas Christoph Hellwig
2026-06-09 7:52 fix dblocks adjustment in growfs v3 Christoph Hellwig
2026-06-09 7:52 ` [PATCH 2/2] xfs: cleanup xfs_growfs_compute_deltas Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602053704.GB32429@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.