From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDD73C8C5E for ; Tue, 2 Jun 2026 08:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780389539; cv=none; b=rPbyxWY1NCS0Ftoo5NA9vNbruvSunc0baJ9QeLFDGUw1GRyCJDNBoXrMdKWGWyUXge2K09X+BLZ9CJKU0AjnF4QQrcvjxDHnNI/Nk+LHqG9b8+36ny1Lb+DarEDHtW8hJodVt5SweGRRv8xIzBak9+kyf83qvnLLy4qkyBhEJHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780389539; c=relaxed/simple; bh=GJ3A2lVvlGjoFTNy9KY2HX/+oA6eFBJ3qUV3d1dmUF0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Qx/FwJJGSMX6g31kT0QUf2p/Sczw2jwrV87nGxEN1+XqkQRTiIyJLuhP2m9BPvujpYRjDRaY3LmC16MyuQ9Xt7VfdM7JgZYAVYujUAQqjaepH9FL8D6p/rHQ/fjcq09wVGbmtrQ6TVH5yElw8p8F6Y7pETnjXet1ZC/svxSfk1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TNoSIv5v; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TNoSIv5v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E92081F00898; Tue, 2 Jun 2026 08:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780389537; bh=snrZ+Yne5ySmBFquNK6XTiD+YCZe8k5Pqw8/c2nWpzo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=TNoSIv5vJa4FLXzNbGyWkhzRH9wJbiUYujacoc2VgL7M9aJiNakGmpuiBq/CW7cDr p4THnJ7V1GrZ+D9Acuik5VGnrxDgHWAOZrYsz8tQj+gHv1GSBUExygmRdXLWiGq+dn syyaxPVLXe8SwD7+6GPH0VeaOUlHFO1L82ath3PK/Y6BS/nT2efJ8llPL4Kog/VLbI pQQGhYwoR6NpCh2wEZ2Uc9o+Gd5GgMKQf+0jOIcZnF7oetKfOubt8ZvsEDd1PEdlUi TifIAaRAJcplUU/VFeFY/5qtU+7rpRjOUrvo9w/Na9GTWEnGcpoeRdPRewwNAPm/+h snZKYBnoGVdzg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 2/2] phy: add basic support for NXPs TJA1145 CAN transceiver Reply-To: sashiko-reviews@lists.linux.dev To: "Dimitri Fedrau via B4 Relay" Cc: olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260602-tja1145-support-v6-2-0e0ffc8ee63d@liebherr.com> References: <20260602-tja1145-support-v6-2-0e0ffc8ee63d@liebherr.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 02 Jun 2026 08:38:56 +0000 Message-Id: <20260602083856.E92081F00898@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] If setting the CAN operating mode fails during `tja1145_phy_powe= r_on`, the PHY hardware is left in normal operating mode without rolling ba= ck to standby mode. -- commit 4b999361552fc4af356fbf9fbd3b1ca5f2dd59bf Author: Dimitri Fedrau phy: add basic support for NXPs TJA1145 CAN transceiver This commit adds basic driver support for the NXP TJA1145 CAN transceiver. It enables bringing the PHY up or down by switching between normal and standby modes using SPI commands. > diff --git a/drivers/phy/phy-nxp-tja1145.c b/drivers/phy/phy-nxp-tja1145.c > new file mode 100644 > index 0000000000000..1e8bd169743ab > --- /dev/null > +++ b/drivers/phy/phy-nxp-tja1145.c [ ... ] > +static int tja1145_phy_power_on(struct phy *phy) > +{ > + struct regmap *map =3D phy_get_drvdata(phy); > + int ret; > + > + /* > + * Switch operating mode to normal which is the active operating mode. > + * In this mode, the device is fully operational. > + */ > + ret =3D regmap_update_bits(map, TJA1145_MODE_CTRL, TJA1145_MODE_CTRL_MC, > + TJA1145_MODE_CTRL_NORMAL); > + if (ret) > + return ret; > + > + /* > + * Switch to CAN operating mode active where the PHY can transmit and > + * receive data. > + */ > + return regmap_update_bits(map, TJA1145_CAN_CTRL, TJA1145_CAN_CTRL_CMC, > + TJA1145_CAN_CTRL_ACTIVE); > +} [Severity: Medium] If the second regmap_update_bits call fails to set TJA1145_CAN_CTRL, does this leave the hardware in normal mode without reverting to standby? Because tja1145_phy_power_on would return an error here, the PHY framework will not consider the PHY powered on and will not invoke tja1145_phy_power_off later. Could this result in the hardware being permanently left in a higher-power state? Should the driver intercept this error and attempt to roll back TJA1145_MODE_CTRL to TJA1145_MODE_CTRL_STBY before returning? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260602-tja1145-su= pport-v6-0-0e0ffc8ee63d@liebherr.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35DA0C5DF71 for ; Tue, 2 Jun 2026 08:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ny1PXUJ2Fx9uMyZi1Mqj1WNhjJ7sCsnu7aGwyLl4C28=; b=yDsNRNkE0Jq/Gb ux1oItSXTqXdZRvy1RPRNN336Y7dLlIOvuEM+cLTARcVbPuUXjEZd9eZCe8rPG8lO3y4KcQp4TtZh kq30kTQLbJPh01leUpCJs5CchUgNTbDWTqL+mJhbbOK7ixtv5oTy4toMdPiEFmNjhBddhafbtGsI0 O7CYjXfQUVd+d/iR/trTGoD7eul3OUkywNCRL2hA3p7Z4Ppuait2PV7t5lEFwR/ltO4qsrJcfc6iQ Vri5DYNgmVAJXJbl5mz5mPX3KvvmIet6uf23GZjbHffqbCDlbNehe9ESKo3BPaitQYlqvOm1jVyz1 hl78Kg+wTFKwbkdnhfjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUKeK-0000000CaLr-1nTd; Tue, 02 Jun 2026 08:39:00 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUKeI-0000000CaLT-1ykX for linux-phy@lists.infradead.org; Tue, 02 Jun 2026 08:38:58 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 9CD2960018; Tue, 2 Jun 2026 08:38:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E92081F00898; Tue, 2 Jun 2026 08:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780389537; bh=snrZ+Yne5ySmBFquNK6XTiD+YCZe8k5Pqw8/c2nWpzo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=TNoSIv5vJa4FLXzNbGyWkhzRH9wJbiUYujacoc2VgL7M9aJiNakGmpuiBq/CW7cDr p4THnJ7V1GrZ+D9Acuik5VGnrxDgHWAOZrYsz8tQj+gHv1GSBUExygmRdXLWiGq+dn syyaxPVLXe8SwD7+6GPH0VeaOUlHFO1L82ath3PK/Y6BS/nT2efJ8llPL4Kog/VLbI pQQGhYwoR6NpCh2wEZ2Uc9o+Gd5GgMKQf+0jOIcZnF7oetKfOubt8ZvsEDd1PEdlUi TifIAaRAJcplUU/VFeFY/5qtU+7rpRjOUrvo9w/Na9GTWEnGcpoeRdPRewwNAPm/+h snZKYBnoGVdzg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 2/2] phy: add basic support for NXPs TJA1145 CAN transceiver To: "Dimitri Fedrau via B4 Relay" Cc: olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260602-tja1145-support-v6-2-0e0ffc8ee63d@liebherr.com> References: <20260602-tja1145-support-v6-2-0e0ffc8ee63d@liebherr.com> Date: Tue, 02 Jun 2026 08:38:56 +0000 Message-Id: <20260602083856.E92081F00898@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gSWYgc2V0dGluZyB0 aGUgQ0FOIG9wZXJhdGluZyBtb2RlIGZhaWxzIGR1cmluZyBgdGphMTE0NV9waHlfcG93ZXJfb25g LCB0aGUgUEhZIGhhcmR3YXJlIGlzIGxlZnQgaW4gbm9ybWFsIG9wZXJhdGluZyBtb2RlIHdpdGhv dXQgcm9sbGluZyBiYWNrIHRvIHN0YW5kYnkgbW9kZS4KLS0KCmNvbW1pdCA0Yjk5OTM2MTU1MmZj NGFmMzU2ZmJmOWZiZDNiMWNhNWYyZGQ1OWJmCkF1dGhvcjogRGltaXRyaSBGZWRyYXUgPGRpbWl0 cmkuZmVkcmF1QGxpZWJoZXJyLmNvbT4KCnBoeTogYWRkIGJhc2ljIHN1cHBvcnQgZm9yIE5YUHMg VEpBMTE0NSBDQU4gdHJhbnNjZWl2ZXIKClRoaXMgY29tbWl0IGFkZHMgYmFzaWMgZHJpdmVyIHN1 cHBvcnQgZm9yIHRoZSBOWFAgVEpBMTE0NSBDQU4gdHJhbnNjZWl2ZXIuCkl0IGVuYWJsZXMgYnJp bmdpbmcgdGhlIFBIWSB1cCBvciBkb3duIGJ5IHN3aXRjaGluZyBiZXR3ZWVuIG5vcm1hbCBhbmQK c3RhbmRieSBtb2RlcyB1c2luZyBTUEkgY29tbWFuZHMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3BoeS9waHktbnhwLXRqYTExNDUuYyBiL2RyaXZlcnMvcGh5L3BoeS1ueHAtdGphMTE0NS5jCj4g bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi4xZThiZDE2OTc0M2Fi Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvcGh5L3BoeS1ueHAtdGphMTE0NS5jCgpb IC4uLiBdCgo+ICtzdGF0aWMgaW50IHRqYTExNDVfcGh5X3Bvd2VyX29uKHN0cnVjdCBwaHkgKnBo eSkKPiArewo+ICsJc3RydWN0IHJlZ21hcCAqbWFwID0gcGh5X2dldF9kcnZkYXRhKHBoeSk7Cj4g KwlpbnQgcmV0Owo+ICsKPiArCS8qCj4gKwkgKiBTd2l0Y2ggb3BlcmF0aW5nIG1vZGUgdG8gbm9y bWFsIHdoaWNoIGlzIHRoZSBhY3RpdmUgb3BlcmF0aW5nIG1vZGUuCj4gKwkgKiBJbiB0aGlzIG1v ZGUsIHRoZSBkZXZpY2UgaXMgZnVsbHkgb3BlcmF0aW9uYWwuCj4gKwkgKi8KPiArCXJldCA9IHJl Z21hcF91cGRhdGVfYml0cyhtYXAsIFRKQTExNDVfTU9ERV9DVFJMLCBUSkExMTQ1X01PREVfQ1RS TF9NQywKPiArCQkJCSBUSkExMTQ1X01PREVfQ1RSTF9OT1JNQUwpOwo+ICsJaWYgKHJldCkKPiAr CQlyZXR1cm4gcmV0Owo+ICsKPiArCS8qCj4gKwkgKiBTd2l0Y2ggdG8gQ0FOIG9wZXJhdGluZyBt b2RlIGFjdGl2ZSB3aGVyZSB0aGUgUEhZIGNhbiB0cmFuc21pdCBhbmQKPiArCSAqIHJlY2VpdmUg ZGF0YS4KPiArCSAqLwo+ICsJcmV0dXJuIHJlZ21hcF91cGRhdGVfYml0cyhtYXAsIFRKQTExNDVf Q0FOX0NUUkwsIFRKQTExNDVfQ0FOX0NUUkxfQ01DLAo+ICsJCQkJICBUSkExMTQ1X0NBTl9DVFJM X0FDVElWRSk7Cj4gK30KCltTZXZlcml0eTogTWVkaXVtXQpJZiB0aGUgc2Vjb25kIHJlZ21hcF91 cGRhdGVfYml0cyBjYWxsIGZhaWxzIHRvIHNldCBUSkExMTQ1X0NBTl9DVFJMLCBkb2VzCnRoaXMg bGVhdmUgdGhlIGhhcmR3YXJlIGluIG5vcm1hbCBtb2RlIHdpdGhvdXQgcmV2ZXJ0aW5nIHRvIHN0 YW5kYnk/CgpCZWNhdXNlIHRqYTExNDVfcGh5X3Bvd2VyX29uIHdvdWxkIHJldHVybiBhbiBlcnJv ciBoZXJlLCB0aGUgUEhZIGZyYW1ld29yawp3aWxsIG5vdCBjb25zaWRlciB0aGUgUEhZIHBvd2Vy ZWQgb24gYW5kIHdpbGwgbm90IGludm9rZQp0amExMTQ1X3BoeV9wb3dlcl9vZmYgbGF0ZXIuIENv dWxkIHRoaXMgcmVzdWx0IGluIHRoZSBoYXJkd2FyZSBiZWluZwpwZXJtYW5lbnRseSBsZWZ0IGlu IGEgaGlnaGVyLXBvd2VyIHN0YXRlPwoKU2hvdWxkIHRoZSBkcml2ZXIgaW50ZXJjZXB0IHRoaXMg ZXJyb3IgYW5kIGF0dGVtcHQgdG8gcm9sbCBiYWNrClRKQTExNDVfTU9ERV9DVFJMIHRvIFRKQTEx NDVfTU9ERV9DVFJMX1NUQlkgYmVmb3JlIHJldHVybmluZz8KCi0tIApTYXNoaWtvIEFJIHJldmll dyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA2MDItdGphMTE0NS1zdXBw b3J0LXY2LTAtMGUwZmZjOGVlNjNkQGxpZWJoZXJyLmNvbT9wYXJ0PTIKCi0tIApsaW51eC1waHkg bWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=