Re: [net-next v24 1/7] dt-bindings: net: Add MTIP L2 switch description

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema Validation Bypass due to `additionalProperties: true`
--

commit 5d51965bfdbb5587449b5ea451099860ef23a8f0
Author: Lukasz Majewski <lukasz.majewski@mailbox.org>

dt-bindings: net: Add MTIP L2 switch description

This commit introduces the device tree binding for the MTIP L2 switch
found in some NXP SoCs like the imx287. It defines properties for ports,
MDIO, clocks, interrupts, and provides an example configuration.

> diff --git a/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml b/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml

[ ... ]

> +  pinctrl-names: true
> +
> +  ethernet-ports:
> +    type: object
> +    additionalProperties: true

[Severity: Low]
Does setting additionalProperties to true here disable strict schema
validation for the container node?

Allowing additional properties means that undocumented properties and
arbitrary child nodes will pass without error. Should this be set to
unevaluatedProperties: false (or additionalProperties: false) to ensure
that only documented properties are permitted?

> +
> +    patternProperties:
> +      '^ethernet-port@[12]$':
> +        type: object
> +        additionalProperties: true

[Severity: Low]
Can this bypass strict property validation for the individual port nodes?

If validation is disabled here, typos like 'phy-mod' instead of 'phy-mode'
will silently pass the dt_binding_check validation.

> +        properties:
> +          reg:
> +            items:
> +              - enum: [1, 2]
> +            description: MTIP L2 switch port number

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601112437.2216043-1-lukasz.majewski@mailbox.org?part=1