From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA9B3DA7D7 for ; Tue, 2 Jun 2026 11:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780400015; cv=none; b=sjlUqFPu1zt3D9qXvbp4xhYgyHVnsm9ppzg18TRCx9S/3GR7k4Qz49ijf/GMzJhHNk2G2hFMwWV+5Z8WfouiAwhTpMO2cLUGtNZ3pbx8zATSJuSVbag3vImACYXkxqHZJ+D/wke1tXiIDVG99AtsuWgjD7zUlZboLSDnx3ABT3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780400015; c=relaxed/simple; bh=yQeqOaHJaGWk+YRW2xodbahmHNhgxlo0/w3jGZICsWc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JgSaM9kVhS1y0IiTE7ek8eM+e4gzT/wlYc/fK7is5PHFL/CxU/r27HyFFBrpO4ha7Q0pGR1JrRxIeTfWkNVs5PGPRD8bDpyBob4SACRI9TAzIqt+FemdCOsamLnbeWL+MurVuipAXLM7D/t4gbLJ7VbS2HgNmhoJXnFX8TuIwYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xe7GW+lL; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xe7GW+lL" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490b43e2b95so539465e9.0 for ; Tue, 02 Jun 2026 04:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780400010; x=1781004810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=02j8GeA8u5NvaXQGdjmKGOU30h5jH73JVyZTDUDQ5Iw=; b=Xe7GW+lL4l4JH4dOQTYarpxyPI2A8j0wiXwBrNJ8eMXlNDmChKoIIS6LknUAQOkJdp C+RSzvHugdNWcYuyfO8mmzcq041iPHY6HJe8sNN28sPTGkj9CJspmXrWISVheuawhCEY vdD7weBbD0OQsWT+3+ISxNu9IJiDq1hKzIA/N6fgH9z9VF80CkhKGDxrFdDrWL3bJFjf GRPSCnPVQ44Rj7g5t051EvDol8wGhvtWnREEfbKzOYxZmKlys2uQ/3Hoh2t5KCKiK0dL KhDRwJ/n9HxkZ5ViUonh6o734Kc3UvxMQ/Md7Ua2ocZ4pfZTfO7BGVIY0Vu4pWrzFw// UvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780400010; x=1781004810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=02j8GeA8u5NvaXQGdjmKGOU30h5jH73JVyZTDUDQ5Iw=; b=ijQp9NdRk9diyWUOoIHQEOWF7gap0vQUvtNQCuXeCJQe2vSmJvUOVBrc3PXnfrOTsR 4NOhhV0GBkUMG8R/C3POC/oM6jzY3NegFB1mowMlu6R9bpOTVC6lmCHt96oNePkT6LWG uAyKN1srd9pPeNU+cvItvp3ag266YSksOHBmWoCL/twZzUtIX20ES+UgkfmEjpGhDVFM ykQwUUykYLiek/Zd1QxSUPdYHsCsxxiXJx87lTpYD+QSc4uhNxIxTAPV7gGYef9/4U1U u6OMrmDRdksu7qMWVMgxNxNqCo0kHmBitJEXf0l+fHSA8LMVwpIEMp7MhriOcBW9k9/X AmSQ== X-Forwarded-Encrypted: i=1; AFNElJ+Pzv+5S7x1vKCJUpnuXKxW4lNDGqVr8wwQ/0Dl6a2rowfhyYM7lsloG9qzA3wBolbXSKNFZ3J7akg6@vger.kernel.org X-Gm-Message-State: AOJu0Yyr/A0KXGacCXCxDFbjCO6DigzOnCFtPDTV+xMFPMhs20QmBiDH /xdYiNp6JdiFGKZzbKDERoBq9rfyXB54vljBVfopUfLNs/PDb+kVuI2Z X-Gm-Gg: Acq92OHsuBbwl6V8Qk8bjOOPPbKb52iqhuICvNU1CISL3TbnjAKdvvkDwJ9osUxmKcq Ks4WKmFsLBG31cHHGzYsUWdt5Ky2cDZSFlHpnXBXL3pA2optbhaYZU9BhSRaAfnY5LVmTVVjPhv LKAk6H+rehiRqvx43kYfFWSWKyAfupS6Y4YQc/rqkmLkfaKLwjLfPO4S2vLrtE7CLT5ONlnrZ8I a3zOX4mbr8ZBGTQCJ92ZRfsRRebk8fKfHIeoI1hMRCSG3lv3cOx8mKkGxevxOft8OuNAK3WqrRt aU7m3TE6Xa88L7J2bf2yLEZlLTFFL7Amr5RaewOvaTwqvd+sNCVFmul6vyT++yBYFtjtbyD5prT q0ivl2NYQX8T2w4qQJlFEIpcZh5b2p776020Ac+ufbQ3U54d9tha0XOcTiZI4GCnZeTHDZ0D4vs P84O2V1lq/P/j0cgjpiTIQ4RJqDqmYmn0i9RBKMFe+lFxjh6zFk9T/mgRAhiQ08NtigURUNiE= X-Received: by 2002:a05:600c:2d47:b0:490:6869:46c3 with SMTP id 5b1f17b1804b1-490a2961e9dmr177750195e9.30.1780400009734; Tue, 02 Jun 2026 04:33:29 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef354b5bdsm31629370f8f.21.2026.06.02.04.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 04:33:29 -0700 (PDT) Date: Tue, 2 Jun 2026 12:33:27 +0100 From: David Laight To: Erni Sri Satya Vennela Cc: mkalderon@marvell.com, Jason Gunthorpe , Leon Romanovsky , zyjzyj2000@gmail.com, sagi@grimberg.me, mgurtovoy@nvidia.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com, bvanassche@acm.org, kbusch@kernel.org, Jens Axboe , Christoph Hellwig , kch@nvidia.com, smfrench@gmail.com, linkinjeon@kernel.org, metze@samba.org, tom@talpey.com, chuck.lever@oracle.com, jlayton@kernel.org, neil@brown.name, okorniev@redhat.com, Dai.Ngo@oracle.com, trondmy@kernel.org, anna@kernel.org, achender@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kees@kernel.org, andriy.shevchenko@linux.intel.com, ebadger@purestorage.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, Jason Gunthorpe Subject: Re: [PATCH rdma-next v6] RDMA: Change capability fields in ib_device_attr from int to u32 Message-ID: <20260602123327.35aa286a@pumpkin> In-Reply-To: <20260601092534.1764560-1-ernis@linux.microsoft.com> References: <20260601092534.1764560-1-ernis@linux.microsoft.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Jun 2026 02:25:15 -0700 Erni Sri Satya Vennela wrote: > The capability counter fields in struct ib_device_attr are declared > as signed int, but these values are inherently non-negative. Drivers > maintain their cached caps as u32 and assign them directly into these > int fields; if a cap exceeds INT_MAX the implicit narrowing yields a > negative value visible to the IB core. > > Change the signed int capability fields to u32 to match the > underlying nature of the data. Also update consumers across the IB > core, ULPs, NVMe-oF target, RDS, and NFS/RDMA so the new u32 values > are not forced back through signed int or u8 via min()/min_t() or > narrowing local variables. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Erni Sri Satya Vennela > --- ... > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > index 6482ad859bd1..852213365ecd 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > @@ -1731,7 +1731,7 @@ static int create_con(struct rtrs_srv_path *srv_path, > * All receive and all send (each requiring invalidate) > * + 2 for drain and heartbeat > */ > - max_send_wr = min_t(int, wr_limit, > + max_send_wr = min_t(u32, wr_limit, > SERVICE_CON_QUEUE_DEPTH * 2 + 2); That should compile as min(). (The constant is known to be non-negative.) ... > diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c > index e6e2c3f9afdf..fd6923198ec1 100644 > --- a/drivers/nvme/target/rdma.c > +++ b/drivers/nvme/target/rdma.c ... > @@ -1553,8 +1554,8 @@ static int nvmet_rdma_cm_accept(struct rdma_cm_id *cm_id, > > param.rnr_retry_count = 7; > param.flow_control = 1; > - param.initiator_depth = min_t(u8, p->initiator_depth, > - queue->dev->device->attrs.max_qp_init_rd_atom); > + param.initiator_depth = (u8)min_t(u32, p->initiator_depth, > + min_t(u32, U8_MAX, queue->dev->device->attrs.max_qp_init_rd_atom)); I think you've change one of those to min_3(). Nesting min() is a good way to bloat the pre-processor output. You don't need any of the casts. param.initiator_depth = min_3(p->initiator_depth, queue->dev->device->attrs.max_qp_init_rd_atom, U8_MAX); should be fine - if a bit long. There are also (u32)U8_MAX casts lurking - pointless. -- David