From: Stephen Hemminger <stephen@networkplumber.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: David Ahern <dsahern@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2-next] iplink_geneve: Support IFLA_GENEVE_LOCAL and IFLA_GENEVE_LOCAL6.
Date: Tue, 2 Jun 2026 13:02:40 -0700 [thread overview]
Message-ID: <20260602130240.26c03c7e@phoenix.local> (raw)
In-Reply-To: <20260602185711.129769-1-kuniyu@google.com>
On Tue, 2 Jun 2026 18:56:51 +0000
Kuniyuki Iwashima <kuniyu@google.com> wrote:
> + if (tb[IFLA_GENEVE_LOCAL]) {
> + __be32 addr = rta_getattr_u32(tb[IFLA_GENEVE_LOCAL]);
> +
> + print_string(PRINT_ANY,
> + "local",
> + "local %s ",
> + format_host(AF_INET, 4, &addr));
Should use print_color_string(PRINT_ANY, COLOR_INET, ...
> + struct in6_addr addr;
> +
> + memcpy(&addr, RTA_DATA(tb[IFLA_GENEVE_LOCAL6]), sizeof(struct in6_addr));
> + if (!IN6_IS_ADDR_UNSPECIFIED(&addr)) {
> + print_string(PRINT_ANY,
> + "local6",
> + "local %s ",
> + format_host(AF_INET6,
> + sizeof(struct in6_addr),
> + &addr));
And print_color_string(PRINT_ANY, COLOR_INET6, ...
> + }
> + }
next prev parent reply other threads:[~2026-06-02 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 18:56 [PATCH v2 iproute2-next] iplink_geneve: Support IFLA_GENEVE_LOCAL and IFLA_GENEVE_LOCAL6 Kuniyuki Iwashima
2026-06-02 20:02 ` Stephen Hemminger [this message]
2026-06-02 20:07 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602130240.26c03c7e@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.