Re: [PATCH bpf-next v2 4/8] libbpf: Initialize CFLAGS before including Makefile.include

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removal of `override CFLAGS += $(CLANG_CROSS_FLAGS)` breaks Clang cross-compilation when `CFLAGS` is overridden on the command line.
--

commit 6aa5adddfad905f5f29ccfe28312c5a00d2d1082
Author: Leo Yan <leo.yan@arm.com>

libbpf: Initialize CFLAGS before including Makefile.include

This commit reorders CFLAGS initialization to happen before including
Makefile.include so it is not affected by expanded EXTRA_CFLAGS. It also
removes the appending of CLANG_CROSS_FLAGS, citing redundancy with the
include file.

> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index 168140f8e6461..eca584fb061e1 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile

[ ... ]

> @@ -84,7 +85,7 @@ override CFLAGS += -Werror -Wall
>  override CFLAGS += $(INCLUDES)
>  override CFLAGS += -fvisibility=hidden
>  override CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> -override CFLAGS += $(CLANG_CROSS_FLAGS)
> +override CFLAGS += $(EXTRA_CFLAGS)

[Severity: Medium]
Does removing this override directive break Clang cross-compilation when
CFLAGS is overridden on the command line?

While tools/scripts/Makefile.include already appends $(CLANG_CROSS_FLAGS),
it uses a standard assignment. According to GNU Make semantics, standard
assignments are ignored if a variable is overridden via the command line
(e.g., make CFLAGS="-O3").

By removing the override directive here, the build system might fail to
unconditionally append cross-compilation flags (like --target= and
--sysroot=), causing Clang to fall back to compiling for the host
architecture instead of the intended target.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init_bpf_only-v2-0-c76e5250ea1c@arm.com?part=4