All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juasheem Sultan <jdsultan@google.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	 Chaitanya Borah <chaitanya.kumar.borah@intel.com>,
	Gil Dekel <gildekel@google.com>,
	Juasheem Sultan <jdsultan@google.com>
Subject: [PATCH v3] drm/i915/dp: Handle VSC SDP revision 7 in unpack
Date: Tue,  2 Jun 2026 13:54:02 -0700	[thread overview]
Message-ID: <20260602205422.1792007-1-jdsultan@google.com> (raw)
In-Reply-To: <20260601212613.3682640-1-jdsultan@google.com>

VSC SDP revision 7 (Panel Replay + Pixel Encoding/Colorimetry Format)
unpacking is missing in intel_dp_vsc_sdp_unpack(). This causes pipe
state mismatches during state readout because the VSC SDP state is not
properly recovered when Panel Replay is active with colorimetry.

Add the missing case for revision 7 to intel_dp_vsc_sdp_unpack()
so that the state is correctly recovered.

v2: Rebase onto latest upstream
v3: Fix git commit description

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Chaitanya Borah <chaitanya.kumar.borah@intel.com>
Cc: Gil Dekel <gildekel@google.com>
Signed-off-by: Juasheem Sultan <jdsultan@google.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6ef2a0043cda..b8746dab051c 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5343,11 +5343,15 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
 		 *   VSC SDP supporting 3D stereo + Panel Replay.
 		 */
 		return 0;
-	} else if (sdp->sdp_header.HB2 == 0x5 && sdp->sdp_header.HB3 == 0x13) {
+	} else if ((sdp->sdp_header.HB2 == 0x5 || sdp->sdp_header.HB2 == 0x7) &&
+			sdp->sdp_header.HB3 == 0x13) {
 		/*
 		 * - HB2 = 0x5, HB3 = 0x13
 		 *   VSC SDP supporting 3D stereo + PSR2 + Pixel Encoding/Colorimetry
 		 *   Format.
+		 * - HB2 = 0x7, HB3 = 0x13
+		 *   VSC SDP supporting 3D stereo + Panel Replay + Pixel Encoding/Colorimetry
+		 *   Format.
 		 */
 		vsc->pixelformat = (sdp->db[16] >> 4) & 0xf;
 		vsc->colorimetry = sdp->db[16] & 0xf;
-- 
2.54.0.1013.g208068f2d8-goog


  parent reply	other threads:[~2026-06-02 20:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 23:12 [PATCH] drm/i915/dp: Handle VSC SDP revision 7 in unpack Juasheem Sultan
2026-05-01  0:44 ` ✓ i915.CI.BAT: success for " Patchwork
2026-05-01  4:05 ` ✓ i915.CI.Full: " Patchwork
2026-06-01 21:25 ` [PATCH v2] " Juasheem Sultan
2026-06-02 18:56   ` Borah, Chaitanya Kumar
2026-06-02 20:54   ` Juasheem Sultan [this message]
2026-06-03 11:40     ` [PATCH v3] " Borah, Chaitanya Kumar
2026-09-18 19:37       ` Gil Dekel
2026-09-21 13:02         ` Nautiyal, Ankit K
2026-09-21 14:31           ` Gil Dekel
2026-06-01 23:31 ` ✗ i915.CI.BAT: failure for drm/i915/dp: Handle VSC SDP revision 7 in unpack (rev2) Patchwork
2026-06-02 21:04 ` ✓ CI.KUnit: success for drm/i915/dp: Handle VSC SDP revision 7 in unpack Patchwork
2026-06-02 21:49 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-02 23:29 ` ✓ i915.CI.BAT: success for drm/i915/dp: Handle VSC SDP revision 7 in unpack (rev3) Patchwork
2026-06-03  5:48 ` ✓ Xe.CI.FULL: success for drm/i915/dp: Handle VSC SDP revision 7 in unpack Patchwork
2026-06-03 14:24 ` ✗ i915.CI.Full: failure for drm/i915/dp: Handle VSC SDP revision 7 in unpack (rev3) Patchwork
2026-06-09 13:27 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602205422.1792007-1-jdsultan@google.com \
    --to=jdsultan@google.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=gildekel@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.