From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484503890FB for ; Wed, 3 Jun 2026 10:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780483075; cv=none; b=LUbxd2V0/ZTobf0QphUzputuvv0ShykVWZj/YU+yhU49a9znu6UaL1/OV2rX9m3+fgz3TIFyW+ip1FO8g9U9aN6J/3ZBhLh4aPcZX1PFo2IIxEbYft7x1AK8ehv8AFDduSX7/+ZKYd1zfm6S5l/yTocSJpabhoRCoBlftFbMkug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780483075; c=relaxed/simple; bh=Fbv/9lKKnSkBPfU83UaI1A37j/+RMkzy3f41o4KYf1M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ksA8+HZnJF/KN9HscUty38+1i3ZWWhSjejt5uYrKyqUTWi12yJXZxIqT7WQYLqaJMqtJnfURza+3YrmFo3ePeR1GYMjnRfemGg5tkhoDsUYgOx4ZJtu61LgdeIl4Dt8X3VWqBju55dddERPz+r5e5m/6DcmMEJQDMcVnVOJ7HoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZYCgKJUE; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZYCgKJUE" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490ae94a89eso25814195e9.1 for ; Wed, 03 Jun 2026 03:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780483073; x=1781087873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=flbB+vtAmCl+AlxKthsxDThltLLV1RLUrncREFvzu+w=; b=ZYCgKJUEBiHmUvnD2WRe8x8/wJqWnY8Of3rDHXbHv7ePc7K58HD6YquABVRpiZewaK lSWoMWenrrj14zSQ68HX6zzZRFup5BIf1P0I5AXFqNSxwQUSgJCPJeVABP2K11p9ZCbB DW+KkzDmWuMvdTaH33dHuPXv4Z9feS+t6eixofm2JUufG8FPsJrpXktcom/rbqd73rjq gOit2qHSUQx13N638IZc/BlRLZ6J7XEZuC3vBessDy/kBrYtXlukCNv8+8bSRgTI0cVK VjmP1WXVQszZhpTfyde8Jshltime7ZpE5pMxWjkwRdDdeq44I19M0UlWVN0AP/oWEVJH ydWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780483073; x=1781087873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=flbB+vtAmCl+AlxKthsxDThltLLV1RLUrncREFvzu+w=; b=B4xSKTENNEze6sI1XTRRZeUFMF8/xEjE+USDKAy9VAhZwysAmCW6s1rBWqPOkhty+v 56Ax8frjyokYKgjAZ7Vq4bCppa0ffb508bmKc+urdd1xSg/rMKt/Pg2nvaIVFoHfrOsO Fpdte+JbaHVjtBudZJ9SPh4jKoRyB99EX1NRriYcp09+NgA3ZLFYzArHD09Aa7m++6lW 2dD8Bg4ucvTIvj7KY93XCjDWqt1KgC78+2zXgWDk5S4MBcu8luD3uLMI2NEU55I+T7Oq K4lQdDeJ4Pfp0WAZrLiLkpVA4lE/FpFrHAFIDJrNsN8/WFnbYH2G9nME3WB8v9hnwMvB 1i5Q== X-Forwarded-Encrypted: i=1; AFNElJ8crC/wBhQOE4z+DOP2xdeB3QDQNprGSNI1azF9PMHx2/Jh0HJskXDXac9u+sH3LCr+t+RoBcvnpswQkp0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0NLBB4koL3mbzSy4qMAyfBf1Kzy46ngATej3TVhSfsxLgSBOQ SNqDeBscQ2hIKfhhGrc/1i+lE07XVlsjQvjwYxmuMlniYvDhNgfvi7l3 X-Gm-Gg: Acq92OGmxr1yBshSaJLaKwSGi/rUfbk23NsZEldIxIGoDX+1n6WxtwH0XyZ8RHMg/bd oPGkwaGo2MJfvVbIdB+zrj4dwFyDwG05Qw+xYzuwUznhIrQc8f9sXwOjDt4IwbZOo1AEeKsQp56 XNOqQdH0LkEQcpnuVbh94D5KK3ZbBPF4aAb08fqBEKO/yLggG6O1akqhD83+w3hJNkgcS3n6t2h DR5CAoLPMDpphFto7LFdmeHZIum86PQpq9GYvZoSsohB+cmvDXUqShm2F/qipiMZ7tL6XugMh7+ jcISSgUFcdGdzkhneO8vm9MMqYvQ1LRH26tA3ta9hQsM+YhPt1trYOLCpgJ5azfAcnWXXf08G5N tgLgas8thFWzDwSLHvynLCiQ+jFviiuQin1BbDSADzRhtapR7+XDB4P/8S1NzQ28thaNqWA+0T5 T8wVyDOiSwIr3nL8vLKKQ/8rF3fDBWmO/aGO2mzH1kg+n4EmoeTy7DJ+iec00Hnm9zsuq7kws= X-Received: by 2002:a05:600c:8b30:b0:48f:e26a:1744 with SMTP id 5b1f17b1804b1-490b5eb4aeemr44706695e9.9.1780483072394; Wed, 03 Jun 2026 03:37:52 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b61511c4sm56819115e9.1.2026.06.03.03.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 03:37:52 -0700 (PDT) Date: Wed, 3 Jun 2026 11:37:50 +0100 From: David Laight To: Andy Shevchenko Cc: Dmitry Antipov , Petr Mladek , linux-kernel@vger.kernel.org, Andrew Morton , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , rodrigo.alencar@analog.com, dlechner@baylibre.com, jic23@kernel.org Subject: Re: [PATCH v1 1/2] kstrtox: Make _parse_integer() take variadic arguments Message-ID: <20260603113750.71c93100@pumpkin> In-Reply-To: <20260602203706.103449-2-andriy.shevchenko@linux.intel.com> References: <20260602203706.103449-1-andriy.shevchenko@linux.intel.com> <20260602203706.103449-2-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Jun 2026 22:29:46 +0200 Andy Shevchenko wrote: > Instead of having different functions that just use default parameters, > combine those to use variadic arguments, so the user may call it using > the same name. Adding a default final parameter can be done generically: #define one(v) v #define first(v, ...) v #define dflt(d, ...) first(__VA_OPT__(one(__VA_ARGS__) ,) d) int foo(int, int); #define foo(a, ...) foo(a, dflt(42, ## __VA_ARGS__)) See: https://godbolt.org/z/x5aao7reK -- David > > Signed-off-by: Andy Shevchenko > --- > lib/kstrtox.c | 6 ------ > lib/kstrtox.h | 9 ++++++++- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/lib/kstrtox.c b/lib/kstrtox.c > index edc4eb7c1bca..adc03e27e4a2 100644 > --- a/lib/kstrtox.c > +++ b/lib/kstrtox.c > @@ -94,12 +94,6 @@ unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned lon > return rv | overflow; > } > > -noinline > -unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *p) > -{ > - return _parse_integer_limit(s, base, p, INT_MAX); > -} > - > static int _kstrtoull(const char *s, unsigned int base, unsigned long long *res) > { > unsigned long long _res; > diff --git a/lib/kstrtox.h b/lib/kstrtox.h > index 158c400ca865..6c7ca3b67429 100644 > --- a/lib/kstrtox.h > +++ b/lib/kstrtox.h > @@ -2,10 +2,17 @@ > #ifndef _LIB_KSTRTOX_H > #define _LIB_KSTRTOX_H > > +#include > + > #define KSTRTOX_OVERFLOW (1U << 31) > const char *_parse_integer_fixup_radix(const char *s, unsigned int *base); > unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned long long *res, > size_t max_chars); > -unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *res); > + > +#define _parse_integer0(s, base, res, ...) \ > + _parse_integer_limit(s, base, res, INT_MAX); > + > +#define _parse_integer(s, base, res, ...) \ > + CONCATENATE(_parse_integer, COUNT_ARGS(__VA_ARGS__))(s, base, res, __VA_ARGS__) > > #endif