Re: [PATCH v2 2/3] hw/acpi: Fix Terminal Type and Language field order in SPCR table

[Igor Mammedov <imammedo@redhat.com>]

On Fri, 29 May 2026 10:30:59 +0800
Xiang W <wangxiang@iscas.ac.cn> wrote:

> According to the ACPI Serial Port Console Redirection Table (SPCR)
> specification, the field order after Flow Control is:
> 
>  - Terminal Type (offset 62, 1 byte)
>  - Language (offset 63, 1 byte)
> 
> This fixes:
>   - hw/acpi/aml-build.c
> 
> Reference:
> https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/serial-port-console-redirection-table
> 
> Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/aml-build.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 7edc8aed42..2adf2810c3 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -2116,10 +2116,10 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,
>      build_append_int_noprefix(table_data, f->stop_bits, 1);
>      /* Flow Control */
>      build_append_int_noprefix(table_data, f->flow_control, 1);
> -    /* Language */
> -    build_append_int_noprefix(table_data, f->language, 1);
>      /* Terminal Type */
>      build_append_int_noprefix(table_data, f->terminal_type, 1);
> +    /* Language */
> +    build_append_int_noprefix(table_data, f->language, 1);
>      /* PCI Device ID  */
>      build_append_int_noprefix(table_data, f->pci_device_id, 2);
>      /* PCI Vendor ID */