From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB1547884F; Wed, 3 Jun 2026 12:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488751; cv=none; b=IGhL9USf4BaD9wJTCLWh50og97E5IdLnOjoIhS8NTy6uZoXcdV4zvSVPfopYnlDlFWSchq+Zoa/ZNPO9Nrwxv3lPhRsCjVIoPbmGIvw5vr12a1bE8cTHbmowXUTMvIdAQF0LS9ONobaqZEQZk5+CG4+dWSk8xI4Rn02k30GZbVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780488751; c=relaxed/simple; bh=d3EykXjPdTOzofqzcPyCOaTQ0ATiB33JeyMELyx3OOM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fZSLXiLP5VCE1TuBKvtSbDFNk2QKzyAAixmx4s2dVko77z/njNpyLxZ08yByhFyKtyK0aIttg0NM2Tm0+OIfNJIvg+XcdQ/D/9S0+Wwa4VlG9EeMGViThLGHu0Db1WDyBL4KjySzIjVH0k1A/hsIZQ1dQldZ4L4vp+HCm7DJrOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WqS1SiX8; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WqS1SiX8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 205D24E400BF; Wed, 3 Jun 2026 12:12:28 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DFA0C6073E; Wed, 3 Jun 2026 12:12:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 48FB510888413; Wed, 3 Jun 2026 14:11:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780488742; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=48ypl4N/Z9PEOrZi5s882vnkw+L0W6ufixnULaCX8wY=; b=WqS1SiX8JxgfCWjKbfGrN6L6Q3QYEVKtX9eatJz9iVzPqdb59EF2wfORgl6E1oiCCYOL6h 61ETQH6hQR3Buc4PxFXV8xJT2J5xNuIRWeEXwCZRhaxs5XLVqNUthCgehn5gJAgDWr5D+V EDn8WSCnJ0fr/3eDUJx++tiwrZ5WSI35nVYVUdYn3doe/iUdJ7p9DoQU59Ef1MvT6hoBjc 7jEjYscg5qvEtTKsFwWeeKNcZMVVM6zgOvZnXTK6b1ZDBo1eLL0VN631t+RjK9av9NXAVA YYmM055EJj11NnypQXGQ/iJgKGei6RU0g5MfNttmfc+5/XNEQ2JJEvOyMVoU4Q== Date: Wed, 3 Jun 2026 14:11:47 +0200 From: Herve Codina To: Kuninori Morimoto Cc: "Alvin =?UTF-8?B?xaBpcHJhZ2E=?=" , "J.M.B. Downing" , "Martin =?UTF-8?B?UG92acWhZXI=?=" , "Nuno =?UTF-8?B?U8Oh?=" , "Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= (The Capable Hub)" , Alexandre Belloni , Alexandre Torgue , AngeloGioacchino Del Regno , Arnaud Pouliquen , Baojun Xu , Bartosz Golaszewski , Ben Bright , Benson Leung , Biju Das , Binbin Zhou , Bram Vlerick , Charles Keepax , Chen-Yu Tsai , Cheng-Yi Chiang , Claudiu Beznea , Cristian Ciocaltea , Daniel Mack , Dario Binacchi , David Rhodes , Fabio Estevam , Florian Fainelli , Frank Li , Fred Treven , Geert Uytterhoeven , Guenter Roeck , Guoqing Jiang , Haojian Zhuang , HariKrishna Sagala , Heiko Stuebner , Hsieh Hung-En , James Ogletree , Jarkko Nikula , Jaroslav Kysela , Jernej Skrabec , Jerome Brunet , Jihed Chaibi , Jonathan Hunter , Kevin Cernekee , Kevin Hilman , Kevin Lu , Kirill Marinushkin , Kiseok Jo , Krzysztof Kozlowski , Kunihiko Hayashi , Lad Prabhakar , Lars-Peter Clausen , Liam Girdwood , Luca Ceresoli , M R Swami Reddy , Mark Brown , Martin Blumenstingl , Masami Hiramatsu , Matthias Brugger , Max Filippov , Maxime Coquelin , Neil Armstrong , Nicolas Ferre , Nicolas Frattaroli , Nicolin Chen , Oder Chiou , Olivier Moysan , Paul Cercueil , Peter Rosin , Piotr Wojtaszczyk , Qianfeng Rong , Ray Jui , Richard Fitzgerald , Robert Jarzmik , Samuel Holland , Sascha Hauer , Scott Branden , Sen Wang , Sharique Mohammad , Shenghao Ding , Shengjiu Wang , Steven Eckhoff , Support Opensource , Sylwester Nawrocki , Takashi Iwai , Thierry Reding , Tim Bird , Troy Mitchell , Tzung-Bi Shih , Venkata Prasad Potturu , Vijendar Mukunda , Vishwas A Deshpande , Vladimir Zapolskiy , Xiubo Li , Yixun Lan , Zhang Yi , chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sound@vger.kernel.org, spacemit@lists.linux.dev Subject: Re: [PATCH 03/83] ASoC: codecs: idt821034: don't use array if single pattarn Message-ID: <20260603141147.61943cf0@bootlin.com> In-Reply-To: <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> References: <8733zfj5jj.wl-kuninori.morimoto.gx@renesas.com> <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Kuninori, On Tue, 26 May 2026 01:58:59 +0000 Kuninori Morimoto wrote: > Because it is confusable during debugging ASoC FW update, tidyup > auto format style not to use array if single pattern case. > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/codecs/idt821034.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c > index 39bafefa6a186..084090ccef77a 100644 > --- a/sound/soc/codecs/idt821034.c > +++ b/sound/soc/codecs/idt821034.c > @@ -860,18 +860,17 @@ static int idt821034_dai_startup(struct snd_pcm_substream *substream, > return 0; > } > > -static const u64 idt821034_dai_formats[] = { > +static const u64 idt821034_dai_formats = > SND_SOC_POSSIBLE_DAIFMT_DSP_A | > - SND_SOC_POSSIBLE_DAIFMT_DSP_B, > -}; > + SND_SOC_POSSIBLE_DAIFMT_DSP_B; > > static const struct snd_soc_dai_ops idt821034_dai_ops = { > .startup = idt821034_dai_startup, > .hw_params = idt821034_dai_hw_params, > .set_tdm_slot = idt821034_dai_set_tdm_slot, > .set_fmt = idt821034_dai_set_fmt, > - .auto_selectable_formats = idt821034_dai_formats, > - .num_auto_selectable_formats = ARRAY_SIZE(idt821034_dai_formats), > + .auto_selectable_formats = &idt821034_dai_formats, > + .num_auto_selectable_formats = 1, > }; > > static struct snd_soc_dai_driver idt821034_dai_driver = { Same typo in the commit title as in patch 2: s/pattarn/pattern/ Or even s/pattarn/item/ With that fixed, Reviewed-by: Herve Codina Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B8E2CD6E6C for ; Wed, 3 Jun 2026 15:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7y6kQz438wzHOOjPLao5GY3+g8YWeA0z7ufMVH+p3QU=; b=KmLerX0MfabDAo EPCX4hhhYxgsOOhsBBv7nExvFEmXms8JAAseZdy5b9w6nz2pdDZ7BPT009PvINeiyEx2DAanuODab i0sDZQnHXdYU+k3HnFRrJ3mYHx2VSIlyB0Wb0tHkoPmyLJWtAIwDufUv0YmDk6xxTTN0xARZjZCj9 /V4h5aCMuh7AwfU+Ve+mTRlQC+0eOhsTgnM308JcHibhfoGxy1R4ILpZfdda+m/Gp6wrTxwvCAEUr fmEKX4M+wsd/jEveC0Of+ZTbcOeqO6GlvmEqwJwWA8+G3nFfu7mouRr/vj7l/d/zA3Homk7GK9ypj eTvCNe/dwVANpgYnpqLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUnLf-0000000FLzH-0nY0; Wed, 03 Jun 2026 15:17:39 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUkSU-0000000F2YR-26GN for linux-riscv@lists.infradead.org; Wed, 03 Jun 2026 12:12:31 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 195381A0108; Wed, 3 Jun 2026 12:12:28 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DFA0C6073E; Wed, 3 Jun 2026 12:12:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 48FB510888413; Wed, 3 Jun 2026 14:11:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780488742; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=48ypl4N/Z9PEOrZi5s882vnkw+L0W6ufixnULaCX8wY=; b=WqS1SiX8JxgfCWjKbfGrN6L6Q3QYEVKtX9eatJz9iVzPqdb59EF2wfORgl6E1oiCCYOL6h 61ETQH6hQR3Buc4PxFXV8xJT2J5xNuIRWeEXwCZRhaxs5XLVqNUthCgehn5gJAgDWr5D+V EDn8WSCnJ0fr/3eDUJx++tiwrZ5WSI35nVYVUdYn3doe/iUdJ7p9DoQU59Ef1MvT6hoBjc 7jEjYscg5qvEtTKsFwWeeKNcZMVVM6zgOvZnXTK6b1ZDBo1eLL0VN631t+RjK9av9NXAVA YYmM055EJj11NnypQXGQ/iJgKGei6RU0g5MfNttmfc+5/XNEQ2JJEvOyMVoU4Q== Date: Wed, 3 Jun 2026 14:11:47 +0200 From: Herve Codina To: Kuninori Morimoto Subject: Re: [PATCH 03/83] ASoC: codecs: idt821034: don't use array if single pattarn Message-ID: <20260603141147.61943cf0@bootlin.com> In-Reply-To: <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> References: <8733zfj5jj.wl-kuninori.morimoto.gx@renesas.com> <87y0h7hqxo.wl-kuninori.morimoto.gx@renesas.com> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260603_051230_665871_4E5447A0 X-CRM114-Status: GOOD ( 16.90 ) X-Mailman-Approved-At: Wed, 03 Jun 2026 08:17:36 -0700 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Geert Uytterhoeven , Xiubo Li , Peter Rosin , Jaroslav Kysela , Sylwester Nawrocki , Cheng-Yi Chiang , Samuel Holland , Kevin Hilman , Vishwas A Deshpande , Olivier Moysan , Yixun Lan , Martin =?UTF-8?B?UG92acWhZXI=?= , Jihed Chaibi , Baojun Xu , Kirill Marinushkin , Bartosz Golaszewski , Sascha Hauer , linux-sound@vger.kernel.org, Sen Wang , Oder Chiou , Scott Branden , Masami Hiramatsu , Sharique Mohammad , David Rhodes , Jarkko Nikula , Alexandre Belloni , Kunihiko Hayashi , Claudiu Beznea , Max Filippov , M R Swami Reddy , Guenter Roeck , Dario Binacchi , chrome-platform@lists.linux.dev, Thierry Reding , Lars-Peter Clausen , Jonathan Hunter , Vijendar Mukunda , Jerome Brunet , Steven Eckhoff , Charles Keepax , Martin Blumenstingl , Tim Bird , Haojian Zhuang , Zhang Yi , Biju Das , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Kiseok Jo , linux-renesas-soc@vger.kernel.org, Maxime Coquelin , Bram Vlerick , imx@lists.linux.dev, Frank Li , Nuno =?UTF-8?B?U8Oh?= , Kevin Lu , Krzysztof Kozlowski , Fred Treven , Fabio Estevam , Binbin Zhou , Jernej Skrabec , Arnaud Pouliquen , Ray Jui , Vladimir Zapolskiy , Richard Fitzgerald , Mark Brown , Kevin Cernekee , Benson Leung , Support Opensource , Luca Ceresoli , spacemit@lists.linux.dev, Liam Girdwood , Guoqing Jiang , Venkata Prasad Potturu , Alexandre Torgue , Nicolas Ferre , Paul Cercueil , HariKrishna Sagala , linux-riscv@lists.infradead.org, Shengjiu Wang , Florian Fainelli , Robert Jarzmik , "J.M.B. Downing" , Nicolas Frattaroli , Hsieh Hung-En , Piotr Wojtaszczyk , Lad Prabhakar , Shenghao Ding , Nicolin Chen , "Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= \(The Capable Hub\)" , Tzung-Bi Shih , Matthias Brugger , Qianfeng Rong , AngeloGioacchino Del Regno , James Ogletree , linux-mips@vger.kernel.org, Takashi Iwai , Troy Mitchell , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Ben Bright , Daniel Mack Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgS3VuaW5vcmksCgpPbiBUdWUsIDI2IE1heSAyMDI2IDAxOjU4OjU5ICswMDAwCkt1bmlub3Jp IE1vcmltb3RvIDxrdW5pbm9yaS5tb3JpbW90by5neEByZW5lc2FzLmNvbT4gd3JvdGU6Cgo+IEJl Y2F1c2UgaXQgaXMgY29uZnVzYWJsZSBkdXJpbmcgZGVidWdnaW5nIEFTb0MgRlcgdXBkYXRlLCB0 aWR5dXAKPiBhdXRvIGZvcm1hdCBzdHlsZSBub3QgdG8gdXNlIGFycmF5IGlmIHNpbmdsZSBwYXR0 ZXJuIGNhc2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogS3VuaW5vcmkgTW9yaW1vdG8gPGt1bmlub3Jp Lm1vcmltb3RvLmd4QHJlbmVzYXMuY29tPgo+IC0tLQo+ICBzb3VuZC9zb2MvY29kZWNzL2lkdDgy MTAzNC5jIHwgOSArKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL2NvZGVjcy9pZHQ4MjEw MzQuYyBiL3NvdW5kL3NvYy9jb2RlY3MvaWR0ODIxMDM0LmMKPiBpbmRleCAzOWJhZmVmYTZhMTg2 Li4wODQwOTBjY2VmNzdhIDEwMDY0NAo+IC0tLSBhL3NvdW5kL3NvYy9jb2RlY3MvaWR0ODIxMDM0 LmMKPiArKysgYi9zb3VuZC9zb2MvY29kZWNzL2lkdDgyMTAzNC5jCj4gQEAgLTg2MCwxOCArODYw LDE3IEBAIHN0YXRpYyBpbnQgaWR0ODIxMDM0X2RhaV9zdGFydHVwKHN0cnVjdCBzbmRfcGNtX3N1 YnN0cmVhbSAqc3Vic3RyZWFtLAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBjb25z dCB1NjQgaWR0ODIxMDM0X2RhaV9mb3JtYXRzW10gPSB7Cj4gK3N0YXRpYyBjb25zdCB1NjQgaWR0 ODIxMDM0X2RhaV9mb3JtYXRzID0KPiAgCVNORF9TT0NfUE9TU0lCTEVfREFJRk1UX0RTUF9BCXwK PiAtCVNORF9TT0NfUE9TU0lCTEVfREFJRk1UX0RTUF9CLAo+IC19Owo+ICsJU05EX1NPQ19QT1NT SUJMRV9EQUlGTVRfRFNQX0I7Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHNuZF9zb2NfZGFp X29wcyBpZHQ4MjEwMzRfZGFpX29wcyA9IHsKPiAgCS5zdGFydHVwICAgICAgPSBpZHQ4MjEwMzRf ZGFpX3N0YXJ0dXAsCj4gIAkuaHdfcGFyYW1zICAgID0gaWR0ODIxMDM0X2RhaV9od19wYXJhbXMs Cj4gIAkuc2V0X3RkbV9zbG90ID0gaWR0ODIxMDM0X2RhaV9zZXRfdGRtX3Nsb3QsCj4gIAkuc2V0 X2ZtdCAgICAgID0gaWR0ODIxMDM0X2RhaV9zZXRfZm10LAo+IC0JLmF1dG9fc2VsZWN0YWJsZV9m b3JtYXRzICAgICA9IGlkdDgyMTAzNF9kYWlfZm9ybWF0cywKPiAtCS5udW1fYXV0b19zZWxlY3Rh YmxlX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKGlkdDgyMTAzNF9kYWlfZm9ybWF0cyksCj4gKwkuYXV0 b19zZWxlY3RhYmxlX2Zvcm1hdHMgICAgID0gJmlkdDgyMTAzNF9kYWlfZm9ybWF0cywKPiArCS5u dW1fYXV0b19zZWxlY3RhYmxlX2Zvcm1hdHMgPSAxLAo+ICB9Owo+ICAKPiAgc3RhdGljIHN0cnVj dCBzbmRfc29jX2RhaV9kcml2ZXIgaWR0ODIxMDM0X2RhaV9kcml2ZXIgPSB7CgpTYW1lIHR5cG8g aW4gdGhlIGNvbW1pdCB0aXRsZSBhcyBpbiBwYXRjaCAyOgpzL3BhdHRhcm4vcGF0dGVybi8KCk9y IGV2ZW4Kcy9wYXR0YXJuL2l0ZW0vCgpXaXRoIHRoYXQgZml4ZWQsCgpSZXZpZXdlZC1ieTogSGVy dmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+CgpCZXN0IHJlZ2FyZHMsCkhlcnbD qQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt cmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=