Re: [PATCH 1/5] dt-bindings: display: msm: qcm2290: Add Shikra MDSS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing 'allOf' conditional block update for new compatible string `qcom,shikra-dsi-ctrl`.
--

commit b5545b2692efb6a451931fc9c3057819063bbe07
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>

dt-bindings: display: msm: qcm2290: Add Shikra MDSS

This commit introduces the Shikra MDSS and DSI hardware device tree bindings.
It adds the qcom,shikra-mdss, qcom,shikra-dpu, and qcom,shikra-dsi-ctrl
compatible strings to existing binding files, sharing the hardware definitions
used by the QCM2290 and related displays.

> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index dbc0613e427ed..a2f3e91104af3 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -33,6 +33,7 @@ properties:
>                - qcom,sdm660-dsi-ctrl
>                - qcom,sdm670-dsi-ctrl
>                - qcom,sdm845-dsi-ctrl
> +              - qcom,shikra-dsi-ctrl

[Severity: Medium]
Is it a regression that qcom,shikra-dsi-ctrl was omitted from the allOf
if-then conditional block further down in this file?

Since Shikra shares the 6-clock requirement ('byte', 'byte_intf', 'pixel',
'core', 'iface', 'bus') with related platforms like SM6115, it seems it
should be included in the allOf block that enforces this:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,milos-dsi-ctrl
              - qcom,msm8998-dsi-ctrl
              ...
              - qcom,sm6115-dsi-ctrl

Without updating that block, won't dt_binding_check fall back to loose
top-level constraints and silently permit invalid Shikra device trees to pass
validation?

>                - qcom,sm6115-dsi-ctrl
>                - qcom,sm6125-dsi-ctrl
>                - qcom,sm6150-dsi-ctrl

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com?part=1