From: Jason Gunthorpe <jgg@nvidia.com>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>,
Allen Hubbe <allen.hubbe@amd.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Bernard Metzler <bernard.metzler@linux.dev>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Bryan Tan <bryan-bt.tan@broadcom.com>,
Cheng Xu <chengyou@linux.alibaba.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Kai Shen <kaishen@linux.alibaba.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
Krzysztof Czurylo <krzysztof.czurylo@intel.com>,
Leon Romanovsky <leon@kernel.org>,
linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org,
Long Li <longli@microsoft.com>,
Michal Kalderon <mkalderon@marvell.com>,
Nelson Escobar <neescoba@cisco.com>,
Satish Kharat <satishkh@cisco.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Chengchang Tang <tangchengchang@huawei.com>,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Vishnu Dasa <vishnu.dasa@broadcom.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: Leon Romanovsky <leonro@nvidia.com>, patches@lists.linux.dev
Subject: Re: [PATCH 0/2] Remove stack ib_udata's
Date: Wed, 3 Jun 2026 15:16:52 -0300 [thread overview]
Message-ID: <20260603181652.GC1568873@nvidia.com> (raw)
In-Reply-To: <0-v1-922fa8e828ba+f7-ib_udata_stack_jgg@nvidia.com>
On Tue, May 26, 2026 at 01:15:04PM -0300, Jason Gunthorpe wrote:
> Sashiko pointed out these are dangerous, and the create_qp() one is in
> fact a bug. The query_device is just ugly old code.
>
> Remove the stack ib_udata's from both places.
>
> Jason Gunthorpe (2):
> RDMA/core: Don't make a dummy ib_udata on the stack in create_qp
> RDMA: Update the query_device() op
>
> drivers/infiniband/core/core_priv.h | 2 +-
> drivers/infiniband/core/device.c | 3 +--
> drivers/infiniband/core/ib_core_uverbs.c | 12 +++++++++++
> drivers/infiniband/core/rdma_core.h | 7 +++++++
> drivers/infiniband/core/uverbs_cmd.c | 14 +------------
> drivers/infiniband/core/uverbs_std_types_qp.c | 3 +--
> drivers/infiniband/core/verbs.c | 20 ++++++++++---------
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ++++-
> drivers/infiniband/hw/cxgb4/provider.c | 8 +++++---
> drivers/infiniband/hw/erdma/erdma_verbs.c | 9 +++++++--
> drivers/infiniband/hw/hns/hns_roce_main.c | 7 ++++++-
> drivers/infiniband/hw/ionic/ionic_ibdev.c | 7 ++++++-
> drivers/infiniband/hw/irdma/verbs.c | 8 +++++---
> drivers/infiniband/hw/mana/main.c | 7 ++++++-
> drivers/infiniband/hw/mlx4/main.c | 13 ++++++------
> drivers/infiniband/hw/mthca/mthca_provider.c | 13 +++++++-----
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 8 +++++---
> drivers/infiniband/hw/qedr/verbs.c | 7 ++++++-
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 +++++---
> .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 8 +++++---
> drivers/infiniband/sw/rdmavt/vt.c | 9 ++++++---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 14 ++++---------
> drivers/infiniband/sw/siw/siw_verbs.c | 8 +++++---
> 23 files changed, 124 insertions(+), 76 deletions(-)
Applied to for-next
Jason
prev parent reply other threads:[~2026-06-03 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:15 [PATCH 0/2] Remove stack ib_udata's Jason Gunthorpe
2026-05-26 16:15 ` [PATCH 1/2] RDMA/core: Don't make a dummy ib_udata on the stack in create_qp Jason Gunthorpe
2026-05-26 16:15 ` [PATCH 2/2] RDMA: Update the query_device() op Jason Gunthorpe
2026-06-03 18:16 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603181652.GC1568873@nvidia.com \
--to=jgg@nvidia.com \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bernard.metzler@linux.dev \
--cc=bharat@chelsio.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=chengyou@linux.alibaba.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=huangjunxian6@hisilicon.com \
--cc=kaishen@linux.alibaba.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kotaranov@microsoft.com \
--cc=krzysztof.czurylo@intel.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mkalderon@marvell.com \
--cc=neescoba@cisco.com \
--cc=patches@lists.linux.dev \
--cc=satishkh@cisco.com \
--cc=selvin.xavier@broadcom.com \
--cc=tangchengchang@huawei.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=vishnu.dasa@broadcom.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.