From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Jinseob Kim <kimjinseob88@gmail.com>,
Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Sanjay Chitroda" <sanjayembeddedse@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
sashiko-bot@kernel.org, "Jonathan Cameron" <jic23@kernel.org>
Subject: [PATCH v2] iio: buffer: Ensure bounce buffer used for unaligned case is zeroed.
Date: Thu, 4 Jun 2026 09:43:07 +0100 [thread overview]
Message-ID: <20260604084307.640053-1-jic23@kernel.org> (raw)
iio_push_to_buffers_with_ts_unaligned() leaks uninitialized heap memory
to userspace if the data passed in is not a multiple of 8 bytes and the
timestamp is enabled. Use memset() to zero it after resizing.
Fixes: 95ec3fdf2b79 ("iio: core: Introduce iio_push_to_buffers_with_ts_unaligned()")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20260529121005.1470-1-kimjinseob88%40gmail.com
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
v2: Zero the new buffer not the old one (which might not exist)
Drop bonus Reported-by:
---
drivers/iio/industrialio-buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 5c3df993bea2..157b0415091a 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -2445,6 +2445,7 @@ int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
indio_dev->scan_bytes, GFP_KERNEL);
if (!bb)
return -ENOMEM;
+ memset(bb, 0, indio_dev->scan_bytes);
iio_dev_opaque->bounce_buffer = bb;
iio_dev_opaque->bounce_buffer_size = indio_dev->scan_bytes;
}
--
2.54.0
next reply other threads:[~2026-06-04 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 8:43 Jonathan Cameron [this message]
2026-06-04 9:10 ` [PATCH v2] iio: buffer: Ensure bounce buffer used for unaligned case is zeroed Andy Shevchenko
2026-06-05 13:50 ` Jonathan Cameron
2026-06-05 19:18 ` Andy Shevchenko
2026-06-08 20:00 ` Nuno Sá
2026-06-14 19:52 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2026-08-03 1:22 Jonathan Cameron
2026-08-03 9:05 ` Nuno Sá
2026-08-03 9:26 ` Joshua Crofts
2026-08-04 23:54 ` Jonathan Cameron
2026-08-11 10:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604084307.640053-1-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=kimjinseob88@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sanjayembeddedse@gmail.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.