From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7FA313535 for ; Thu, 4 Jun 2026 08:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561414; cv=none; b=YvOblf0krWdvlPBnuNTI4RlN9OWJaCX4G2OR01ZKr1PdnhCq075Lo4qOK7M/LJJX3xoM1FFkHhLGyLpSgY4s3CLgwsR2ortoA9QKaIKAKHCeH/zFH1XjxHYCnQ6adK6W+AFp380FLoGU+gSZp7nn5DiQTRiu4xgNYPow+IMF7qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561414; c=relaxed/simple; bh=0+C1c3Wo9Fs6LX+LNzLGw+NcaC5oeEpH4XHjqyjpNR8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C/DpqCEVIR35859BlvKL6yu2bOSDDpORmTrgWJ7eOrD9H3XlfF11Ggvwx/bkvuGqvSPboBQ9/zVj5z4OJnKxClBJQuR2aRagTolzjo2U4BesZPaQMOw61iwrpYUNhydmHGCLxVfZY4138L+iDHRiUx3PlGCDn8eUewUTXlnr4XI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pnZKwERy; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnZKwERy" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-46015dc517aso329521f8f.2 for ; Thu, 04 Jun 2026 01:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780561411; x=1781166211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Rtnm8l2Pp8aAo0A3sYMjECQK0hYSfvrQqJGyO3CzQMo=; b=pnZKwERygWZU/47LvEkWQxBsdx2jA55YR09NLJKOvsS/bdeiT3qfkhW98Oe2jQVFuU fwURPTNVv1PxvXooowMxPLi7w3b687YB39IO9a2Foli7N33NGc04H9eM4MOpjtX7zPbC 9o9YHHvkF1S8lFVlXK7OtRp5yMSh8xrVWIJ43HkS54oPVm+gNhUA5+6xjxcfMBLxvYPI 5uZBaWdXI6mWQRHfULQI6+3vODd5io1HzKrxonfZerJslhji9HzWHcbl9OCBNKYnE1vW BYMXQfYyzw6/UX8haUo95TNXpdFZlVJv9GYBE43oSfXOz0ZUQfBHMl5DpHC/d8C7MDJR +Nfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780561411; x=1781166211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rtnm8l2Pp8aAo0A3sYMjECQK0hYSfvrQqJGyO3CzQMo=; b=khyNa3kIl7gMA9YZFdXHgulVMVQPJq5fzSV37Q4KL9ipSaLhIr7JEEO4z2CYd2Ze55 2m4KJaWOuX4XWrYkYK8uL6WN9AmgTdMz1UpL8K3wfKWyYNHHc2CY0gj3OmghdDB2+iVr LarNvN8GYPeTG/WAsOaZXDaH5olwS4bKWo4sWSHXitfu0ZutPSdYA1hheAXZDTp5IXRH tAZU6fMgoWK88ndWZLkA31IoiweIouiJpRZ0kaqFVRilHuEhnN75NR5e6eoW/Wsqn7Rm diZn8fpfUWKb1kLR3LcjVHLKPzJMk5kb0YfwtDGLPDEXU9iTxUlcaE+p7qVi95so+ZaD 1Alg== X-Gm-Message-State: AOJu0YyIJL02WVCKgHpH+/iVeLT5WnDJBEKUVvU1dlcBZh4K9rxzM/ok FEuqZdJjj+aWc0WM3x2QtNabWeoO2n4ZU6oAbKuSpW/Dh347Qjs4JeTS X-Gm-Gg: Acq92OGWxzBrivtSv0cNp5m/OArgGo+DFfpzo9Vcyt+DLAXP784l061Rvaj+uG8zfis ldeOmqS9AEMxfU6O66TE+NQkZVJfHejQ5BThbvz4tv+N24Jwt09KX3d5cQDN4NJr1pJzu2Yomtj ftvtJSCxDld3yttx17OqAZ3QIvoq9AerqQMktmRg2pY88fzlOXi2fGJUOgmnNMgykwwXOfayIRI hjRGpiOxFoTJ9qSi6yAgpMvuACWQSo/8pgU5NfX24soZPu5r5x7WfUqk4/GJbew18mApwW0MsKZ IFCpGsLOwVZGSMdMpkMrstf283M8fkAUxd0TcRqPA5M1LGCcET4oAuF3v8sSpCRdaUwQ7+34pbN VaDPe5g68VMmaCRTiU2kT6p0W2MHc29EEhQQlwPTMVrUh5ChS0Iu0ms5eemuCQxHTSV6/0z3lbr qmtTTQhuTVlB1Q8MYlVNNfXjy3xhKUgBc6pAe69Mq9HkD0y618Gei5dPBylkpJ+uZexu6Edm4= X-Received: by 2002:a05:6000:46da:b0:44b:7ec9:2d76 with SMTP id ffacd0b85a97d-4602178b784mr7481335f8f.7.1780561411114; Thu, 04 Jun 2026 01:23:31 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dcbdsm5201755f8f.7.2026.06.04.01.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 01:23:30 -0700 (PDT) Date: Thu, 4 Jun 2026 09:23:29 +0100 From: David Laight To: Thomas Gleixner Cc: LKML , Mathieu Desnoyers , =?UTF-8?B?QW5kcsOp?= Almeida , Sebastian Andrzej Siewior , Carlos O'Donell , Peter Zijlstra , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" , Uros Bizjak , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Mark Brown , Richard Weinberger Subject: Re: [patch V5 08/16] futex: Cleanup UAPI defines Message-ID: <20260604092329.173f31f1@pumpkin> In-Reply-To: <20260602090535.615600933@kernel.org> References: <20260602084648.462672743@kernel.org> <20260602090535.615600933@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 02 Jun 2026 11:09:51 +0200 Thomas Gleixner wrote: > Make the operand defines tabular for readability sake. Too late for now, but putting FUTEX_PRIVATE_FLAG first would help even more. -- David >=20 > Signed-off-by: Thomas Gleixner > Reviewed-by: Andr=C3=A9 Almeida > --- > V2: New patch > --- > include/uapi/linux/futex.h | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) >=20 > --- a/include/uapi/linux/futex.h > +++ b/include/uapi/linux/futex.h > @@ -25,23 +25,22 @@ > =20 > #define FUTEX_PRIVATE_FLAG 128 > #define FUTEX_CLOCK_REALTIME 256 > -#define FUTEX_CMD_MASK ~(FUTEX_PRIVATE_FLAG | FUTEX_CLOCK_REALTIME) > =20 > -#define FUTEX_WAIT_PRIVATE (FUTEX_WAIT | FUTEX_PRIVATE_FLAG) > -#define FUTEX_WAKE_PRIVATE (FUTEX_WAKE | FUTEX_PRIVATE_FLAG) > -#define FUTEX_REQUEUE_PRIVATE (FUTEX_REQUEUE | FUTEX_PRIVATE_FLAG) > -#define FUTEX_CMP_REQUEUE_PRIVATE (FUTEX_CMP_REQUEUE | FUTEX_PRIVATE_FLA= G) > -#define FUTEX_WAKE_OP_PRIVATE (FUTEX_WAKE_OP | FUTEX_PRIVATE_FLAG) > -#define FUTEX_LOCK_PI_PRIVATE (FUTEX_LOCK_PI | FUTEX_PRIVATE_FLAG) > -#define FUTEX_LOCK_PI2_PRIVATE (FUTEX_LOCK_PI2 | FUTEX_PRIVATE_FLAG) > -#define FUTEX_UNLOCK_PI_PRIVATE (FUTEX_UNLOCK_PI | FUTEX_PRIVATE_FLAG) > -#define FUTEX_TRYLOCK_PI_PRIVATE (FUTEX_TRYLOCK_PI | FUTEX_PRIVATE_FLAG) > +#define FUTEX_CMD_MASK ~(FUTEX_PRIVATE_FLAG | FUTEX_CLOCK_REALTIME) > + > +#define FUTEX_WAIT_PRIVATE (FUTEX_WAIT | FUTEX_PRIVATE_FLAG) > +#define FUTEX_WAKE_PRIVATE (FUTEX_WAKE | FUTEX_PRIVATE_FLAG) > +#define FUTEX_REQUEUE_PRIVATE (FUTEX_REQUEUE | FUTEX_PRIVATE_FLAG) > +#define FUTEX_CMP_REQUEUE_PRIVATE (FUTEX_CMP_REQUEUE | FUTEX_PRIVATE_FLA= G) > +#define FUTEX_WAKE_OP_PRIVATE (FUTEX_WAKE_OP | FUTEX_PRIVATE_FLAG) > +#define FUTEX_LOCK_PI_PRIVATE (FUTEX_LOCK_PI | FUTEX_PRIVATE_FLAG) > +#define FUTEX_LOCK_PI2_PRIVATE (FUTEX_LOCK_PI2 | FUTEX_PRIVATE_FLAG) > +#define FUTEX_UNLOCK_PI_PRIVATE (FUTEX_UNLOCK_PI | FUTEX_PRIVATE_FLAG) > +#define FUTEX_TRYLOCK_PI_PRIVATE (FUTEX_TRYLOCK_PI | FUTEX_PRIVATE_FLAG) > #define FUTEX_WAIT_BITSET_PRIVATE (FUTEX_WAIT_BITSET | FUTEX_PRIVATE_FLA= G) > #define FUTEX_WAKE_BITSET_PRIVATE (FUTEX_WAKE_BITSET | FUTEX_PRIVATE_FLA= G) > -#define FUTEX_WAIT_REQUEUE_PI_PRIVATE (FUTEX_WAIT_REQUEUE_PI | \ > - FUTEX_PRIVATE_FLAG) > -#define FUTEX_CMP_REQUEUE_PI_PRIVATE (FUTEX_CMP_REQUEUE_PI | \ > - FUTEX_PRIVATE_FLAG) > +#define FUTEX_WAIT_REQUEUE_PI_PRIVATE (FUTEX_WAIT_REQUEUE_PI | FUTEX_PRI= VATE_FLAG) > +#define FUTEX_CMP_REQUEUE_PI_PRIVATE (FUTEX_CMP_REQUEUE_PI | FUTEX_PRIVA= TE_FLAG) > =20 > /* > * Flags for futex2 syscalls. >=20 >=20