From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A91E92F7EF8 for ; Thu, 4 Jun 2026 10:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780568186; cv=none; b=dLoRGZhcDkRjXilnMUYxZeT/ugLZcch0qu030u+4jdsLhOI4Yluf1eUudF/KnoWhjUBbOTWXmAPn/zIa0ih1bLliXw4Z3FgVq01iuZmvMI4m35FTOrZSdozjCPl340gZ0/Am4ZJHt9M6PI/oUhOna8t6L4RW26p2qZ/qeONt/c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780568186; c=relaxed/simple; bh=ZaT+/7I10sjNAE33VAam3Fr1U5ow7W6JonB5Vz+sqe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=alC2v2sS6WKLjuh3plCAPmVp59m/Essd2mC/RQjzN1LJ3ezpGxQpnnJ22hv2PfI4/toGjvo1ALVZ4ukblwnoG8v+XUhxQZW9MdgQ6cNd7B8iqByn3qc+BOrD4OoLLobqVUTSaVl+unfuf9BxsfYX8PXs4B4EJxhHCWCgTVsKvoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=JEz06TGL; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="JEz06TGL" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490a76757e5so3695115e9.2 for ; Thu, 04 Jun 2026 03:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780568182; x=1781172982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=myNFao4QCXHlYEfG8LUTprsTeobP90lLd7U+QggG78M=; b=JEz06TGLZQGOwAGLzpwKbJ591Jy+7v+Tu7jyB76l88nHsjoWFW4VxHvSC83Qxdw2Yl xRt7qWf0cOJAEUiKFsXfRAoFrtVWN2a91BylDDv1V0ybz/MWA8IJsWWCKQlAIVWzJs33 aCwWlCw97ehlvCKwwOO+1QNX2GnQjsxggTjV/rjg+srK4FtaBKG3UBSPkX4ZqlmQkCBx B1xovjDJ0uN6xcniMpZxyzvOf22NxtbQCUbwVKpeII6dwVEzOOErOLMWvtCg+Ag/IDZH lfLPAixSiTtWlclDcppAkKGmKjc7odSRjiN/qPIVVDa0whE69GEXbJQy6dLZxXYlDnfm J/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780568182; x=1781172982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=myNFao4QCXHlYEfG8LUTprsTeobP90lLd7U+QggG78M=; b=S6nRCQL0/5voaFFgUsJ4iArD6KiO/vHz+qE8LF4Yar2vaCdfjstkeRSoOJcydnB+BN JXINlN4ESX7A8ftm9BG9OMiKzf5VF4zOwK5r6iwCW9mMvayGsw84Sd0qB2KE0VQ/GEKo ZW9UNA4EnJTWDEkyOZGSB/iJV58X7GiAAW795Oa24vDOqO+xXvZJqRG8HsR1qIPTKrvD FIGHOE4Gsjv1Vdh5wz/GpTgQEP95kHBGTV77W67+THHG0eH3qwn9fkIvU9+FGNK2Ek6b C+8mBCAXM+U2c/6OoNz6gBG0FZZCnN2Fc1vVXk6dPQV+Y29cZ8m99ByyZQWEbLvhdTyU wb6w== X-Forwarded-Encrypted: i=1; AFNElJ8jcNjyMCyvUlgaNwO7QO5LmqzO3PCZj0JGeA9XaF7BPemRNxsWWIa16srSqnYM4fw4gxbWA/Qz8qRF7KA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0TN6yqXW0Ts1fjwxHsGVMDfbO8umW+noD/7pmpcl1QYBvhqXo 0IGFKo9EnDtvs6OlIdExfz1u0MluBgBxHVeHVJFPOYygeYdcCsHeYVjXn2mSTE8t/FA= X-Gm-Gg: Acq92OH8ioy2/H+C2JtzB2DVE/0FGhTkdKv7cxgPWi1Ua+rvAmnukUmsvIDsxxmO4I0 G9AKd689981XSR5izK3MTmNasOAH7J8awdo3aqy2Fcqn9npLK32XhA4JXodUyUFwEcRvScywLNh imvUxvNFp1wEe3qlseygv18wHckm7DUguo+qUqh4UFgtEydYQ7v1YX34qNQT1qoSy9HTrbQ6HuD dwvKi7z/vI8nwVZYchAjLwVPXVElyPcsQADjudt8IzbZyf/6AMVVl8wbIJIQ1bCjr8cIydLufOu DYCsiM0HAqXBrLZ7Yr2lHuc9ZJI+xWo0DWT8AhHuzABk8d3UfZ00l0Nwz0VqgvHv+0U2IghzVF6 Ncr2IPyM6TWHv1jGvOOtNyby2rPUqjwEFMvn0KgJfCUMjg75mJWpfJgAGbB8cbovGbfMQE1DlzL CH91VXvXstd3W7CHsIKzTxJaO3uuXVoFVCGM9TxKWpwyI2Mtc= X-Received: by 2002:a05:600c:354a:b0:48a:5301:bb5c with SMTP id 5b1f17b1804b1-490b5fe0e41mr118251255e9.16.1780568181917; Thu, 04 Jun 2026 03:16:21 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3fd663sm67054775e9.10.2026.06.04.03.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 03:16:21 -0700 (PDT) From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , Chris Down , Naveen Kumar Chaudhary , linux-kernel@vger.kernel.org, Petr Mladek , Sashiko Subject: [PATCH v4 06/11] console/braille: Lock console->setup() call during the registration Date: Thu, 4 Jun 2026 12:14:53 +0200 Message-ID: <20260604101459.393162-7-pmladek@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260604101459.393162-1-pmladek@suse.com> References: <20260604101459.393162-1-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In braille_register_console(), the console->setup() callback must be called while holding the console_lock. This prevents a race condition with a possible active boot console that might be using the same hardware registers. This applies the same protection to the braille console registration that was introduced for regular console registration in commit 801410b26a0e ("serial: Lock console when calling into driver before registration"). Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260423130015.85175-1-pmladek%40suse.com Assisted-by: Gemini:gemini-3 Signed-off-by: Petr Mladek --- drivers/accessibility/braille/braille_console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c index 7b324329882f..9ed3abffb687 100644 --- a/drivers/accessibility/braille/braille_console.c +++ b/drivers/accessibility/braille/braille_console.c @@ -356,7 +356,9 @@ int braille_register_console(struct console *console, int index, if (braille_co) return -ENODEV; if (console->setup) { + console_lock(); ret = console->setup(console, console_options); + console_unlock(); if (ret != 0) return ret; } -- 2.54.0