From: Rob Herring <robh@kernel.org>
To: John Madieu <john.madieu.xa@bp.renesas.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, geert+renesas@glider.be,
magnus.damm@gmail.com, kuninori.morimoto.gx@renesas.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
john.madieu@gmail.com
Subject: Re: [PATCH] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names list and ports schema
Date: Thu, 4 Jun 2026 09:11:36 -0500 [thread overview]
Message-ID: <20260604141136.GA328529-robh@kernel.org> (raw)
In-Reply-To: <20260603202805.3530046-1-john.madieu.xa@bp.renesas.com>
On Wed, Jun 03, 2026 at 08:28:05PM +0000, John Madieu wrote:
> Express the dvc/src/ssiu dma-names as an items list rather than an
> allOf-wrapped single schema, and drop the now-redundant maxItems. Fix
> the ports container to reference graph.yaml's ports definition instead
> of port-base (a ports container is not itself a port), keeping
> port-base on the port@N children, and constrain each playback/capture
> phandle-array entry to a single phandle.
>
> While at it, drop the unused top-level #address-cells/#size-cells since
> no child node uses a unit address and the ports node provides its own,
> require interrupts/dmas/dma-names on the src sub-nodes to match the
> ssi/ssiu sub-nodes and the driver, pin clocks and resets to their fixed
> counts (47 and 14) to match the clock-names/reset-names lists, and put
> compatible and reg first in the example.
>
> Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> ---
> .../sound/renesas,r9a09g047-sound.yaml | 71 +++++++++++--------
> 1 file changed, 43 insertions(+), 28 deletions(-)
> @@ -143,11 +139,12 @@ properties:
> through the list to find a free channel.
>
> dma-names:
> - maxItems: 5
> - allOf:
> - - items:
> - enum:
> - - tx
> + items:
> + - const: tx
> + - const: tx
> + - const: tx
> + - const: tx
> + - const: tx
All you need is:
maxItems: 5
items:
const: tx
(The schema form (vs. list form) of 'items' applies to all items.)
>
> required:
> - dmas
> @@ -203,12 +200,22 @@ properties:
> falls through the list to find a free channel.
>
> dma-names:
> - maxItems: 10
> - allOf:
> - - items:
> - enum:
> - - tx
> - - rx
> + items:
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
maxItems: 10
items:
enum: [ tx, rx ]
> +
> + required:
> + - interrupts
> + - dmas
> + - dma-names
>
> ssiu:
> type: object
> @@ -229,12 +236,17 @@ properties:
> falls through the list to find a free channel.
>
> dma-names:
> - maxItems: 10
> - allOf:
> - - items:
> - enum:
> - - tx
> - - rx
> + items:
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
> + - enum: [ tx, rx ]
And same here.
Rob
prev parent reply other threads:[~2026-06-04 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 20:28 [PATCH] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names list and ports schema John Madieu
2026-06-03 20:39 ` sashiko-bot
2026-06-04 12:10 ` Geert Uytterhoeven
2026-06-04 13:39 ` John Madieu
2026-06-04 14:11 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604141136.GA328529-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu.xa@bp.renesas.com \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.