Re: [PATCH v13 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig symbol `CRYPTO_DEV_SPACC_HASH` selects a non-existent symbol `CRYPTO_MICHAEL_MIC`.
--

commit 5b42eeec08a6835428f268bf6ab818260b6818d2
Author: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>

crypto: spacc - Add SPAcc Kconfig and Makefile

This commit adds the Makefile and Kconfig definitions for the new dwc_spacc
Security Protocol Accelerator driver.

> diff --git a/drivers/crypto/dwc-spacc/Kconfig b/drivers/crypto/dwc-spacc/Kconfig
> new file mode 100644
> index 0000000000000..f9752e6f664b8
> --- /dev/null
> +++ b/drivers/crypto/dwc-spacc/Kconfig

[ ... ]

> +config CRYPTO_DEV_SPACC_HASH
> +	bool "Enable HASH functionality"
> +	depends on CRYPTO_DEV_SPACC
> +	default y
> +	select CRYPTO_HASH
> +	select CRYPTO_SHA1
> +	select CRYPTO_MD5
> +	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
> +	select CRYPTO_HMAC
> +	select CRYPTO_SM3
> +	select CRYPTO_CMAC
> +	select CRYPTO_MICHAEL_MIC

[Severity: Low]
Does this select a non-existent config symbol? The CRYPTO_MICHAEL_MIC symbol
does not appear to exist in the kernel tree. Referencing a missing symbol in
a select statement can cause silent Kconfig failures.

> +	select CRYPTO_XCBC
> +	select CRYPTO_AES
> +	select CRYPTO_SM4_GENERIC

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604165210.1141842-1-pavitrakumarm@vayavyalabs.com?part=4