All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>, Jordan Walters <jaggyaur@gmail.com>
Subject: Re: [PATCH 6.6.y] Bluetooth: hci_core: Fix UAF in hci_unregister_dev()
Date: Fri,  5 Jun 2026 15:37:29 -0400	[thread overview]
Message-ID: <20260605-stable-reply-0022@kernel.org> (raw)
In-Reply-To: <20260604014809.121934-1-jaggyaur@gmail.com>

> [PATCH 6.6.y] Bluetooth: hci_core: Fix UAF in hci_unregister_dev()

Thanks for the patch, but I can't take this as-is -- a v2 is needed:

1) The "commit ... upstream" line cites a hash that doesn't exist in
   mainline, and there's no upstream commit titled "Fix UAF in
   hci_unregister_dev()".

2) The diff doesn't match that fix: upstream uses disable_work_sync() /
   disable_delayed_work_sync() (guarded by HCI_UNREGISTER), not an added
   cancel_delayed_work_sync() in hci_unregister_dev(). cancel_* doesn't
   prevent re-queue, and hci_unregister_dev() later calls
   hci_dev_close_sync() which can re-touch those timers, so this may not
   actually close the UAF.

-- 
Thanks,
Sasha

      reply	other threads:[~2026-06-05 19:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04  1:48 [PATCH 6.6.y] Bluetooth: hci_core: Fix UAF in hci_unregister_dev() Jordan Walters
2026-06-05 19:37 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605-stable-reply-0022@kernel.org \
    --to=sashal@kernel.org \
    --cc=jaggyaur@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.