Re: [PATCH v11 2/3] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect clock name "hclk" is used instead of "grf", which violates the DT binding schema and prevents the eDP driver from explicitly managing the clock.
--

commit a1adb5c9bb9ba76654d07ba8c6320c7edf51f41b
Author: Damon Ding <damon.ding@rock-chips.com>

arm64: dts: rockchip: Add missing hclk for RK3588 eDP1

This commit adds the required HCLK_VO1 bus clock to the RK3588 eDP1 node.
It intends to manage the clock explicitly instead of relying on implicit
enabling via the GRF phandle reference.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index a2640014ee042..b251bb129cdbf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> @@ -285,8 +285,8 @@ hdmi1_out: port@1 {
>  	edp1: edp@fded0000 {
>  		compatible = "rockchip,rk3588-edp";
>  		reg = <0x0 0xfded0000 0x0 0x1000>;
> -		clocks = <&cru CLK_EDP1_24M>, <&cru PCLK_EDP1>;
> -		clock-names = "dp", "pclk";
> +		clocks = <&cru CLK_EDP1_24M>, <&cru PCLK_EDP1>, <&cru HCLK_VO1>;
> +		clock-names = "dp", "pclk", "hclk";

[Severity: Medium]
Should this clock name be "grf" instead of "hclk"?

According to the device tree binding schema for rockchip,analogix-dp, the
third clock name is expected to be "grf".

The driver looks up this clock using devm_clk_get_optional(dev, "grf"). If
"hclk" is used here, the driver will fail to find it, receive a NULL
pointer, and won't explicitly enable the clock as intended by this patch.

>  		interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH 0>;
>  		phys = <&hdptxphy1>;
>  		phy-names = "dp";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605022305.3058853-1-damon.ding@rock-chips.com?part=2