From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE7A3F5BEF for ; Fri, 5 Jun 2026 10:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780653994; cv=none; b=UwH2lhgUiPZfCuOsKpf0F6zm3z/xH1Pg7hg6NnXGpZWSSIXU3ZSKDqLRVwYnXSyq/iQmwqWYGjlaspihCQdgmQ9yjNSfoCrHmqnA9rbt9h1PoitWRcRpa5OiERqD/UIpyjId+XkBKqs1nvmhwMvL1D+B0cSjdNllkQKCWpOq//Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780653994; c=relaxed/simple; bh=ztAnFFia61pebOka09ezVWOXBaAS2ARNognUTc57RIU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AL1+MdioNI45Wumcd+h2BMHWfteg3iVVT9MtkMmBqlpXnRRYiaAMkkHD/K49r7OYbVCAaWDKLQz5B95ciAiy7rM8hq5EAlrm+T5KZZ937xdzazJk3Axw/t6Q085Nvr+HFWQk8KPqk1MAvtgkcnf4caafZxo89MbZG8r1AJkqwQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iArP3H2Q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GlOgXwoA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iArP3H2Q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GlOgXwoA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780653992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YWmpWJa7c5/U2sLQeNqQjOY16iYx/q2CbxO1cEf/tY=; b=iArP3H2QcuKi764dLDNCls9DnydlyyjZ9/v3ju3ynYYMbNlKEVxrVNlh0w75i6tOWACCf0 LnT1vnuEz1VHvh/Vgf/ohSvHSVjrF/1il1hH9kclD19LNvIpdf8+phJAyUekw24GUafmmu rWdNLwjmNlb0mCl7PpECeKuialQHWn4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-BjHdXCCvNKCKhXWnvPIggw-1; Fri, 05 Jun 2026 06:06:31 -0400 X-MC-Unique: BjHdXCCvNKCKhXWnvPIggw-1 X-Mimecast-MFC-AGG-ID: BjHdXCCvNKCKhXWnvPIggw_1780653990 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490b2f22ea2so17969545e9.1 for ; Fri, 05 Jun 2026 03:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780653989; x=1781258789; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7YWmpWJa7c5/U2sLQeNqQjOY16iYx/q2CbxO1cEf/tY=; b=GlOgXwoAEyynYU6Fa7QZzK/yg8BqLup74BuA7tRaTV6Pt/SybiuZM2mVvPv2dQ3Zjb Weyp71F/isRUhu2hiQluEcgGlez1r9FDtH4veVkn5IkITjtKQrcp4bzwHAxg+JbWjWPj 3WyUmBF+dZZ7muDHLNGiOOwScJV80LXqmuwCNXGOkpRGJu0yITyj9qLj9twGy6hkWx9Q VwcUTB8NX6lLds6oGB64dKN3le/Df2zoNYs1t21kZ0nmnD/5GPHsyMwUC37rYgCJokHe o2kc3ih+5qtmQtZORM39NOPEjwUO0X8CYDnxC9T0wKzgaqXvbc7sU2/VSR5NUldn60FN EYuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780653989; x=1781258789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7YWmpWJa7c5/U2sLQeNqQjOY16iYx/q2CbxO1cEf/tY=; b=hfz/rXWK+p/Z8D2iW9CBuLqSeLEup0FsOwgfp72IQ7ez3KT82CK+V4hhV2o088IRNf wtEpYUktoDGQjnvV4TNk7ZaQYDCsHB5UBVjv6Uq6AcrxDEDdbZT9P1WGpGy8uvWn/SQ5 0HIaN4ezDbNUyg2drV9roZgtsMhIZd0Fld3m+q1NnTqgMeqM4HB6XjQccRLTWVJxKjvN bd5H/2doR7IqRV24bZuaSX/4y0AaeVq1gOsVcMgwR+4HM/tYqu9+GaaK+MMB5T+fhhsl 2GkAj7mHA112HZjQ1whLVU74H7HQzd5EONSCJjJ7BLpyUgvqWbdjspPYpWMMsMAemEhn HDkw== X-Forwarded-Encrypted: i=1; AFNElJ/4VEIRw4gAh/1Oh6yCxKH4VWbXlCL3d6EF+Gd59Ka9O3Rpz27VEVM3HiQYLyrFgE6FCyukFOSdFPLULyM=@vger.kernel.org X-Gm-Message-State: AOJu0YzvLRnvtcyzgUUqhka9ZpkupRpaI/DuGd6+EsRLrWeNME+zj18z khKJ+SfL8Fy+Oq/0c/DfuMGMx9E3BpD7UYKKu1k5KdAgclvR5feJDDW/vqoPwOsdWkESwQEgH20 LJdPRtUvod8LU9F4JrstBHH1/O6+LLaohWyeR+ORLInXURiID4WQjY94kTQCYc5CB1g== X-Gm-Gg: Acq92OFzJ69N+1WJGbsmBmm0hzbkoBCZw5z8jvAWDT123G2yTuyOciiRaqeMGOLDWta s4gz2g+KQd+FyZ1NYV8Xu5QQxv/cycsZ1+1/mdoZ7ztjRNOLeL6felEkyMSYvs8O33YTV+bV+sG TmSWFHQPFlOXWFln1XG9aPPVrG0kuIRhF2fPwtPHQ+gllJEq5hNiMTneGNhuBV6b5OHw39blWmI k+xLpjl7dYbC8ITUOn/bLQSmywydoyrwWPSy7ADk2WD7Om+UerzLirdVajTifpElLvECwQnNtIw 1aO+XIvRGyEgipt0dnSSj9Bd9TsTObM0cHM0RA9fgDvPGS/uDW4Z6/Ys6ChTrZ1s+5zgKM1Mjj9 HTN8Y4bxgbhJb3ZiLrPZTz7/oIKmiTkPusP+O40yg9V4NDavkNJupTSY= X-Received: by 2002:a05:600c:828f:b0:490:b3fe:9732 with SMTP id 5b1f17b1804b1-490c25dd6aamr39020155e9.16.1780653989429; Fri, 05 Jun 2026 03:06:29 -0700 (PDT) X-Received: by 2002:a05:600c:828f:b0:490:b3fe:9732 with SMTP id 5b1f17b1804b1-490c25dd6aamr39019635e9.16.1780653988913; Fri, 05 Jun 2026 03:06:28 -0700 (PDT) Received: from redhat.com (ppp-94-66-118-61.home.otenet.gr. [94.66.118.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d69sm40480039f8f.29.2026.06.05.03.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 03:06:28 -0700 (PDT) Date: Fri, 5 Jun 2026 06:06:25 -0400 From: "Michael S. Tsirkin" To: longlong yan Cc: jasowang@redhat.com, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/virtio: check mmap return value in vringh_test Message-ID: <20260605060404-mutt-send-email-mst@kernel.org> References: <20260605021446.1611-1-yanlonglong@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605021446.1611-1-yanlonglong@kylinos.cn> On Fri, Jun 05, 2026 at 10:14:45AM +0800, longlong yan wrote: > In parallel_test(), the return values of mmap() for both host_map and > guest_map are not checked against MAP_FAILED. If mmap() fails, the > subsequent code will dereference the invalid pointer, leading to a > segmentation fault. > > Add MAP_FAILED checks after both mmap() calls, using err() to report > the error and exit, consistent with the existing error handling style > in this file (e.g., the open() call on line 149). > > Fixes: 1515c5ce26ae("tools/virtio: add vring_test.") > Signed-off-by: longlong yan > --- > tools/virtio/vringh_test.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c > index b9591223437a..8cc5ca6c7cca 100644 > --- a/tools/virtio/vringh_test.c > +++ b/tools/virtio/vringh_test.c > @@ -159,7 +159,12 @@ static int parallel_test(u64 features, > > /* Parent and child use separate addresses, to check our mapping logic! */ > host_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); > + if (host_map == MAP_FAILED) > + err(1, "mmap host_map"); > + trailing whitespace here. > guest_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); > + if (guest_map == MAP_FAILED) > + err(1, "mmap guest_map"); > > pipe_ret = pipe(to_guest); > assert(!pipe_ret); > -- > 2.43.0