Re: [PATCH] hw/virtio: propagate vhost_virtqueue_mask() errors from start path

[Bin Guo <guobin@linux.alibaba.com>]

On Wed, 4 Jun 2026 14:57:41 +0200, Philippe Mathieu-Daudé wrote:
> IIUC the intention behind this TODO is to convert to a function
> returning a boolean and taking Error** as last argument, replacing
> this call with error_setg_errno().
> See in 'Error reporting system loosely patterned after Glib's GError'
> rules in 'qapi/error.h'.

Thanks for the suggestion. I considered changing the signature to
bool + Error **errp, but decided to keep the current int +
error_report() approach. vhost_set_vring_call is unlikely to fail
in practice, so this is defensive programming rather than a regular
error path. Changing the signature would propagate to ~15 call sites
across multiple files for what is a rare edge case, which seems
disproportionate. The patch already resolves the TODO and confines
the change to the start path.