Re: [PATCH] perf scripts: Add configurable sorting option to powerpc-hcalls

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The argument parsing loop in `trace_begin()` will crash with an `IndexError` if `-s` or `--sort` is the last argument provided.
--

commit e3cf27646cdda0e6126f0f6cde0a6fdbb2db8e8c
Author: Shivani Nittor <shivani@linux.ibm.com>

perf scripts: Add configurable sorting option to powerpc-hcalls

This commit adds a runtime-configurable sorting option to the powerpc-hcalls.py
script. It parses sys.argv to allow users to order hypercall statistics by
count or various latency metrics.

> diff --git a/tools/perf/scripts/python/powerpc-hcalls.py b/tools/perf/scripts/python/powerpc-hcalls.py
> index 8b78dc790adb1..df7b83ab0b6e0 100644
> --- a/tools/perf/scripts/python/powerpc-hcalls.py
> +++ b/tools/perf/scripts/python/powerpc-hcalls.py

[ ... ]

> @@ -158,10 +159,42 @@ def hcall_table_lookup(opcode):
>  
>  print_ptrn = '%-28s%10s%10s%10s%10s'
>  

[ ... ]

> +def trace_begin():
> +    global sort_key
> +
> +    i = 1
> +    while i < len(sys.argv):
> +        arg = sys.argv[i]
> +
> +        if arg == '-s' or arg == '--sort':
> +            sort_key = sys.argv[i + 1]

[Severity: Medium]
Does this code risk an IndexError if the script is invoked with -s or --sort
as the very last argument?

If a user fails to provide the actual sort key value at the end of the argument
list, accessing sys.argv[i + 1] will be out of bounds and crash the script.

> +            i += 2
> +            continue
> +
> +        if arg.startswith('--sort='):
> +            sort_key = arg.split('=', 1)[1]
> +
> +        i += 1
> +
> +    print("SORT KEY =", sort_key)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605062717.24982-1-shivani@linux.ibm.com?part=1