From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493EA382286 for ; Fri, 5 Jun 2026 12:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662050; cv=none; b=UOicpEXUDABNtNbud5uy16LO9f4L4CKBdYsKZIWrSQQjAfxPFJ/9jAewVbMhOFnEo/sgS4axbjdxo8Xvfcs5/srBZ/+2QmA5+lk7eWMIgujppZzDrUCQUU8oFJZ7XwW4BfsbYJwfMsRQi8faxoM4X28fqLOovZ9rvWjR04D/Ar4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662050; c=relaxed/simple; bh=lZ7FZtmTEovnVZhym6I+cKVFhm8O/HbQ0QN2bfsjw8c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DHQoX4an9R9uOMIqGyxXldf5kYMEm2peVHClbnGiKBgrRYf2ltdJPYfUL4OrWf6engV2y6CS86giHlQvSgX7tc9LnkNlJtd3ofCqTqHpam+oPLzzXGo1Rdpe3a5JuU9/q/Mgzpw5o5Za7Z2aj3/At+xdFNBj2lyYUo4/+VCQ6qU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JaJVAB12; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaJVAB12" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8423f626a65so775570b3a.2 for ; Fri, 05 Jun 2026 05:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780662048; x=1781266848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=csAKonk0gKIDvDKdblNmpfIrIfjhCZDOh//IaoDPNxo=; b=JaJVAB12B6mycSLszIHn4MtmFmIMKfPect3WiBFw3FhyTdVTHdy6m5baAvEXLfbzFL pjWywbN1ZkmFZO86dlNZXU5LJgHk0ZFwHecj9MWqt22yAD/HkMDVA5DzL7DX8sCNJLFW SX+DbPuMPFmUknAdXysM7aiKer1RQZx2GV+ZK1rJSQ0SHgIhcYNwQBkcIUOTEZ+FFWrC Hw7IbHUANbOxh98wr4vgt6A+TMuqqCBk9+UfQvzALFWMDmJBslPfW4QkYEGozX0QEQoW MDq903vXIsFz9z/96C5sjWEA22ja9RqgEon4qTi7nmBObRt4v1I7iAJkUtXKi52A2MCm mu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780662048; x=1781266848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=csAKonk0gKIDvDKdblNmpfIrIfjhCZDOh//IaoDPNxo=; b=oYQ9KLxJv4pO7C7/1O3L6tWN1i6AtrlUomnRiAsAbMGMCEIBwou7zx3z0mLz63Qr76 JD6iqxo82kA0W6UJ46GQrR75oxPPLK/Ik6bQSPpCiL8wGAC6QNPFixBGZJFgO0Td5V6G Tj/P5FyOEanmOcV02+85Ye++v5sksDAjt6SvhDO61vbjKjS4G4/byrUrVuWD92f5sjtW xVmxfkpIpQDW2i2CHhj1pvB8NBpdGQvaiS37wKELhXoGK9EiQ23WPmDdrHwbfUPWLZr7 KL/oSWRAsW6jaS+yoW6pfAOuiYHOv44ShqnhYu3WaCio69DLyUAV8mkoAJlcs/CXBDCR bbJA== X-Forwarded-Encrypted: i=1; AFNElJ82ZsIbOSpVTIA6VeFNceo3MoBpRQ9yDXvs2VMeR5710Tmz3+SCaNJnmOF+R6FRDgs+21+hx2M6MlhiRpgQkpvgXQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwNSpk0EcikboJvdsars4B0IKKjIjK+QchusT/ivQg3Mf4JXNJC TBRxnjN6XzzIMsugAP4pcbLEHd2Es4/es/G0hICSM6E1pLEgu9Y9KGp9 X-Gm-Gg: Acq92OHGYPWKD+Mm/xFCCq5GYxUDlcQWPAftFFOnsPpi8U0sOd45JgfshSd3ojlFoei y5/lEn2Cw1q8tIWEF3ah00NM+R7Vci5eb9A0s9owpJo8ic4N7B6YBAlEYhjygT6pYGpUVZHjgVL rs9BlCzwp1zNDv5+EJomMTwMZhUqvKH0tCeVRdktEdyVMLAYj0izNgZWvpY1vDHFFIl28LHeRu+ GSdqU3U7QqYRg7jgXOUeb/2Bkcodb1cpX63kDPp95I6dBN1b67MU/3U1YGRBnndw817araol/qC vaCjmFC2Ha32rgKryWRkni21CLEjxtOy6NKl6OgYuTkZlLhicZH3iGvBYOKLr5gCd3ED87lx3Qc kK7DiJzGaxX5c0xFssJqjDJ5P7pwBjS08P8IKhiiFuAy8ii1Xo9kuMNx0JiDzrJ8nrHlm79APO6 b+a8BbZybHh6U0NvUD2RbHFqOa411Aaa9or/y36Sf4pM7yP8DbwldWeVanNHqJR4demfU2 X-Received: by 2002:a05:6a00:b807:b0:842:51af:b3af with SMTP id d2e1a72fcca58-842b0e1c71dmr3279912b3a.3.1780662047867; Fri, 05 Jun 2026 05:20:47 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282221059sm8594381b3a.7.2026.06.05.05.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 05:20:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Kuninori Morimoto , Mark Brown , Geert Uytterhoeven Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v4 07/10] ASoC: renesas: fsi: Use devm_clk_get_optional() for optional clocks Date: Fri, 5 Jun 2026 19:19:51 +0700 Message-ID: <20260605121955.105661-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260605121955.105661-1-phucduc.bui@gmail.com> References: <20260605121955.105661-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The xck, ick and div clocks are optional resources. Use devm_clk_get_optional() instead of devm_clk_get() when acquiring these clocks and switch to dev_err_probe() for error reporting. Suggested-by: Kuninori Morimoto Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 43e6772c06d5..a2d7d17dd2bb 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -990,15 +990,13 @@ static int fsi_clk_init(struct device *dev, clock->own = devm_clk_get(dev, NULL); if (IS_ERR(clock->own)) - return -EINVAL; + return dev_err_probe(dev, PTR_ERR(clock->own), "Can't get fck clock\n"); /* external clock */ if (xck) { - clock->xck = devm_clk_get(dev, is_porta ? "xcka" : "xckb"); - if (IS_ERR(clock->xck)) { - dev_err(dev, "can't get xck clock\n"); - return -EINVAL; - } + clock->xck = devm_clk_get_optional(dev, is_porta ? "xcka" : "xckb"); + if (IS_ERR(clock->xck)) + return dev_err_probe(dev, PTR_ERR(clock->xck), "Can't get xck clock\n"); if (clock->xck == clock->own) { dev_err(dev, "cpu doesn't support xck clock\n"); return -EINVAL; @@ -1007,11 +1005,9 @@ static int fsi_clk_init(struct device *dev, /* FSIACLK/FSIBCLK */ if (ick) { - clock->ick = devm_clk_get(dev, is_porta ? "icka" : "ickb"); - if (IS_ERR(clock->ick)) { - dev_err(dev, "can't get ick clock\n"); - return -EINVAL; - } + clock->ick = devm_clk_get_optional(dev, is_porta ? "icka" : "ickb"); + if (IS_ERR(clock->ick)) + return dev_err_probe(dev, PTR_ERR(clock->ick), "Can't get ick clock\n"); if (clock->ick == clock->own) { dev_err(dev, "cpu doesn't support ick clock\n"); return -EINVAL; @@ -1020,11 +1016,9 @@ static int fsi_clk_init(struct device *dev, /* FSI-DIV */ if (div) { - clock->div = devm_clk_get(dev, is_porta ? "diva" : "divb"); - if (IS_ERR(clock->div)) { - dev_err(dev, "can't get div clock\n"); - return -EINVAL; - } + clock->div = devm_clk_get_optional(dev, is_porta ? "diva" : "divb"); + if (IS_ERR(clock->div)) + return dev_err_probe(dev, PTR_ERR(clock->div), "Can't get div clock\n"); if (clock->div == clock->own) { dev_err(dev, "cpu doesn't support div clock\n"); return -EINVAL; -- 2.43.0