All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Sean Nyekjaer <sean@geanix.com>,
	Sudarshan Shetty <tessolveupstream@gmail.com>,
	andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, jonas@kwiboo.se, jernej.skrabec@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	alexander.stein@ew.tq-group.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Marek Vasut <marex@denx.de>
Subject: Re: [PATCH v4 2/2] drm: bridge: ti-sn65dsi83: Disable video burst mode for LVDS stability
Date: Fri, 5 Jun 2026 19:09:46 +0300	[thread overview]
Message-ID: <20260605160946.GC4350@killaraus.ideasonboard.com> (raw)
In-Reply-To: <DJ17SSAYCT51.28YSD262KHNKK@bootlin.com>

On Fri, Jun 05, 2026 at 05:18:43PM +0200, Luca Ceresoli wrote:
> Hello Sean,
> 
> +Cc Marek, Maxime.
> 
> On Sat May 30, 2026 at 8:51 PM CEST, Sean Nyekjaer wrote:
> > On Wed, May 27, 2026 at 02:27:36PM +0100, Sudarshan Shetty wrote:
> >> The current DSI configuration enables MIPI_DSI_MODE_VIDEO_BURST.
> >> while burst mode is supported by the hardware, its use
> >> depends on continuous clock behavior from the DSI host. In practice,
> >> burst mode may introduce instability depending on the host controller
> >> implementation, as the DSI link may transition to low-power state
> >> between bursts.
> >>
> >> Testing showed improved display stability when using non-burst mode on
> >> affected panels.
> >>
> >> Remove MIPI_DSI_MODE_VIDEO_BURST and use non-burst video mode.
> >>
> >
> > We briefly talked about this at Embedded Recipes
> > I promised to sent a link:
> > https://lore.kernel.org/all/E35054BA-FBE5-4CEE-905C-1F5D20140590@geanix.com/
> 
> Thanks for the discussion at ER and for this follow-up e-mail.
> 
> > When burst mode is enabled, the LVDS clock gets way to high for my
> > panel. I don't know if it's the DSI controller in the STM32MP1 or
> > something not supported on the TI side.
> >
> > We have been running with this fix for 2 years :)
> 
> If I can summarize the situation in the last 4 years:
> 
>  * Several users reported the same trouble
>  * Those users patch their kernel out of tree to disable burst mode as a
>    workaround
>  * According to Marek the correct way to make burst mode work is
>    implementing link negotiation
>  * Nobody is willing to implement link negotiation as of now
> 
> And this leads me to some questions.
> 
>  * Do we want to keep the current situation (everybody beats their head on
>    the wall until they discover disabling burst mode "fixes" their panel,
>    and keep an out of tree patch)?
> 
>  * Assuming the priority is getting a screen working (and not saving power
>    on a black screen), would it make sense to apply this patch, and let
>    people improve in the future by implementing link negotiation?
> 
>    Let's pretend for a moment this is a new driver being developed: would
>    it be OK to have a basic working driver, without some power optimization
>    features which can be added later on? The only valid answer to this
>    question is obviously "yes". Doesn't the same principle apply here? If
>    it doesn't, why?
> 
>  * What is the expected power saving with burst mode?
> 
>    I'm afraid I don't have precise numbers but I measured the total board
>    consumption with or without burst mode (the former with a black screen
>    but backlight enabled) and found no difference: exactly 12.74 W in both
>    cases.
> 
> Thanks for you rpatience in reading this. I hope it helps in finding a
> better solution.

Rephrasing this a bit, is the discussion about dropping support for a
supported feature (burst mode) because users who suffer from the lack of
another feature (link negotiation) are not willing to spend time
implementing it, and would prefer if users of burst mode were forced to
do the work instead ? That doesn't seem very fair to me.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-06-05 16:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 18:51 [PATCH v4 2/2] drm: bridge: ti-sn65dsi83: Disable video burst mode for LVDS stability Sean Nyekjaer
2026-06-05 15:18 ` Luca Ceresoli
2026-06-05 16:09   ` Laurent Pinchart [this message]
2026-06-05 16:56     ` Luca Ceresoli
2026-06-05 17:31       ` Laurent Pinchart
2026-06-08  6:33         ` Sean Nyekjaer
2026-06-08  7:12       ` Maxime Ripard
2026-06-08  6:37     ` Alexander Stein
2026-06-08  7:09     ` Maxime Ripard
2026-06-08  7:14       ` Laurent Pinchart
2026-06-08  8:59         ` Maxime Ripard
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27  8:57 [PATCH v4 0/2] drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Sudarshan Shetty
2026-05-27  8:57 ` [PATCH v4 2/2] drm: bridge: ti-sn65dsi83: Disable video burst mode for LVDS stability Sudarshan Shetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605160946.GC4350@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=sean@geanix.com \
    --cc=simona@ffwll.ch \
    --cc=tessolveupstream@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.