Re: [RFC PATCH v2 03/10] kvm: Prepare core VM structs and helpers for LUO support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `__rcu` annotation on the `kvm->vm_file` field triggers Sparse warnings.
--

commit aba59ce9475ece27b2837967edea8ac0058bfe79
Author: Tarun Sahu <tarunsahu@google.com>

kvm: Prepare core VM structs and helpers for LUO support

This introduces core infrastructure to support VM preservation with LUO.
It refactors VM file creation into a new helper and tracks a weak
reference to the backing file in struct kvm.

> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 4c14aee1fb063..9111a28637aff 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
[ ... ]
> @@ -874,6 +874,18 @@ struct kvm {
>  #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES
>  	/* Protected by slots_lock (for writes) and RCU (for reads) */
>  	struct xarray mem_attr_array;
> +#endif
> +#ifdef CONFIG_LIVEUPDATE_GUEST_MEMFD
> +	/*
> +	 * Weak reference to the VFS file backing this KVM instance. Stored
> +	 * without incrementing the file refcount to prevent a circular lifetime
> +	 * dependency (since file->private_data already pins this struct kvm).
> +	 * Used exclusively to resolve the file pointer back from struct kvm.
> +	 *
> +	 * Written/cleared via rcu_assign_pointer() and read locklessly under
> +	 * RCU (e.g. via get_file_active() to prevent ABA races).
> +	 */
> +	struct file *vm_file;

[Severity: Low]
Since this pointer is meant to be read locklessly under RCU and is updated
using rcu_assign_pointer() in kvm_create_vm_file() and kvm_vm_release(),
should it be declared with the __rcu annotation?

Without the __rcu qualifier, static analysis tools like Sparse will trigger
a "different address spaces" warning during the rcu_assign_pointer() call.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780676742.git.tarunsahu@google.com?part=3