Re: [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The DT binding schema for the embedded GPIO controller lacks required provider properties and constraints.
- [Medium] The schema incorrectly includes PCI bus properties (`device_type = "pci"`, `ranges`, `#address-cells`) on a PCIe endpoint node.
- [Low] The file pattern listed in the new MAINTAINERS entry does not match the actual file added by the commit.
--

commit b83533ab8022940a0adcc430e19c789576b6a45b
Author: Daniel Thompson <daniel@riscstar.com>

dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge

Add devicetree bindings for the Toshiba TC956x family of Ethernet-AVB/TSN
bridges. The TC9564 contains a PCIe switch with an attached embedded PCIe
endpoint implementing two PCIe functions, each with an Ethernet interface
and an embedded GPIO controller.

> diff --git a/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml b/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml
> new file mode 100644
> index 0000000000000..6e7a63dfcf86a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml
> @@ -0,0 +1,120 @@

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - pci1179,0220 # Toshiba TC9564 (a.k.a. Qualcomm QPS615)
> +
> +  gpio:
> +    type: object
> +    description: Embedded GPIO controller
> +    $ref: /schemas/gpio/gpio.yaml#

[Severity: Medium]
When adding a hardware capability like a GPIO controller, should the schema
explicitly list standard properties like gpio-controller and #gpio-cells
in the required list?

Also, would it make sense to enforce a const constraint for #gpio-cells?
Without these requirements, device tree nodes missing the provider properties
might silently pass validation.

[ ... ]

> +allOf:
> +  - $ref: /schemas/pci/pci-device.yaml#
> +  - $ref: /schemas/pci/pci-bus-common.yaml#

[Severity: Medium]
Is it intentional to reference pci-bus-common.yaml# for a PCIe endpoint?

This reference applies bus-specific properties to an endpoint node.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pcie {
> +        #address-cells = <3>;
> +        #size-cells = <2>;
> +
> +        pci@0,0 {
> +            compatible = "pci1179,0220";
> +            reg = <0x50000 0x0 0x0 0x0 0x0>;
> +            #address-cells = <3>;
> +            #size-cells = <2>;
> +            device_type = "pci";
> +            ranges;

[Severity: Medium]
Are device_type = "pci", ranges, and the address translation cell properties
valid on this endpoint node?

The Devicetree specification dictates that device_type = "pci" should strictly
be used on PCI bus nodes like host bridges or PCI-to-PCI bridges.

Additionally, since the gpio and ethernet child nodes do not use reg
properties, the address and size cell sizing here seems unnecessary.

> +
> +            gpio {
> +                  gpio-controller;
> +                  #gpio-cells = <2>;
> +            };

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2aa6ea012c848..f976c9fa9d9c0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27052,6 +27052,12 @@ F:	Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt
>  F:	drivers/media/i2c/tc358743*
>  F:	include/media/i2c/tc358743.h
>  
> +TOSHIBA TC956X/QUALCOMM QPS615 DWMAC ETHERNET DRIVER
> +M:	Alex Elder <elder@kernel.org>
> +M:	Daniel Thompson <danielt@kernel.org>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml

[Severity: Low]
Is there a typo in the filename here?

The commit introduces the file toshiba,tc9564-dwmac.yaml, but the MAINTAINERS
entry lists toshiba,tc956x-dwmac.yaml. This might prevent get_maintainer.pl
from properly matching the new binding file.

> +
>  TOSHIBA WMI HOTKEYS DRIVER
>  M:	Azael Avalos <coproscefalo@gmail.com>
>  L:	platform-driver-x86@vger.kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605010022.968612-1-elder@riscstar.com?part=10