Re: [PATCH bpf-next v3 2/2] selftests/bpf: add tests for PTR_TO_FLOW_KEYS offset bounds

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment violates BPF subsystem style guidelines.
--

commit e1141f4c391173362f83f08e56c2a4d2bb3f8dfe
Author: Nuoqi Gui <gnq25@mails.tsinghua.edu.cn>

selftests/bpf: add tests for PTR_TO_FLOW_KEYS offset bounds

This commit adds verifier tests for pointer arithmetic on a PTR_TO_FLOW_KEYS
register. It verifies that in-bounds offsets are accepted while out-of-bounds
and variable offsets are appropriately rejected.

> diff --git a/tools/testing/selftests/bpf/progs/verifier_flow_keys.c b/tools/testing/selftests/bpf/progs/verifier_flow_keys.c
> new file mode 100644
> index 0000000000000..d780a36a6e9a9
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/verifier_flow_keys.c

[ ... ]

> +	r0 = 0;						\
> +	exit;						\
> +"	:
> +	: __imm_const(flow_keys, offsetof(struct __sk_buff, flow_keys))
> +	: __clobber_all);
> +}
> +
> +/* Equivalent OOB expressed directly in insn->off; this form was always
> + * rejected and is kept to show both forms now share one diagnostic.
> + */

[Severity: Low]
This isn't a bug, but does this multi-line comment follow the BPF subsystem
style guidelines?

The guidelines prefer multi-line comments to have the opening /* on its own
line, with the text starting on the subsequent line.

> +SEC("flow_dissector")
> +__description("flow_keys: OOB via insn->off rejected")
> +__failure __msg("invalid access to flow keys off=4096 size=8")
> +__naked void flow_keys_insn_off_oob(void)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260606-c3-01-v3-v3-0-97c51f592f15@mails.tsinghua.edu.cn?part=2