From: david.laight.linux@gmail.com
To: Kees Cook <kees@kernel.org>,
linux-hardening@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Danilo Krummrich <dakr@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
David Laight <david.laight.linux@gmail.com>
Subject: [PATCH next] driver core: Replace strcpy() with memcpy()
Date: Sat, 6 Jun 2026 21:25:55 +0100 [thread overview]
Message-ID: <20260606202633.5018-1-david.laight.linux@gmail.com> (raw)
From: David Laight <david.laight.linux@gmail.com>
The length of the string is calculated in order to allocate the correct
sized memory block, use the same length to copy in the string.
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
This is one of a group of patches that remove potentially unbounded
strcpy() calls.
They are mostly replaced by strscpy() or, when strlen() has just been
called, with memcpy() (usually including the '\0').
Calls with copy string literals into arrays are left unchanged.
They are safe and easily detected as such.
The changes were made by getting the compiler to detect the calls and
then fixing the code by hand.
Note that all the changes are only compile tested.
Some Makefiles were changed to allow files to contain strcpy().
As well as 'difficult to fix' files, this included 'show' functions
as they really need to use sysfs_emit() or seq_printf().
All the patches are being sent individually to avoid very long cc lists.
Apologies for the terse commit messages and likely unexpected tags.
(There are about 100 patches in total.)
drivers/base/platform.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 75b4698d0e58..63fdfffe1a8c 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -617,10 +617,11 @@ static void platform_device_release(struct device *dev)
struct platform_device *platform_device_alloc(const char *name, int id)
{
struct platform_object *pa;
+ size_t len = strlen(name);
- pa = kzalloc(sizeof(*pa) + strlen(name) + 1, GFP_KERNEL);
+ pa = kzalloc(sizeof(*pa) + len + 1, GFP_KERNEL);
if (pa) {
- strcpy(pa->name, name);
+ memcpy(pa->name, name, len);
pa->pdev.name = pa->name;
pa->pdev.id = id;
device_initialize(&pa->pdev.dev);
--
2.39.5
next reply other threads:[~2026-06-06 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 20:25 david.laight.linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-06 20:25 [PATCH next] driver core: Replace strcpy() with memcpy() david.laight.linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260606202633.5018-1-david.laight.linux@gmail.com \
--to=david.laight.linux@gmail.com \
--cc=arnd@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.