From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E5E3BE632 for ; Sat, 6 Jun 2026 21:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780781039; cv=none; b=chocX8EmG7DpMEzOSHDriC2WbL/ps8vK8rY1xacRH9zBZ8xTlAM9tANHDIdaAUcI7tWps58O7KygwKcNs+1EBSlfUR+ay8/ddst8D+YhJFmi81Dcs4WyazdOECKD56ugtcweS8d6SIpMNjZ/d5zXMVZKYFaEH1QS3p3X3YDGD0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780781039; c=relaxed/simple; bh=3b1UpXnojsbrEus5bqRz6edLLJovJc2g9Gp+HF2j+/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lc7K+4DNgf5w11aZtmajUAbU8oWrAeI4t/xUBc3Nsn7P8KdmU1iTSVlNo8+IGjBzFqbpS9QSetpoYlc21xAA7FsFt3f6X4TJU77ZyWENhD9d6pxt/+0Rt3L+X+ZEl3LmOA7KInuFYmRf/9sAgAVNMp6DupEMSTh6wsiAtE0uR2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vErQyi68; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vErQyi68" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780781036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dan4rE7bYyYB1+gvs3DMamJYBUXq38P5H41J6E7rpl8=; b=vErQyi681188zUjf9NsxFJK48uC3H5srjCJtJKihlOW4oxI1WHH+C6mEpmI4xI7BZY4B2D yq406GN5bPbFLM5yjY2lmGpr7XOD9XiiQsZx6H4a2iWfI6+i6SVhffvbp08ToS+cZPJo+G kndiMtTl7IfuoWmgOnZHWBj7xU4AR8E= From: Thorsten Blum To: David Howells , Marc Dionne Cc: Thorsten Blum , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 2/2] afs: replace goto with direct return in afs_lookup_atsys Date: Sat, 6 Jun 2026 23:23:17 +0200 Message-ID: <20260606212315.21574-5-thorsten.blum@linux.dev> In-Reply-To: <20260606212315.21574-4-thorsten.blum@linux.dev> References: <20260606212315.21574-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=897; i=thorsten.blum@linux.dev; h=from:subject; bh=3b1UpXnojsbrEus5bqRz6edLLJovJc2g9Gp+HF2j+/o=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFkq/Yd3W5cI10p597bGzo/eePDJIZcL8kGceVKJl9uv9 J7duoKto5SFQYyLQVZMkeXBrB8zfEtrKjeZROyEmcPKBDKEgYtTACaitZjhr/RZnl1c8Ve+nkuv bt7u+aihO6tofcLXKq9D38XfzXWd7cLwV+QbL8/rruAgu/yD39k3Cdom7j0c3Bn/9Z2v1vuNvMd 3sAIA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Return ERR_PTR(-ENOMEM) directly and remove the obsolete out_p label. Signed-off-by: Thorsten Blum --- fs/afs/dir.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 080664b67861..bc50f00c0c69 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -906,10 +906,9 @@ static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry) _enter(""); - ret = ERR_PTR(-ENOMEM); p = buf = kmalloc(AFSNAMEMAX, GFP_KERNEL); if (!buf) - goto out_p; + return ERR_PTR(-ENOMEM); if (dentry->d_name.len > 4) { memcpy(p, dentry->d_name.name, dentry->d_name.len - 4); p += dentry->d_name.len - 4; @@ -941,7 +940,6 @@ static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry) out_s: afs_put_sysnames(subs); kfree(buf); -out_p: return ret; }