From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFCA2FE59C; Sun, 7 Jun 2026 10:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780826590; cv=none; b=fx6lFF04jeG0SrptS8VuGyrwHPDPajSP1sc7uPKY1PRYKQVP/z2NkGLFhVOxJ3wp8vl71/T42bqYs21MeP7x7nGcYvHCcRtQlxgYgBSF+pYOjWnSuh3BiKsiu+2I2nxNaPXZQOt8IW0tvOIjpNf7jk6obsy5QY5M/vKdQZTDO9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780826590; c=relaxed/simple; bh=xEFD/s8T1ZRHS/ugZrgjbO+NxMG6sYVmkVdWZS4i1dA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UpY/OEdDEMjgtbmyDVBxqrtaEfvBpi/SjWsrPMlCQl6zdXRis61eS3wDcmVG3dYgThZoTBMINCgk3jopc1U9MkKFee3PbNPKa9MdMO5T84g0lK+bLxSBQ2UF24nl+grY/zuklI6QxGaIU1LxjOaG0/VvWRHYt7r94L7/j+2aARY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fFXum0Ct; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fFXum0Ct" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E9AB1F00893; Sun, 7 Jun 2026 10:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780826589; bh=zI2ytqh+QWTW4fnf7KRN6AJQ/IOG+ftb932UcebkIM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fFXum0CtIRCC1f1M0PY/k5Q/KcvIkFq+H7YKwEAqjrTg7wt7j7XNt/KiiXXM9A7+r XCHPVD1fKIMw9EFlgzImWyrkaiWTW/Yb+2XxXq8V3GBvRwimbC54abJDmxIwWtEANj tgJYDUg3m+fk3ZoLelDN6qWVrble4EwMSjrQ1Iv4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Torokhov , stable Subject: [PATCH 7.0 001/332] Input: usbtouchscreen - clamp NEXIO data_len/x_len to URB buffer size Date: Sun, 7 Jun 2026 11:56:10 +0200 Message-ID: <20260607095728.085450215@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095728.031258202@linuxfoundation.org> References: <20260607095728.031258202@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 2905281cbda52ec9df540113b35b835feb5fafd3 upstream. nexio_read_data() pulls data_len and x_len from a packed __be16 header in the device's interrupt packet and then walks packet->data[0..x_len) and packet->data[x_len..data_len) comparing each byte against a threshold. Both fields are 16-bit on the wire (max 65535). The existing adjustments shave at most 0x100 / 0x80 off, so the loop bound can still reach roughly 0xfeff. The URB transfer buffer for NEXIO is rept_size (1024) bytes from usb_alloc_coherent(), with the first 7 occupied by the packed header — so packet->data[] has 1017 valid bytes. read_data() callbacks are not given urb->actual_length, and nothing else bounds the walk. A device that lies about its length can get a ~64 KiB out-of-bounds read past the coherent DMA allocation. The first index whose byte exceeds NEXIO_THRESHOLD lands in begin_x / begin_y and from there into the reported touch coordinates, so adjacent kernel memory contents leak to userspace as ABS_X / ABS_Y events. Far enough out, the read can also hit an unmapped page and fault. Fix this all by clamping data_len to the buffer's data[] capacity and x_len to data_len. Cc: Dmitry Torokhov Fixes: 5197424cdccc ("Input: usbtouchscreen - add NEXIO (or iNexio) support") Cc: stable Assisted-by: gkh_clanker_t1000 Signed-off-by: Greg Kroah-Hartman Link: https://patch.msgid.link/2026042026-chlorine-epidermis-fd6d@gregkh Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/usbtouchscreen.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -1070,6 +1070,11 @@ static int nexio_read_data(struct usbtou if (x_len > 0xff) x_len -= 0x80; + if (data_len > usbtouch->data_size - sizeof(*packet)) + data_len = usbtouch->data_size - sizeof(*packet); + if (x_len > data_len) + x_len = data_len; + /* send ACK */ ret = usb_submit_urb(priv->ack, GFP_ATOMIC); if (ret)