From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EDD1E98E3; Sun, 7 Jun 2026 10:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827073; cv=none; b=EP2j95l2pESJGLKvDelsqrAqzGnux4V2l3ImQOtEMBjec9+w+33JphHQio+gUfNNvX33S6zTU+mvHwoAm9L5fmD3r0oHr9mjezU661PfNfaFjtMoTjSwHu3YCsM4nmY9RMLIshj31pl/rsTL6Px7lCMXHNLhIqEqtqh5mRJGdgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827073; c=relaxed/simple; bh=dMjstsMYmN95Okc5M/rSGrW+bYBRKTxISdgzW2rS+Vo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=au4rU88x3WPeEFmf5uamDG2lPpt/iZmtdy3PEwMN+ewzk6D9W33XotVilF23Rh8Ne1B3X+0SZbCAFyEhhEQlVhCRDNViq/qSthktHcKKYsnElY93H6wmitcVfki8D2imZ/eG845Z9jGG8H7Rb06ScvBvah+Rg8WIMb+/vSkn1Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mxvu9OK+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mxvu9OK+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C29C51F00893; Sun, 7 Jun 2026 10:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780827072; bh=ppX/yAOZu+BspdI2oNtQfM2ndEQTT43RkA47037bPtQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mxvu9OK+M1dOzKWuL9GyINh95dLTX0VEZ6qbX9WEMQ3xQ9ZvUwFKlRnoLFuNO4gRF 9i8LSN3FfqGvp6FUmnth0uqqD17DG+TuUo3dhVj/P+mdeZjipXsYfaGFk67nqXoh99 uVSdibYH/ARzRkDz2sunHKjf45Kj6+ZrQo7jN704= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jian Zhou , Eric Dumazet , Cong Wang , Jason Xing , Jiayuan Chen , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 028/315] ipv4: free net->ipv4.sysctl_local_reserved_ports after unregister_net_sysctl_table() Date: Sun, 7 Jun 2026 11:56:55 +0200 Message-ID: <20260607095728.538203987@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095727.528828913@linuxfoundation.org> References: <20260607095727.528828913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 87a1e0fe7776da7ab411be332b4be58ac8840d10 ] ipv4_sysctl_exit_net() is currently freeing net->ipv4.sysctl_local_reserved_ports too soon. Only after unregister_net_sysctl_table() we can be sure no threads can possibly use the sysctls, including /proc/sys/net/ipv4/ip_local_reserved_ports. Fixes: 122ff243f5f1 ("ipv4: make ip_local_reserved_ports per netns") Reported-by: Ji'an Zhou Signed-off-by: Eric Dumazet Cc: Cong Wang Reviewed-by: Jason Xing Reviewed-by: Jiayuan Chen Link: https://patch.msgid.link/20260521122147.3584624-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv4/sysctl_net_ipv4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index 0f1dd75dbf37bf..ce9b077343cac2 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -1669,10 +1669,10 @@ static __net_exit void ipv4_sysctl_exit_net(struct net *net) { const struct ctl_table *table; - kfree(net->ipv4.sysctl_local_reserved_ports); table = net->ipv4.ipv4_hdr->ctl_table_arg; unregister_net_sysctl_table(net->ipv4.ipv4_hdr); kfree(table); + kfree(net->ipv4.sysctl_local_reserved_ports); } static __net_initdata struct pernet_operations ipv4_sysctl_ops = { -- 2.53.0