From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 241A031E832; Sun, 7 Jun 2026 10:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827971; cv=none; b=GsZy5jr9XOgLBUprgMLBjxBfPEyO7xq05E7r0BjyuqMoNNs/j2NA94uyoC63HEMTSZl0j6PTj4Mu8tWnv2i2gKfMIVL/2qyiqca6klCRroN5NH1S1j5NU9nS+hI3jJ05qBwVYC18EcXkj53HFyIHBcRxR42PxtiASkvgOm3WKrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780827971; c=relaxed/simple; bh=F3X7Jrrwt7Azoh8KJOStJ2Ve3xfGGToDpXCKCb/8MBo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EySZns/Yk2311Rd5UI7dK28adMs7melqPb0T+4xLceOAmDsg+GooKp95vCIIHGrSk3MUiEg/VjrWY9iv++SCSysdUMYGsP+iUK0ciPr2+OAWSod5jIhuovzqQ4c/aVCar99BxKMdHtifaq6w0/ncW/rxaKcNX6N+4q2MvLv80NQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IKFD60Vq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IKFD60Vq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 312B21F00893; Sun, 7 Jun 2026 10:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780827970; bh=xdBS7pPOgOLme5rfhMm4HwNXjAcrYjFJg35bRb6KoTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IKFD60VqmsMkXqxiliCfvcsRO+59iiVM1R8PrdNS/5wBeYOY01keEj+jtyz2Iu8ZY KtyJ5fWPodKLNIyeObgo7swQtlowPu86tUbpuFm+m7kMjupCQQ56rWcrOMfQFEcibS ZHxJC65BMiZtadXj6OKq/lFTiTDrO897D/0EJZZw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Pratyush Yadav (Google)" , Pasha Tatashin , Jeff Xu , Baolin Wang , Brendan Jackman , Greg Thelen , Hugh Dickins , Kees Cook , "David Hildenbrand (Arm)" , Andrew Morton Subject: [PATCH 7.0 141/332] memfd: deny writeable mappings when implying SEAL_WRITE Date: Sun, 7 Jun 2026 11:58:30 +0200 Message-ID: <20260607095733.273367533@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095728.031258202@linuxfoundation.org> References: <20260607095728.031258202@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pratyush Yadav (Google) commit 3b041514cb6eae45869b020f743c14d983363222 upstream. When SEAL_EXEC is added, SEAL_WRITE is implied to make W^X. But the implied seal is set after the check that makes sure the memfd can not have any writable mappings. This means one can use SEAL_EXEC to apply SEAL_WRITE while having writeable mappings. This breaks the contract that SEAL_WRITE provides and can be used by an attacker to pass a memfd that appears to be write sealed but can still be modified arbitrarily. Fix this by adding the implied seals before the call for mapping_deny_writable() is done. Link: https://lore.kernel.org/20260505133922.797635-1-pratyush@kernel.org Fixes: c4f75bc8bd6b ("mm/memfd: add write seals when apply SEAL_EXEC to executable memfd") Signed-off-by: Pratyush Yadav (Google) Reviewed-by: Pasha Tatashin Acked-by: Jeff Xu Cc: Baolin Wang Cc: Brendan Jackman Cc: Greg Thelen Cc: Hugh Dickins Cc: Kees Cook Cc: "David Hildenbrand (Arm)" Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- mm/memfd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/mm/memfd.c +++ b/mm/memfd.c @@ -283,6 +283,12 @@ static int memfd_add_seals(struct file * goto unlock; } + /* + * SEAL_EXEC implies SEAL_WRITE, making W^X from the start. + */ + if (seals & F_SEAL_EXEC && inode->i_mode & 0111) + seals |= F_SEAL_SHRINK|F_SEAL_GROW|F_SEAL_WRITE|F_SEAL_FUTURE_WRITE; + if ((seals & F_SEAL_WRITE) && !(*file_seals & F_SEAL_WRITE)) { error = mapping_deny_writable(file->f_mapping); if (error) @@ -295,12 +301,6 @@ static int memfd_add_seals(struct file * } } - /* - * SEAL_EXEC implies SEAL_WRITE, making W^X from the start. - */ - if (seals & F_SEAL_EXEC && inode->i_mode & 0111) - seals |= F_SEAL_SHRINK|F_SEAL_GROW|F_SEAL_WRITE|F_SEAL_FUTURE_WRITE; - *file_seals |= seals; error = 0;