From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF27B2D3A69; Sun, 7 Jun 2026 10:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780828625; cv=none; b=rXrCmQjQgTN/0rqiJ+X7qSGqy2whCR8EPb/vt1KvLHkTHEriWFuJONTkuC0o+nBAq0rY3FFlh9Cq+jkPxKty0dlbPOMvkHzRaLo2KkRgst/RGZetPD/ZY2/3rQ52MaUPm+m6tO6iGGQx4w6tOxT29hNkS3mayIlncHqKIHff7c4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780828625; c=relaxed/simple; bh=f183WmconoyKUzKyKKyn/u63HYSomnSGPpU/9VOAK9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k4Dt7J6o+0DkPqXMxG0iqAkKRI8/Vz99P//p974Y5VxOkOUANy593NJtQkaBV4xF5KFgnHAI6R1/H51HquSVfh+Qs1Fmek6OFB/DnbMcI4D3zhxnEYpq9n/H71HP0p0vh8pgbem2jdo3HZHjiFrV9SdqtPws5yYw9dzR7SmAe+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=loVxkqy/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="loVxkqy/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E83541F00893; Sun, 7 Jun 2026 10:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780828624; bh=oPXyqYgUeHpReow34xMzZ890PqBGWsUGRH4F5p85rO8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=loVxkqy/MmEBeU7jTeeM6uaxIigNCqSmGVTJBrIl2OH4iG3w4u/6vhaFlubU1rVaQ ppNOTx9OYmS3UwpjzxmgDUAnZHFr4F+MVy68d70PwEAC7dYCRE+wTb+WGvm7aHPiHI ++l4ZdpAQJUuJXG8RxlckbN3CUwcP8PpVLKqQ+Yw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko , Felix Gu , Andy Shevchenko , =?UTF-8?q?Nuno=20S=C3=A1?= , Maxwell Doose , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 7.0 198/332] iio: buffer: hw-consumer: fix use-after-free in error path Date: Sun, 7 Jun 2026 11:59:27 +0200 Message-ID: <20260607095735.326321470@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095728.031258202@linuxfoundation.org> References: <20260607095728.031258202@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu commit 6f5ed4f2c7c83f33344e0ba179f72a12e5dad4a4 upstream. In the err_put_buffers cleanup path of iio_hw_consumer_alloc(), the code was using list_for_each_entry() to iterate through buffers while calling iio_buffer_put() which can free the current buffer if refcount drops to 0. The list_for_each_entry() loop macro then evaluates buf->head.next to continue iteration, accessing the freed buffer. Fix this by using list_for_each_entry_safe(). Fixes: 48b66f8f936f ("iio: Add hardware consumer buffer support") Reported-by: sashiko Closes: https://sashiko.dev/#/patchset/20260427-iio_buf-v1-1-2bbdac844647%40gmail.com Signed-off-by: Felix Gu Reviewed-by: Andy Shevchenko Reviewed-by: Nuno Sá Reviewed-by: Maxwell Doose Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/buffer/industrialio-hw-consumer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/iio/buffer/industrialio-hw-consumer.c +++ b/drivers/iio/buffer/industrialio-hw-consumer.c @@ -82,7 +82,7 @@ static struct hw_consumer_buffer *iio_hw */ struct iio_hw_consumer *iio_hw_consumer_alloc(struct device *dev) { - struct hw_consumer_buffer *buf; + struct hw_consumer_buffer *buf, *tmp; struct iio_hw_consumer *hwc; struct iio_channel *chan; int ret; @@ -113,7 +113,7 @@ struct iio_hw_consumer *iio_hw_consumer_ return hwc; err_put_buffers: - list_for_each_entry(buf, &hwc->buffers, head) + list_for_each_entry_safe(buf, tmp, &hwc->buffers, head) iio_buffer_put(&buf->buffer); iio_channel_release_all(hwc->channels); err_free_hwc: