From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0187F2D8378; Sun, 7 Jun 2026 10:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829329; cv=none; b=eulE/NaVGR8by07cfKZhW1Vd28LpRqQgTLeO6srbidFVsoYNNiT9mi4lAHbNgi0UKzrLKkm0uecGdaxrfBvFpidHWpXCZzlVgidnpeCOY86yjElBSp/a+4pTiKr8Qom6vpRna8nAHWl/w9dwBj/RbYOI3/TPbyXAizGxmUCn0kU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829329; c=relaxed/simple; bh=wtenPZQ1kqNaNrsqlFTVz+7idTxJMgp9zzJJsb453KY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WXCQ0qaNBY8ObTKLa8/zXltLdzu+qqP32cJYskhOy439taZ15hkt3/KFZf4TfK5mOHKHguibLqxA4yz3i1Vour3dy/Tk9yRDWX7SfOgiiTr028hNy6peNX4KQJDK9bdyhu1eo67q08p+MwVEEFgRLYiil1g5TS4MIIt/WrXgtCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BQ35mQuX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BQ35mQuX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 165581F00893; Sun, 7 Jun 2026 10:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780829328; bh=ZbrBInn07OVLSGOF6qd8ITI+G6CKVsg0UFBTDSKg7Cg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BQ35mQuXhsQwG2fTyQnec9pJYyTvM+e4FclqNij0NZnzw5qioMtx92vsHv0MhfM0n /5eKKzJi1DFrXdYHOFxyjJ0WbJDCudz2Iln/bhYJ9/cAWlvoNTzRQDkyAgB1bqoGdv 9ePKjvWVzI3lqtzmu75Zg0Ed3GMXQOFk0iEP+Grg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Cen , Johan Hovold Subject: [PATCH 6.18 236/315] USB: serial: belkin_sa: validate interrupt status length Date: Sun, 7 Jun 2026 12:00:23 +0200 Message-ID: <20260607095736.234798455@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095727.528828913@linuxfoundation.org> References: <20260607095727.528828913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Cen commit 4ce058df2ee02cc2a0f0fd5cd64ce6f1482a0b65 upstream. The Belkin interrupt callback treats interrupt data as a four-byte status report and reads LSR/MSR fields at offsets 2 and 3. The interrupt-in buffer length is derived from endpoint wMaxPacketSize, and short interrupt transfers may complete successfully with a smaller actual_length. Check the completed interrupt packet length before parsing status fields so short interrupt endpoints and short successful packets are ignored instead of causing out-of-bounds or stale status-byte reads. KASAN report as below: BUG: KASAN: slab-out-of-bounds in belkin_sa_read_int_callback() Read of size 1 Call trace: belkin_sa_read_int_callback() (drivers/usb/serial/belkin_sa.c:202) __usb_hcd_giveback_urb() (drivers/usb/core/hcd.c:1630) dummy_timer() (?:?) Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Assisted-by: Codex:gpt-5.5 Signed-off-by: Zhang Cen Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/belkin_sa.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/serial/belkin_sa.c +++ b/drivers/usb/serial/belkin_sa.c @@ -194,6 +194,9 @@ static void belkin_sa_read_int_callback( usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data); + if (urb->actual_length < BELKIN_SA_MSR_INDEX + 1) + goto exit; + /* Handle known interrupt data */ /* ignore data[0] and data[1] */