From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FBDE2DFF04; Sun, 7 Jun 2026 10:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829411; cv=none; b=l3NNkPvx24u+k5VAGT2eIgOcz9cJmewGBd8PcTtbNRn9ECu7JMP+LBA2XmWW/ZQXx2G9NEETZJG5JKn417DaMueWuT6FapXBLtwVNfkM+IRILgK6vohqWi3YCtN1CqjVasiGtog4PAKAyJthXD3Ofq4hMG8296FyfljXw6qEbnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829411; c=relaxed/simple; bh=YtAy+6NdKRViANMKoXgCXDTAYq8sWi/za+2TisVo604=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o4ZBCNUhx/oSYWOn6CWCzdgA+vHYZ7xHaArbjJev7YHt3HESeqSSrdKJtpFuGwP1voAnBa79fsjtAA7yawhBp4dMrrlSVDlk/k7Dph69cQhQbAUzve5xTeMFCB7KqI/+gjfRDL+pRYJ7pvSo5kS8mK4mc353PURjTIrd5xoRo6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=09F+r71y; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="09F+r71y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A39341F00893; Sun, 7 Jun 2026 10:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780829410; bh=HJUOtFVhNC4M91iIRUcQepZubS6A3uP/O7hGzqhYi8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=09F+r71yNhRsClWC9stVEHn5mK4HUg5v2oath7c3PKnjdqQIXeG7lLVle61IDZSVP B3icu+KivUZ79ouM0VGw0fewQR3Vs5JKc/CjjPl2FnvF/TXRMeA9kVtAV+bc7rNLTX yRzcnPaP8B+sQCrJEY3UMVx4rHYxt7fe6NvP4vKA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Alan Stern , Seungjin Bae Subject: [PATCH 6.18 245/315] usb: gadget: dummy_hcd: Reject hub port requests for non-existent ports Date: Sun, 7 Jun 2026 12:00:32 +0200 Message-ID: <20260607095736.561017919@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095727.528828913@linuxfoundation.org> References: <20260607095727.528828913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Seungjin Bae commit 7d9633528dd40e33964d2dc74a5abbf5c4d116ce upstream. The `dummy_hub_control()` function handles USB hub class requests to the virtual root hub. The `GetPortStatus` case returns -EPIPE for requests with `wIndex != 1`, since the virtual root hub has only a single port. However, the `ClearPortFeature` and `SetPortFeature` cases lack the same check. Fix this by extending the `wIndex != 1` rejection to both cases, matching the existing behavior of `GetPortStatus`. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Suggested-by: Alan Stern Signed-off-by: Seungjin Bae Reviewed-by: Alan Stern Link: https://patch.msgid.link/20260518234314.1889396-1-eeodqql09@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/dummy_hcd.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -2134,6 +2134,8 @@ static int dummy_hub_control( case ClearHubFeature: break; case ClearPortFeature: + if (wIndex != 1) + goto error; switch (wValue) { case USB_PORT_FEAT_SUSPEND: if (hcd->speed == HCD_USB3) { @@ -2248,6 +2250,8 @@ static int dummy_hub_control( retval = -EPIPE; break; case SetPortFeature: + if (wIndex != 1) + goto error; switch (wValue) { case USB_PORT_FEAT_LINK_STATE: if (hcd->speed != HCD_USB3) {