From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE212E7390; Sun, 7 Jun 2026 10:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829417; cv=none; b=MQg/TTjP43RNK/HmbMys4lASbkGpZ0jpLm/l7DzNszARg50imUtYRN1PGwgLm1FzIWeflXqSNuWyiNHFayDjnMS+SbPBFT9evql3uU9CDC+iT0ecSUdZFNU/oyXI2+oJomN3hMfKzC6jkYtTtG7a1ki1WM/0omT2AZAWD37mXmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780829417; c=relaxed/simple; bh=HX7Fnk4TOJx9uAPAEYliLGQRCO4b1OxffPZZOxXx5jY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a2agBgZkgN981N5kHdVu8rKGiIm5AAILh+aDnUV4diBZtsEewvjVxrVjCBnV6jPdkxgqLbXHqeXCADtLdeILfTDUH6GMlT3LHON7/ogL5gbuseHP+/fsIaVdHlFYRvvhKoSrMMv5hpJ6pHYUV/jichgV8q7e3H0fvhlqWPUXcXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c3aF0yPc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c3aF0yPc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F9A1F00893; Sun, 7 Jun 2026 10:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780829416; bh=nlWWIyM+9qlBH0FqHWZM1v3yAyj7Teoq5meK4mIkzbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=c3aF0yPc+kAa5xKvsi6XbDRV/va4NERqz9EOhRnhMyqpkiFx1I2cHQ7JrAjDS54gA Ws3ti22Lh5gCHnDkqNOnnQLjGH7QVOoId8J3Th1eb1i6m2N92hWgdmz+m4Gtgj4G0c YywhnMP1rr8QOlo/aPkxFVPN8mz9XKifqgkQ1RD4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Alan Stern , Seungjin Bae Subject: [PATCH 7.0 277/332] usb: gadget: dummy_hcd: Reject hub port requests for non-existent ports Date: Sun, 7 Jun 2026 12:00:46 +0200 Message-ID: <20260607095738.218890078@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607095728.031258202@linuxfoundation.org> References: <20260607095728.031258202@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Seungjin Bae commit 7d9633528dd40e33964d2dc74a5abbf5c4d116ce upstream. The `dummy_hub_control()` function handles USB hub class requests to the virtual root hub. The `GetPortStatus` case returns -EPIPE for requests with `wIndex != 1`, since the virtual root hub has only a single port. However, the `ClearPortFeature` and `SetPortFeature` cases lack the same check. Fix this by extending the `wIndex != 1` rejection to both cases, matching the existing behavior of `GetPortStatus`. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Suggested-by: Alan Stern Signed-off-by: Seungjin Bae Reviewed-by: Alan Stern Link: https://patch.msgid.link/20260518234314.1889396-1-eeodqql09@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/dummy_hcd.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -2134,6 +2134,8 @@ static int dummy_hub_control( case ClearHubFeature: break; case ClearPortFeature: + if (wIndex != 1) + goto error; switch (wValue) { case USB_PORT_FEAT_SUSPEND: if (hcd->speed == HCD_USB3) { @@ -2248,6 +2250,8 @@ static int dummy_hub_control( retval = -EPIPE; break; case SetPortFeature: + if (wIndex != 1) + goto error; switch (wValue) { case USB_PORT_FEAT_LINK_STATE: if (hcd->speed != HCD_USB3) {