Re: [PATCH] hwmon: (asus-ec-sensors) add ROG MAXIMUS Z790 EXTREME

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing sensor metadata for ROG MAXIMUS Z790 EXTREME causes requested sensors to be silently ignored.
--

commit 409e24c49843127f834ed70831b89be991b9e50c
Author: Brian Downey <bdowne01@gmail.com>

hwmon: (asus-ec-sensors) add ROG MAXIMUS Z790 EXTREME
    
Add support for ROG MAXIMUS Z790 EXTREME

> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index b5d97a27f80d3..34f96aba5cb99 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
[ ... ]
> @@ -514,6 +514,13 @@ static const struct ec_board_info board_info_maximus_z690_formula = {
>  	.family = family_intel_600_series,
>  };
>  
> +static const struct ec_board_info board_info_maximus_z790_extreme = {
> +	.sensors = SENSOR_TEMP_T_SENSOR | SENSOR_TEMP_VRM |
> +		SENSOR_SET_TEMP_WATER | SENSOR_FAN_WATER_FLOW,
> +	.mutex_path = ASUS_HW_ACCESS_MUTEX_RMTW_ASMX,
> +	.family = family_intel_700_series,
> +};
> +

[Severity: Medium]
Will these water sensors be successfully exposed to userspace?

The newly added board configuration specifies SENSOR_SET_TEMP_WATER and
SENSOR_FAN_WATER_FLOW. However, looking at the sensors_family_intel_700 array
used for family_intel_700_series:

static const struct ec_sensor_info sensors_family_intel_700[] = {
	[ec_sensor_temp_t_sensor] =
		EC_SENSOR("T_Sensor", hwmon_temp, 1, 0x01, 0x09),
	[ec_sensor_temp_t_sensor_2] =
		EC_SENSOR("T_Sensor 2", hwmon_temp, 1, 0x01, 0x05),
	[ec_sensor_temp_vrm] = EC_SENSOR("VRM", hwmon_temp, 1, 0x00, 0x33),
	[ec_sensor_fan_cpu_opt] =
		EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
};

This array lacks the initializers for the requested water sensors. Because
they are not explicitly initialized, their definitions default to zero and
they will be silently ignored during sysfs creation.

While the driver safely handles zeroed structs without causing out-of-bounds
reads or sysfs corruption (because get_sensor_value() returns 0 when size=0
and hwmon_genattrs skips attributes without templates), this regression
means the requested water sensors will not be exposed to userspace.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260607144238.128259-1-eugene.shalygin@gmail.com?part=1