From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7732E33A9C1 for ; Sun, 7 Jun 2026 21:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780869262; cv=none; b=dWh9XEayFwlFg1Qk6lEndhGg/Z1WETetlc6dnBo2D0w9/YQLuN9wESfc3o5RdhEDGdqAiZVGSUaQBI8V3gZw+jxZp+MK406PzvBG+O5A1awuRxwvT2rL/vLkA5z+R7pD+JyFimygyVGy8xOS3Qjx+d4TotoA3MrPE2QdPqS1838= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780869262; c=relaxed/simple; bh=f8HqFiBVVZldBsgS3Dak0PrR/3yhxi3hYf6kqY81j3k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KxrRVvMaSANqLyxD270W5X74u2TTMd0ORFg2yaJcWw31pangDZClRu8GkDE4vxQxhIKP5XOUA1ES8OMEw/rWPaIgEXQjubBV2Ca8N9cyHTnrnc8JiTl5mS9y3fhywAOZEqu9CX7wTN6HgAvLhaNPnFyLPaoKF+Arnz4pte2T5JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T3Lx+JFg; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T3Lx+JFg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780869261; x=1812405261; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f8HqFiBVVZldBsgS3Dak0PrR/3yhxi3hYf6kqY81j3k=; b=T3Lx+JFgmCRT3Ap3n9ALzCXLbNbUATpl0l0bhivfMUjDHSh3jZTZnXOU YmjvMSls59eoryeWnqGYaeGlkkyEfT/whZVS3rPsXLOp5geQeQ2Ui8NJT G35CU7BhwXDmluepF1RD5PcfmBw8OIDP2MB8ohm1qyLF7ipCFkZdBSmJm iOKM73Ju4mtkj7QjAoy5MlLPuwAvUVhr0WmTQQiuwrj4LvTSVa9qyk8cv rTURFeROqGfYV5cPBWumxg2p60ae5pqLlhR+mRLpsPwILDuuiOfy0fA67 2OB1bHK2VN3Kt8jzXKmKbOKiAvRQs0V455tY1mg4KHyUwaKCw4LSuHA3b Q==; X-CSE-ConnectionGUID: K22+OdimTZOQPqZdw6EmtA== X-CSE-MsgGUID: ZmZFRjW1SPmwG+H+qr5ucQ== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="107048289" X-IronPort-AV: E=Sophos;i="6.24,193,1774335600"; d="scan'208";a="107048289" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2026 14:54:16 -0700 X-CSE-ConnectionGUID: f4br+wkGRWygKSde6/CLww== X-CSE-MsgGUID: H/oFeQsHSS6LwTGpAf0B5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,193,1774335600"; d="scan'208";a="245490488" Received: from amilburn-desk.amilburn-desk (HELO kekkonen.fi.intel.com) ([10.245.244.101]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2026 14:54:09 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id A75FB12120E; Mon, 08 Jun 2026 00:54:07 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wWLRM-00000003XIJ-0evi; Mon, 08 Jun 2026 00:53:56 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: [PATCH v5 02/10] media: imx219: Scale the vblank limits according to rate_factor Date: Mon, 8 Jun 2026 00:53:48 +0300 Message-ID: <20260607215356.842932-3-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260607215356.842932-1-sakari.ailus@linux.intel.com> References: <20260607215356.842932-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The limits for vertical blanking (and frame length in pixels) is related to the properties of the hardware, it's not in half-line units the driver uses. Multiply the vertical blanking limits by the rate_factor to satisty hardware requirements. Fixes: f513997119f4 ("media: i2c: imx219: Scale the pixel rate for analog binning") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 223d3753cc93..d8fe7db18b6c 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -878,14 +878,17 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2; if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) { + unsigned int rate_factor = imx219_get_rate_factor(state); int exposure_max; int exposure_def; int llp_min; int pixel_rate; /* Update limits and set FPS to default */ - ret = __v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN, - IMX219_FLL_MAX - mode->height, 1, + ret = __v4l2_ctrl_modify_range(imx219->vblank, + IMX219_VBLANK_MIN * rate_factor, + (IMX219_FLL_MAX - mode->height) * + rate_factor, rate_factor, mode->fll_def - mode->height); if (ret) return ret; @@ -928,8 +931,7 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, return ret; /* Scale the pixel rate based on the mode specific factor */ - pixel_rate = imx219_get_pixel_rate(imx219) * - imx219_get_rate_factor(state); + pixel_rate = imx219_get_pixel_rate(imx219) * rate_factor; ret = __v4l2_ctrl_modify_range(imx219->pixel_rate, pixel_rate, pixel_rate, 1, pixel_rate); if (ret) -- 2.47.3