From: Krzysztof Kozlowski <krzk@kernel.org>
To: Herman van Hazendonk <github.com@herrie.org>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: mfd: add ti,lm8502 combo LED + haptic controller
Date: Mon, 8 Jun 2026 12:27:54 +0200 [thread overview]
Message-ID: <20260608-crazy-ruby-impala-c7e9a4@quoll> (raw)
In-Reply-To: <20260603080256.853037-2-github.com@herrie.org>
On Wed, Jun 03, 2026 at 10:02:56AM +0200, Herman van Hazendonk wrote:
> Add a YAML binding for the TI LM8502, an I2C combo LED + haptic
> controller used in the HP TouchPad tablet. The chip is exposed as an
> MFD with two child sub-nodes:
>
> ti,lm8502-leds - LED-class outputs D1..D10 (with per-LED reg
> and led-max-microamp properties)
> ti,lm8502-haptic - EV_FF / FF_RUMBLE input device for the internal
> H-bridge vibrator output, optional
> ti,invert-direction property
>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---
> .../devicetree/bindings/mfd/ti,lm8502.yaml | 160 ++++++++++++++++++
> 1 file changed, 160 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,lm8502.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,lm8502.yaml b/Documentation/devicetree/bindings/mfd/ti,lm8502.yaml
> new file mode 100644
> index 000000000000..10f2e32a0738
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,lm8502.yaml
> @@ -0,0 +1,160 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,lm8502.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI LM8502 combo LED + haptic controller
> +
> +maintainers:
> + - Herman van Hazendonk <github.com@herrie.org>
> +
> +description: |
> + The TI LM8502 is an I2C combo device with ten constant-current LED
> + outputs (D1..D10) and an internal H-bridge that drives a vibrator
> + motor. Pin D10 is shared between the tenth LED channel and the
> + haptic output; the haptic driver writes D10_CURRENT_CTRL = 0 at each
> + start to mux the pin to the H-bridge path.
> +
> + The chip is exposed in Linux as an MFD with two children:
> + - ti,lm8502-leds - LED-class outputs D1..D10
> + - ti,lm8502-haptic - EV_FF / FF_RUMBLE input device
> +
> + The parent node owns the I2C client, the chip-enable GPIO and the
> + vcc regulator; children share access to the parent's regmap.
> +
> +properties:
> + compatible:
> + const: ti,lm8502
And where is any user of that? We do not take unused bindings.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-08 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 8:02 [PATCH 0/1] dt-bindings: mfd: add ti,lm8502 LED + haptic controller Herman van Hazendonk
2026-06-03 8:02 ` [PATCH 1/1] dt-bindings: mfd: add ti,lm8502 combo " Herman van Hazendonk
2026-06-03 8:08 ` sashiko-bot
2026-06-03 8:17 ` Herman van Hazendonk
2026-06-08 10:27 ` Krzysztof Kozlowski
2026-06-08 10:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608-crazy-ruby-impala-c7e9a4@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=github.com@herrie.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.