From: Sasha Levin <sashal@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Simon Liebold <lieboldsimonpaul@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>, Qi Tang <tpluszz77@gmail.com>,
Florian Westphal <fw@strlen.de>,
Simon Liebold <simonlie@amazon.de>
Subject: Re: [PATCH 6.6.y] xfrm: hold dev ref until after transport_finish NF_HOOK
Date: Mon, 8 Jun 2026 20:51:58 -0400 [thread overview]
Message-ID: <20260608-stable-reply-0012@kernel.org> (raw)
In-Reply-To: <20260608082454.2786663-1-simonlie@amazon.de>
> [PATCH 6.6.y] xfrm: hold dev ref until after transport_finish NF_HOOK
I'm holding all four of these (6.6, 6.1, 5.15 and 5.10) for now.
As adapted, the backport leaks a netdev reference on the nested transport-mode
path where both an async and a sync decapsulation happen: the inner dev_hold is
balanced by a dev_put that the older trees don't have, so the saved reference
is never released. Mainline avoids this because it has b05d42eefac7 ("xfrm:
hold device only for the asynchronous decryption") as a prerequisite.
--
Thanks,
Sasha
prev parent reply other threads:[~2026-06-09 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 8:24 [PATCH 6.6.y] xfrm: hold dev ref until after transport_finish NF_HOOK Simon Liebold
2026-06-09 0:51 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608-stable-reply-0012@kernel.org \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lieboldsimonpaul@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simonlie@amazon.de \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tpluszz77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.