From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 166C0CD8C8E for ; Mon, 8 Jun 2026 07:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iM1Jvg0VUgQRv5LRcY7skqYxWmeChG44EjhhNFww3wM=; b=h2SZUhx5bc44OD mawmaLAa0v+tjbaXnVaKiiETJjokDN25sVnly8k91+EEdlGA/A1veipcrUrBW6qaNGmMAwtiUoGYv huKNIbQ3HTq431LoSCd1aYahvYjhvf7AKYQ/pn3c8V0mEcRl0Fkqsm/GdLJaKxtjuHw94gUK0KRvg j0649ZDUCO0xyzu1Hi0gOWI4A7h4zsWDGbryzHkGGmlbb5xxOsdKlWmzGOP+cfzKlle0IBmJh8gCt 7x2EYv4F1EMacYQvlHjikUWyDN0/a9Mm5+wyrArc9/X0mWtPVQNrqxJ9yWz1fWN2ssVmUhw26a1Gf YzEuXvD+cPapSiVz1uCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUJN-00000002yMF-2XXy; Mon, 08 Jun 2026 07:22:17 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUJM-00000002yM9-0TmB for linux-phy@lists.infradead.org; Mon, 08 Jun 2026 07:22:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 79572600AE; Mon, 8 Jun 2026 07:22:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF7F71F00893; Mon, 8 Jun 2026 07:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780903335; bh=EGwF48TOxb/3r3jEtUXLothOzqXjtQDyqEkp8JCs1Kw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Ui0nMbrQH2Hnj8sRo0Bois9+exTzWATKw562J3jFTtut3tSi3n0rUqa2DsMKZFLUt mxnLdq+41bEL2f992+z8LHJxAZo7DtrHm8f3d5m3Qba9ydtwlox3GYcNKgz7aoB1AA iAPjbr0Bk6rkimRqv89aXn2XTs3TzL0VbepvuTc6W3TcADrRmXEN/wInyhsOROBpDZ ccjUPzYDJ+jRdgu9PvSxf17OdjrHTqvBacyKzkey3xq/UvAolJwy0JWqOOzw4PvCC+ Ez6vzNbstSMZ9eVol7Da3hn0M8HHQs6dIL+zu9FgD72zIbXBQf206waN/phKl7hBAT iNaOBdhd9VShA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/5] drm/bridge: Implement generic USB Type-C DP HPD bridge To: "Chaoyi Chen" Cc: olteanv@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20260608070805.88-2-kernel@airkyi.com> References: <20260608070805.88-2-kernel@airkyi.com> Date: Mon, 08 Jun 2026 07:22:14 +0000 Message-Id: <20260608072214.DF7F71F00893@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0NyaXRpY2FsXSBVbmJvdW5kZWQg bWVtb3J5IGxlYWsgYW5kIGRldnJlcyBhY2N1bXVsYXRpb24gZHVlIHRvIG1pc3NpbmcgQlVTX05P VElGWV9ERUxfREVWSUNFIGhhbmRsZXIuCi0gW0hpZ2hdIE1pc3NpbmcgaW5pdGlhbGl6YXRpb24g Zm9yIHByZS1leGlzdGluZyBUeXBlLUMgZGV2aWNlcy4KLSBbSGlnaF0gRG91YmxlIGJyaWRnZSBy ZWdpc3RyYXRpb24gY29uZmxpY3RzIHdpdGggZXhwbGljaXQgY29udHJvbGxlciBkcml2ZXIgYnJp ZGdlcy4KLS0KCmNvbW1pdCA4YjQ2ZDY0ZTI1NTI2OGJjZDdjOWY3NjU2NjQ5ZjBkZmJjYjllMjc3 CkF1dGhvcjogQ2hhb3lpIENoZW4gPGNoYW95aS5jaGVuQHJvY2stY2hpcHMuY29tPgpTdWJqZWN0 OiBkcm0vYnJpZGdlOiBJbXBsZW1lbnQgZ2VuZXJpYyBVU0IgVHlwZS1DIERQIEhQRCBicmlkZ2UK ClRoaXMgcGF0Y2ggaW1wbGVtZW50cyBhIGdlbmVyaWMgRFAgSFBEIGJyaWRnZSB0aGF0IG1vbml0 b3JzIFR5cGUtQyBidXMKZXZlbnRzLiBXaGVuIGEgVHlwZS1DIHBvcnQgZGV2aWNlIGNvbnRhaW5p bmcgdGhlIERQIFNWSUQgaXMgcmVnaXN0ZXJlZCwKaXQgYXV0b21hdGljYWxseSBjcmVhdGVzIGFu IEhQRCBicmlkZ2UgZm9yIGl0IHdpdGhvdXQgcmVxdWlyaW5nIHRoZSBVU0ItQwpjb250cm9sbGVy IGRyaXZlciB0byBpbXBsZW1lbnQgdGhlIGZlYXR1cmUuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL2F1eC1ocGQtdHlwZWMtZHAtYnJpZGdlLmMgYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL2F1eC1ocGQtdHlwZWMtZHAtYnJpZGdlLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmMwOTU3OWZmN2FiOTEKPiAtLS0gL2Rldi9udWxsCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hdXgtaHBkLXR5cGVjLWRwLWJyaWRnZS5jCj4g QEAgLTAsMCArMSw1NCBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCsK WyAuLi4gXQo+ICtzdGF0aWMgaW50IGRybV90eXBlY19idXNfZXZlbnQoc3RydWN0IG5vdGlmaWVy X2Jsb2NrICpuYiwKPiArCQkJICAgICAgIHVuc2lnbmVkIGxvbmcgYWN0aW9uLCB2b2lkICpkYXRh KQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAoc3RydWN0IGRldmljZSAqKWRhdGE7Cj4g KwlzdHJ1Y3QgdHlwZWNfYWx0bW9kZSAqYWx0ID0gdG9fdHlwZWNfYWx0bW9kZShkZXYpOwo+ICsK PiArCWlmIChhY3Rpb24gIT0gQlVTX05PVElGWV9BRERfREVWSUNFKQo+ICsJCXJldHVybiBOT1RJ RllfT0s7CgpbU2V2ZXJpdHk6IENyaXRpY2FsXQpTaW5jZSB0aGlzIG9ubHkgaGFuZGxlcyBCVVNf Tk9USUZZX0FERF9ERVZJQ0UsIHdpbGwgdGhpcyBsZWFrIG1lbW9yeSB3aGVuIGEKY2FibGUgaXMg dW5wbHVnZ2VkPwoKVHlwZS1DIGFsdG1vZGUgZGV2aWNlcyBhcmUgZnJlcXVlbnRseSByZWdpc3Rl cmVkIGFuZCB1bnJlZ2lzdGVyZWQgZHVyaW5nIG5vcm1hbApvcGVyYXRpb24uIEJlY2F1c2UgdGhl cmUgaXMgbm8gQlVTX05PVElGWV9ERUxfREVWSUNFIGhhbmRsZXIgdG8gY2xlYW4gdXAgdGhlc2UK YnJpZGdlcywgYW5kIHRoZSByZWdpc3RyYXRpb24gdXNlcyBhIGRldm0gYWxsb2NhdGlvbiBhdHRh Y2hlZCB0byB0aGUgcGFyZW50CmNvbnRyb2xsZXIsIHdvbid0IGV2ZXJ5IHBsdWcgZXZlbnQgbGVh ayBhIG5ldyBicmlkZ2UgYWxsb2NhdGlvbiBhbmQgSURBIGVudHJ5PwoKPiArCj4gKwkvKgo+ICsJ ICogYWx0LT5kZXYucGFyZW50LT5wYXJlbnQgOiBVU0ItQyBjb250cm9sbGVyIGRldmljZQo+ICsJ ICogYWx0LT5kZXYucGFyZW50ICAgICAgICAgOiBVU0ItQyBjb25uZWN0b3IgZGV2aWNlCj4gKwkg Ki8KPiArCWlmIChpc190eXBlY19wb3J0X2FsdG1vZGUoJmFsdC0+ZGV2KSAmJiBhbHQtPnN2aWQg PT0gVVNCX1RZUEVDX0RQX1NJRCkKPiArCQlkcm1fZHBfaHBkX2JyaWRnZV9yZWdpc3RlcihhbHQt PmRldi5wYXJlbnQtPnBhcmVudCwKPiArCQkJCQkgICB0b19vZl9ub2RlKGFsdC0+ZGV2LnBhcmVu dC0+Zndub2RlKSk7CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhpcyB1bmNvbmRpdGlvbmFsbHkg YWxsb2NhdGUgYSBuZXcgYnJpZGdlIGV2ZW4gaWYgdGhlIGNvbnRyb2xsZXIgZHJpdmVyCmFscmVh ZHkgYWxsb2NhdGVkIG9uZT8KClNldmVyYWwgVHlwZS1DIGNvbnRyb2xsZXIgZHJpdmVycyBhbHJl YWR5IGV4cGxpY2l0bHkgYWxsb2NhdGUgYSBEUCBIUEQgYnJpZGdlCmZvciB0aGVpciBkZXZpY2Ug bm9kZXMgZHVyaW5nIHByb2JlLiBJZiB0aGlzIG5vdGlmaWVyIHJlZ2lzdGVycyBhIHNlY29uZCBi cmlkZ2UKZm9yIHRoZSBleGFjdCBzYW1lIGRldmljZSBub2RlLCB3b24ndCB0aGlzIGNyZWF0ZSBk dXBsaWNhdGUgYnJpZGdlcz8KClRoaXMgY291bGQgYnJlYWsgb2ZfZHJtX2ZpbmRfYnJpZGdlKCks IGNhdXNpbmcgaXQgdG8gcmV0dXJuIHRoZSBicmlkZ2UgY3JlYXRlZApieSB0aGlzIGdlbmVyaWMg bm90aWZpZXIgd2hpbGUgdGhlIGNvbnRyb2xsZXIgZHJpdmVyIGNvbnRpbnVlcyBzZW5kaW5nIGV2 ZW50cwp0byBpdHMgZXhwbGljaXRseSBjcmVhdGVkIGJyaWRnZSwgbGVhZGluZyB0byBtaXNzZWQg SFBEIGV2ZW50cy4KCj4gKwo+ICsJcmV0dXJuIE5PVElGWV9PSzsKPiArfQo+ICsKPiArc3RhdGlj IHN0cnVjdCBub3RpZmllcl9ibG9jayBkcm1fdHlwZWNfZXZlbnRfbmIgPSB7Cj4gKwkubm90aWZp ZXJfY2FsbCA9IGRybV90eXBlY19idXNfZXZlbnQsCj4gK307Cj4gKwo+ICtzdGF0aWMgdm9pZCBk cm1fYXV4X2hwZF90eXBlY19kcF9icmlkZ2VfbW9kdWxlX2V4aXQodm9pZCkKPiArewo+ICsJYnVz X3VucmVnaXN0ZXJfbm90aWZpZXIoJnR5cGVjX2J1cywgJmRybV90eXBlY19ldmVudF9uYik7Cj4g K30KCltTZXZlcml0eTogQ3JpdGljYWxdCkRvZXMgdGhpcyBtb2R1bGUgZXhpdCBmdW5jdGlvbiBs ZWF2ZSBkYW5nbGluZyBkZXZyZXMgYWN0aW9ucz8KClVucmVnaXN0ZXJpbmcgdGhlIG5vdGlmaWVy IHByZXZlbnRzIG5ldyBldmVudHMsIGJ1dCB3aXRob3V0IGEgY2xlYW51cCByb3V0aW5lCmhlcmUg b3IgYSBkZXZpY2UgcmVtb3ZhbCBoYW5kbGVyLCBhbGwgcHJldmlvdXNseSBhY2N1bXVsYXRlZCBk ZXZtIGFjdGlvbnMgZnJvbQpwbHVnIGV2ZW50cyB3aWxsIHJlbWFpbiBhdHRhY2hlZCB0byB0aGUg Y29udHJvbGxlciBkZXZpY2VzIGluZGVmaW5pdGVseS4KCj4gKwo+ICtzdGF0aWMgaW50IF9faW5p dCBkcm1fYXV4X2hwZF90eXBlY19kcF9icmlkZ2VfbW9kdWxlX2luaXQodm9pZCkKPiArewo+ICsJ YnVzX3JlZ2lzdGVyX25vdGlmaWVyKCZ0eXBlY19idXMsICZkcm1fdHlwZWNfZXZlbnRfbmIpOwo+ ICsKPiArCXJldHVybiAwOwo+ICt9CgpbU2V2ZXJpdHk6IEhpZ2hdCklmIHRoaXMgbW9kdWxlIGlz IGxvYWRlZCBhZnRlciB0aGUgVHlwZS1DIHN1YnN5c3RlbSBoYXMgYWxyZWFkeSBwcm9iZWQsIHdp bGwKaXQgbWlzcyBhbGwgZXhpc3RpbmcgZGV2aWNlcz8KCmJ1c19yZWdpc3Rlcl9ub3RpZmllcigp IG9ubHkgaW52b2tlcyB0aGUgY2FsbGJhY2sgZm9yIGV2ZW50cyB0aGF0IG9jY3VyIGFmdGVyCnRo ZSBub3RpZmllciBpcyByZWdpc3RlcmVkLiBEbyB3ZSBuZWVkIHRvIG1hbnVhbGx5IGl0ZXJhdGUg b3ZlciBleGlzdGluZwpkZXZpY2VzIG9uIHR5cGVjX2J1cyB0byBlbnN1cmUgYnJpZGdlcyBhcmUg Y3JlYXRlZCBmb3IgcHJlLWV4aXN0aW5nIERQCmFsdG1vZGVzPwoKLS0gClNhc2hpa28gQUkgcmV2 aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDYwODA3MDgwNS44OC0x LWtlcm5lbEBhaXJreWkuY29tP3BhcnQ9MQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGlu dXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDAB0CD8CA6 for ; Mon, 8 Jun 2026 07:22:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C583D10EE1F; Mon, 8 Jun 2026 07:22:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Ui0nMbrQ"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F8DA10EE1F for ; Mon, 8 Jun 2026 07:22:16 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 79572600AE; Mon, 8 Jun 2026 07:22:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF7F71F00893; Mon, 8 Jun 2026 07:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780903335; bh=EGwF48TOxb/3r3jEtUXLothOzqXjtQDyqEkp8JCs1Kw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Ui0nMbrQH2Hnj8sRo0Bois9+exTzWATKw562J3jFTtut3tSi3n0rUqa2DsMKZFLUt mxnLdq+41bEL2f992+z8LHJxAZo7DtrHm8f3d5m3Qba9ydtwlox3GYcNKgz7aoB1AA iAPjbr0Bk6rkimRqv89aXn2XTs3TzL0VbepvuTc6W3TcADrRmXEN/wInyhsOROBpDZ ccjUPzYDJ+jRdgu9PvSxf17OdjrHTqvBacyKzkey3xq/UvAolJwy0JWqOOzw4PvCC+ Ez6vzNbstSMZ9eVol7Da3hn0M8HHQs6dIL+zu9FgD72zIbXBQf206waN/phKl7hBAT iNaOBdhd9VShA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/5] drm/bridge: Implement generic USB Type-C DP HPD bridge To: "Chaoyi Chen" Cc: olteanv@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20260608070805.88-2-kernel@airkyi.com> References: <20260608070805.88-2-kernel@airkyi.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 08 Jun 2026 07:22:14 +0000 Message-Id: <20260608072214.DF7F71F00893@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Critical] Unbounded memory leak and devres accumulation due to missing B= US_NOTIFY_DEL_DEVICE handler. - [High] Missing initialization for pre-existing Type-C devices. - [High] Double bridge registration conflicts with explicit controller driv= er bridges. -- commit 8b46d64e255268bcd7c9f7656649f0dfbcb9e277 Author: Chaoyi Chen Subject: drm/bridge: Implement generic USB Type-C DP HPD bridge This patch implements a generic DP HPD bridge that monitors Type-C bus events. When a Type-C port device containing the DP SVID is registered, it automatically creates an HPD bridge for it without requiring the USB-C controller driver to implement the feature. > diff --git a/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c b/drivers/g= pu/drm/bridge/aux-hpd-typec-dp-bridge.c > new file mode 100644 > index 0000000000000..c09579ff7ab91 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > @@ -0,0 +1,54 @@ > +// SPDX-License-Identifier: GPL-2.0+ [ ... ] > +static int drm_typec_bus_event(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + struct device *dev =3D (struct device *)data; > + struct typec_altmode *alt =3D to_typec_altmode(dev); > + > + if (action !=3D BUS_NOTIFY_ADD_DEVICE) > + return NOTIFY_OK; [Severity: Critical] Since this only handles BUS_NOTIFY_ADD_DEVICE, will this leak memory when a cable is unplugged? Type-C altmode devices are frequently registered and unregistered during no= rmal operation. Because there is no BUS_NOTIFY_DEL_DEVICE handler to clean up th= ese bridges, and the registration uses a devm allocation attached to the parent controller, won't every plug event leak a new bridge allocation and IDA ent= ry? > + > + /* > + * alt->dev.parent->parent : USB-C controller device > + * alt->dev.parent : USB-C connector device > + */ > + if (is_typec_port_altmode(&alt->dev) && alt->svid =3D=3D USB_TYPEC_DP_S= ID) > + drm_dp_hpd_bridge_register(alt->dev.parent->parent, > + to_of_node(alt->dev.parent->fwnode)); [Severity: High] Does this unconditionally allocate a new bridge even if the controller driv= er already allocated one? Several Type-C controller drivers already explicitly allocate a DP HPD brid= ge for their device nodes during probe. If this notifier registers a second br= idge for the exact same device node, won't this create duplicate bridges? This could break of_drm_find_bridge(), causing it to return the bridge crea= ted by this generic notifier while the controller driver continues sending even= ts to its explicitly created bridge, leading to missed HPD events. > + > + return NOTIFY_OK; > +} > + > +static struct notifier_block drm_typec_event_nb =3D { > + .notifier_call =3D drm_typec_bus_event, > +}; > + > +static void drm_aux_hpd_typec_dp_bridge_module_exit(void) > +{ > + bus_unregister_notifier(&typec_bus, &drm_typec_event_nb); > +} [Severity: Critical] Does this module exit function leave dangling devres actions? Unregistering the notifier prevents new events, but without a cleanup routi= ne here or a device removal handler, all previously accumulated devm actions f= rom plug events will remain attached to the controller devices indefinitely. > + > +static int __init drm_aux_hpd_typec_dp_bridge_module_init(void) > +{ > + bus_register_notifier(&typec_bus, &drm_typec_event_nb); > + > + return 0; > +} [Severity: High] If this module is loaded after the Type-C subsystem has already probed, will it miss all existing devices? bus_register_notifier() only invokes the callback for events that occur aft= er the notifier is registered. Do we need to manually iterate over existing devices on typec_bus to ensure bridges are created for pre-existing DP altmodes? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260608070805.88-1= -kernel@airkyi.com?part=3D1