From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69631CD8C9F for ; Mon, 8 Jun 2026 07:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRImOH6VMlehdDAygM4C2hIYxRpEq1S4t47E/oIVXec=; b=NY/A+yM/q++TSr axXz9Pb8aCLdv0lT85RaUUeRi1URnXBGNX2iVBoF8lEvi9ycJG/HMFM2AQqEp6QggvUS6CcSxoW8K KPnM7cDrvacKT7ggFXCPc9mjPQLA+aCS3LJJ8fc72QctpSN9docJZoauZR6bP91AaYkilzvdX4f/3 mS6OOso0OkiPpdI7fgqUsPW3jwwp8FNXMFbG9/erR34GcYplpFMDNa1TkhQEvB4aNSdMULwxWveBF FZvPVoNtuArel4XxR+zUz22S0vN9OjlNU7lLBVJ3JYEuCBNwglyo6Sy3PxqEdtgZ4Exi2g+DZaKS6 8Vv64m5cYxBDspGFDUhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUsT-000000031UF-3L8V; Mon, 08 Jun 2026 07:58:33 +0000 Received: from mgamail.intel.com ([198.175.65.14]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWUsR-000000031Rq-0wJV for linux-i3c@lists.infradead.org; Mon, 08 Jun 2026 07:58:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780905512; x=1812441512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XO4DeisrwcQtk5baWXSHoM5AXo8nYE21pzj0QPcZ7AA=; b=fdhNqpmRDGBFceu72BxgN3ugSYD/k1cjW3ImKHQC0FTUfAU2+e2OywoI Nsab33Uo7a6VlDDaiqV5x+FEIk9LwV+r3E3wxa9U6wW2Mzq4SMhwceQnM f+0wbP1n6Ojvm3OZ9yGB8mIxMixjf1yfJIacvGEcaJ6/kEeAyNcigkgZ9 G1HgtrZHqwAQ1O1Y6HB06+p5ohCrxpMb+4DzeqJkwKaRS8B/Rj8FFBtlX 88VGalpIj2a50ZDtoKjX++21B4clocbbUwoKLwemJn7Yd0TIzfjDiGsNK 2Ses5mKw9quc6EHhvYCxBHe6Cv2sF5GZXTKT9UEAZXcGz4rRSLRRw0FzL A==; X-CSE-ConnectionGUID: biDSraChT/+W4DfDFYdWww== X-CSE-MsgGUID: yLYwZ9zHS5yTr4el7Grygw== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="85520168" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="85520168" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:58:31 -0700 X-CSE-ConnectionGUID: dKWuDpKiTZ+YuZ0K6aJ/rw== X-CSE-MsgGUID: pBhpL7xKRQODLrqVlTwC7A== X-ExtLoop1: 1 Received: from conormcd-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.114]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:58:29 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 4/7] i3c: mipi-i3c-hci: Tolerate i3c_master_add_i3c_dev_locked() failures in DAA Date: Mon, 8 Jun 2026 10:57:57 +0300 Message-ID: <20260608075801.16111-5-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260608075801.16111-1-adrian.hunter@intel.com> References: <20260608075801.16111-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260608_005831_309739_558BF0FC X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org i3c_master_add_i3c_dev_locked() no longer leaves the address marked as free on failure, so aborting the DAA sequence on its error is unnecessary. Failure to register a discovered device does not invalidate the entire Dynamic Address Assignment (DAA) procedure. Align with the behavior of other I3C master drivers by ignoring errors from i3c_master_add_i3c_dev_locked() and continuing enumeration. Signed-off-by: Adrian Hunter --- Changes in V2: None drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 4 +--- drivers/i3c/master/mipi-i3c-hci/cmd_v2.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c index 75d452d7f6af..3b9345718d27 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c @@ -358,9 +358,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci) * TODO: Extend the subsystem layer to allow for registering * new device and provide BCR/DCR/PID at the same time. */ - ret = i3c_master_add_i3c_dev_locked(&hci->master, next_addr); - if (ret) - break; + i3c_master_add_i3c_dev_locked(&hci->master, next_addr); } if (dat_idx >= 0) diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c index 39eec26a363c..8d93748e858d 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c @@ -296,9 +296,7 @@ static int hci_cmd_v2_daa(struct i3c_hci *hci) * TODO: Extend the subsystem layer to allow for registering * new device and provide BCR/DCR/PID at the same time. */ - ret = i3c_master_add_i3c_dev_locked(&hci->master, next_addr); - if (ret) - break; + i3c_master_add_i3c_dev_locked(&hci->master, next_addr); } hci_free_xfer(xfer, 2); -- 2.51.0 -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7935439A04B for ; Mon, 8 Jun 2026 07:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905512; cv=none; b=KhBm+DuWpCIx7LfscWNpAdanUbY8obQSROG4WUL5uIXLhHmxYD56V8XRcSQbbyMRnKVvtVh8F6hxpg8IRMmQqqNtRQmn6CHiQM9r0T7TGxfjSwZRjeKBD2U9ikVZRMGpXVYYCMKrh/fHC7yZ+0f2WszY3/EeJN13vyuDSBMygA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905512; c=relaxed/simple; bh=XO4DeisrwcQtk5baWXSHoM5AXo8nYE21pzj0QPcZ7AA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GomVAwuprDh/xNCGWRJXxGqD0p9fDdCoXk+BeChVavjBbOj9Xs9WKvilZPA3F4PjqPv10IKj5gt/tWwdCIB9XeC1v0VmhpCcfExaYHPl0pkGGuPKj5kIfU5OJi7xvBwb9uiLI26vvH8ijq/20kJOvY0lcJHOTpS6wKQVurVwLiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fdhNqpmR; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fdhNqpmR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780905512; x=1812441512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XO4DeisrwcQtk5baWXSHoM5AXo8nYE21pzj0QPcZ7AA=; b=fdhNqpmRDGBFceu72BxgN3ugSYD/k1cjW3ImKHQC0FTUfAU2+e2OywoI Nsab33Uo7a6VlDDaiqV5x+FEIk9LwV+r3E3wxa9U6wW2Mzq4SMhwceQnM f+0wbP1n6Ojvm3OZ9yGB8mIxMixjf1yfJIacvGEcaJ6/kEeAyNcigkgZ9 G1HgtrZHqwAQ1O1Y6HB06+p5ohCrxpMb+4DzeqJkwKaRS8B/Rj8FFBtlX 88VGalpIj2a50ZDtoKjX++21B4clocbbUwoKLwemJn7Yd0TIzfjDiGsNK 2Ses5mKw9quc6EHhvYCxBHe6Cv2sF5GZXTKT9UEAZXcGz4rRSLRRw0FzL A==; X-CSE-ConnectionGUID: D79VvYr7RKSHHnze3cenjg== X-CSE-MsgGUID: p50Wy1i1Q46910S34BqkTA== X-IronPort-AV: E=McAfee;i="6800,10657,11810"; a="85520169" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="85520169" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:58:31 -0700 X-CSE-ConnectionGUID: dKWuDpKiTZ+YuZ0K6aJ/rw== X-CSE-MsgGUID: pBhpL7xKRQODLrqVlTwC7A== X-ExtLoop1: 1 Received: from conormcd-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.114]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 00:58:29 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 4/7] i3c: mipi-i3c-hci: Tolerate i3c_master_add_i3c_dev_locked() failures in DAA Date: Mon, 8 Jun 2026 10:57:57 +0300 Message-ID: <20260608075801.16111-5-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260608075801.16111-1-adrian.hunter@intel.com> References: <20260608075801.16111-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit i3c_master_add_i3c_dev_locked() no longer leaves the address marked as free on failure, so aborting the DAA sequence on its error is unnecessary. Failure to register a discovered device does not invalidate the entire Dynamic Address Assignment (DAA) procedure. Align with the behavior of other I3C master drivers by ignoring errors from i3c_master_add_i3c_dev_locked() and continuing enumeration. Signed-off-by: Adrian Hunter --- Changes in V2: None drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 4 +--- drivers/i3c/master/mipi-i3c-hci/cmd_v2.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c index 75d452d7f6af..3b9345718d27 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c @@ -358,9 +358,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci) * TODO: Extend the subsystem layer to allow for registering * new device and provide BCR/DCR/PID at the same time. */ - ret = i3c_master_add_i3c_dev_locked(&hci->master, next_addr); - if (ret) - break; + i3c_master_add_i3c_dev_locked(&hci->master, next_addr); } if (dat_idx >= 0) diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c index 39eec26a363c..8d93748e858d 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c @@ -296,9 +296,7 @@ static int hci_cmd_v2_daa(struct i3c_hci *hci) * TODO: Extend the subsystem layer to allow for registering * new device and provide BCR/DCR/PID at the same time. */ - ret = i3c_master_add_i3c_dev_locked(&hci->master, next_addr); - if (ret) - break; + i3c_master_add_i3c_dev_locked(&hci->master, next_addr); } hci_free_xfer(xfer, 2); -- 2.51.0